import CmdLineOpts ( opt_WarnNameShadowing, opt_WarnUnusedMatches,
opt_WarnUnusedBinds, opt_WarnUnusedImports )
import HsSyn
-import RdrHsSyn ( RdrName(..), RdrNameIE,
- rdrNameOcc, isQual, qual, isClassDataConRdrName
- )
+import RdrHsSyn ( RdrNameIE )
+import RdrName ( RdrName, rdrNameModule, rdrNameOcc, isQual, mkRdrUnqual, qualifyRdrName )
import HsTypes ( getTyVarName, replaceTyVarName )
-import BasicTypes ( Fixity(..), FixityDirection(..), IfaceFlavour(..) )
+import BasicTypes ( Fixity(..), FixityDirection(..) )
import RnMonad
-import Name ( Name, OccName(..), Provenance(..), ExportFlag(..), NamedThing(..),
- occNameFlavour, getSrcLoc, occNameString,
- mkLocalName, mkGlobalName,
- nameOccName, setNameProvenance, isVarOcc,
- getNameProvenance, pprOccName, isLocalName,
- dictNamePrefix
+import Name ( Name, Provenance(..), ExportFlag(..), NamedThing(..),
+ ImportReason(..), getSrcLoc,
+ mkLocalName, mkGlobalName, isSystemName,
+ nameOccName, nameModule, setNameModule,
+ pprOccName, isLocallyDefined, nameUnique, nameOccName,
+ setNameProvenance, getNameProvenance, pprNameProvenance
)
import NameSet
+import OccName ( OccName,
+ mkDFunOcc,
+ occNameFlavour
+ )
+import Module ( moduleIfaceFlavour )
import TyCon ( TyCon )
-import TysWiredIn ( tupleTyCon, unboxedTupleTyCon,
- listTyCon, charTyCon )
import FiniteMap
import Unique ( Unique, Uniquable(..), unboundKey )
-import UniqFM ( listToUFM, plusUFM_C )
+import UniqFM ( emptyUFM, listToUFM, plusUFM_C )
import UniqSupply
import SrcLoc ( SrcLoc, noSrcLoc )
import Outputable
-import Util ( removeDups )
+import Util ( removeDups, equivClasses, thenCmp )
import List ( nub )
-import Char ( isAlphanum )
+import Maybes ( mapMaybe )
\end{code}
%*********************************************************
\begin{code}
-newImportedGlobalName :: Module -> OccName
- -> IfaceFlavour
- -> RnM s d Name
-newImportedGlobalName mod occ hif
+newImportedGlobalName :: Module -> OccName -> RnM s d Name
+newImportedGlobalName mod occ
= -- First check the cache
getNameSupplyRn `thenRn` \ (us, inst_ns, cache) ->
let
- key = (mod,occ)
- prov = NonLocalDef noSrcLoc hif False
+ key = (mod,occ)
in
case lookupFM cache key of
-
+
-- A hit in the cache!
- -- If it has no provenance at the moment then set its provenance
+ -- Make sure that the module in the name has the same IfaceFlavour as
+ -- the module we are looking for; if not, make it so
-- so that it has the right HiFlag component.
- -- (This is necessary
- -- for known-key things. For example, GHCmain.lhs imports as SOURCE
- -- Main; but Main.main is a known-key thing.)
- -- Don't fiddle with the provenance if it already has one
- Just name -> case getNameProvenance name of
- NoProvenance -> let
- new_name = setNameProvenance name prov
- new_cache = addToFM cache key new_name
- in
- setNameSupplyRn (us, inst_ns, new_cache) `thenRn_`
- returnRn new_name
- other -> returnRn name
+ -- (This is necessary for known-key things.
+ -- For example, GHCmain.lhs imports as SOURCE
+ -- Main; but Main.main is a known-key thing.)
+ Just name | isSystemName name -- A known-key name; fix the provenance and module
+ -> getOmitQualFn `thenRn` \ omit_fn ->
+ let
+ new_name = setNameProvenance (setNameModule name mod)
+ (NonLocalDef ImplicitImport (omit_fn name))
+ new_cache = addToFM cache key new_name
+ in
+ setNameSupplyRn (us, inst_ns, new_cache) `thenRn_`
+ returnRn new_name
+
+ | otherwise
+ -> returnRn name
Nothing -> -- Miss in the cache!
-- Build a new original name, and put it in the cache
+ getOmitQualFn `thenRn` \ omit_fn ->
+ setModuleFlavourRn mod `thenRn` \ mod' ->
let
(us', us1) = splitUniqSupply us
uniq = uniqFromSupply us1
- name = mkGlobalName uniq mod occ prov
+ name = mkGlobalName uniq mod' occ (NonLocalDef ImplicitImport (omit_fn name))
+ -- For in-scope things we improve the provenance
+ -- in RnNames.importsFromImportDecl
new_cache = addToFM cache key name
in
setNameSupplyRn (us', inst_ns, new_cache) `thenRn_`
returnRn name
-{-
- let
- pprC ((mod,occ),name) = pprModule mod <> text "." <> pprOccName occ <+> text "--->"
- <+> ppr name
- in
- pprTrace "ng" (vcat [text "newGlobalName miss" <+> pprModule mod <+> pprOccName occ,
- brackets (sep (map pprC (fmToList cache))),
- text ""
- ]) $
--}
+
+newImportedGlobalFromRdrName rdr_name
+ | isQual rdr_name
+ = newImportedGlobalName (rdrNameModule rdr_name) (rdrNameOcc rdr_name)
+
+ | otherwise
+ = -- An Unqual is allowed; interface files contain
+ -- unqualified names for locally-defined things, such as
+ -- constructors of a data type.
+ getModuleRn `thenRn ` \ mod_name ->
+ newImportedGlobalName mod_name (rdrNameOcc rdr_name)
newLocallyDefinedGlobalName :: Module -> OccName
= -- First check the cache
getNameSupplyRn `thenRn` \ (us, inst_ns, cache) ->
let
- key = (mod,occ)
+ key = (mod,occ)
+ mk_prov name = LocalDef loc (rec_exp_fn name)
+ -- We must set the provenance of the thing in the cache
+ -- correctly, particularly whether or not it is locally defined.
+ --
+ -- Since newLocallyDefinedGlobalName is used only
+ -- at binding occurrences, we may as well get the provenance
+ -- dead right first time; hence the rec_exp_fn passed in
in
case lookupFM cache key of
-- Overwrite whatever provenance is in the cache already;
-- this updates WiredIn things and known-key things,
-- which are there from the start, to LocalDef.
+ --
+ -- It also means that if there are two defns for the same thing
+ -- in a module, then each gets a separate SrcLoc
Just name -> let
- new_name = setNameProvenance name (LocalDef loc (rec_exp_fn new_name))
+ new_name = setNameProvenance name (mk_prov new_name)
new_cache = addToFM cache key new_name
in
setNameSupplyRn (us, inst_ns, new_cache) `thenRn_`
-- Miss in the cache!
-- Build a new original name, and put it in the cache
Nothing -> let
- provenance = LocalDef loc (rec_exp_fn new_name)
(us', us1) = splitUniqSupply us
uniq = uniqFromSupply us1
- new_name = mkGlobalName uniq mod occ provenance
+ new_name = mkGlobalName uniq mod occ (mk_prov new_name)
new_cache = addToFM cache key new_name
in
setNameSupplyRn (us', inst_ns, new_cache) `thenRn_`
returnRn new_name
--- newDfunName is a variant, specially for dfuns.
--- When renaming derived definitions we are in *interface* mode (because we can trip
--- over original names), but we still want to make the Dfun locally-defined.
--- So we can't use whether or not we're in source mode to decide the locally-defined question.
-newDfunName :: OccName -> OccName -> Maybe RdrName -> SrcLoc -> RnMS s Name
-newDfunName _ _ (Just n) src_loc -- Imported ones have "Just n"
- = getModuleRn `thenRn` \ mod_name ->
- newImportedGlobalName mod_name (rdrNameOcc n) HiFile {- Correct? -}
-newDfunName cl_nm tycon_nm Nothing src_loc -- Local instance decls have a "Nothing"
- = getModuleRn `thenRn` \ mod_name ->
- newInstUniq name `thenRn` \ inst_uniq ->
- let
- dfun_occ = VarOcc (dictNamePrefix _APPEND_
- name _APPEND_ _PK_(show inst_uniq))
- in
- newLocallyDefinedGlobalName mod_name dfun_occ
- (\_ -> Exported) src_loc
- where
- {-
- Dictionary names have the following form
-
- _d<class><tycon><n>
-
- where "n" is a positive number, and "tycon" is the
- name of the type constructor for which a "class"
- instance is derived.
-
- Prefixing dictionary names with their class and instance
- types improves the behaviour of the recompilation checker.
- (fewer recompilations required should an instance or type
- declaration be added to a module.)
- -}
- -- We're dropping the modids on purpose.
- tycon_nm_str = _PK_(map trHash (_UNPK_(occNameString tycon_nm)))
- cl_nm_str = _PK_(map trHash (_UNPK_(occNameString cl_nm)))
-
- trHash '#' = '_'
- trHash c = c
-
- -- give up on any type constructor that starts with a
- -- non-alphanumeric char (e.g., [] (,*)
- name
- | (_NULL_ tycon_nm_str) || not (isAlphanum (_HEAD_ (tycon_nm_str))) = cl_nm_str
- | otherwise = cl_nm_str _APPEND_ tycon_nm_str
-
-
newLocalNames :: [(RdrName,SrcLoc)] -> RnM s d [Name]
newLocalNames rdr_names
= getNameSupplyRn `thenRn` \ (us, inst_ns, cache) ->
n = length rdr_names
(us', us1) = splitUniqSupply us
uniqs = uniqsFromSupply n us1
- locals = [ mkLocalName uniq (rdrNameOcc rdr_name)
+ locals = [ mkLocalName uniq (rdrNameOcc rdr_name) loc
| ((rdr_name,loc), uniq) <- rdr_names `zip` uniqs
]
in
setNameSupplyRn (us', inst_ns, cache) `thenRn_`
returnRn locals
+newDFunName cl_occ tycon_occ (Just n) src_loc -- Imported ones have "Just n"
+ = newImportedGlobalFromRdrName n
+
+newDFunName cl_occ tycon_occ Nothing src_loc -- Local instance decls have a "Nothing"
+ = getModuleRn `thenRn` \ mod_name ->
+ newInstUniq (cl_occ, tycon_occ) `thenRn` \ inst_uniq ->
+ let
+ dfun_occ = mkDFunOcc cl_occ tycon_occ inst_uniq
+ in
+ newLocallyDefinedGlobalName mod_name dfun_occ (\_ -> Exported) src_loc
+
+
-- mkUnboundName makes a place-holder Name; it shouldn't be looked at except possibly
-- during compiler debugging.
mkUnboundName :: RdrName -> Name
-mkUnboundName rdr_name = mkLocalName unboundKey (rdrNameOcc rdr_name)
+mkUnboundName rdr_name = mkLocalName unboundKey (rdrNameOcc rdr_name) noSrcLoc
isUnboundName :: Name -> Bool
isUnboundName name = getUnique name == unboundKey
\end{code}
\begin{code}
+-------------------------------------
bindLocatedLocalsRn :: SDoc -- Documentation string for error message
-> [(RdrName,SrcLoc)]
-> ([Name] -> RnMS s a)
newLocalNames rdr_names_w_loc `thenRn` \ names ->
let
- new_name_env = addListToFM name_env (map fst rdr_names_w_loc `zip` names)
+ new_name_env = addListToRdrEnv name_env (map fst rdr_names_w_loc `zip` names)
in
setLocalNameEnv new_name_env (enclosed_scope names)
where
check_shadow name_env (rdr_name,loc)
- = case lookupFM name_env rdr_name of
+ = case lookupRdrEnv name_env rdr_name of
Nothing -> returnRn ()
Just name -> pushSrcLocRn loc $
addWarnRn (shadowedNameWarn rdr_name)
+
+-------------------------------------
bindLocalsRn doc_str rdr_names enclosed_scope
= getSrcLocRn `thenRn` \ loc ->
bindLocatedLocalsRn (text doc_str)
(rdr_names `zip` repeat loc)
enclosed_scope
+ -- binLocalsFVRn is the same as bindLocalsRn
+ -- except that it deals with free vars
+bindLocalsFVRn doc_str rdr_names enclosed_scope
+ = bindLocalsRn doc_str rdr_names $ \ names ->
+ enclosed_scope names `thenRn` \ (thing, fvs) ->
+ returnRn (thing, delListFromNameSet fvs names)
+
+-------------------------------------
+extendTyVarEnvFVRn :: [HsTyVar Name] -> RnMS s (a, FreeVars) -> RnMS s (a, FreeVars)
+ -- This tiresome function is used only in rnDecl on InstDecl
+extendTyVarEnvFVRn tyvars enclosed_scope
+ = getLocalNameEnv `thenRn` \ env ->
+ let
+ tyvar_names = map getTyVarName tyvars
+ new_env = addListToRdrEnv env [ (mkRdrUnqual (getOccName name), name)
+ | name <- tyvar_names
+ ]
+ in
+ setLocalNameEnv new_env enclosed_scope `thenRn` \ (thing, fvs) ->
+ returnRn (thing, delListFromNameSet fvs tyvar_names)
+
+bindTyVarsRn :: SDoc -> [HsTyVar RdrName]
+ -> ([HsTyVar Name] -> RnMS s a)
+ -> RnMS s a
bindTyVarsRn doc_str tyvar_names enclosed_scope
+ = bindTyVars2Rn doc_str tyvar_names $ \ names tyvars ->
+ enclosed_scope tyvars
+
+-- Gruesome name: return Names as well as HsTyVars
+bindTyVars2Rn :: SDoc -> [HsTyVar RdrName]
+ -> ([Name] -> [HsTyVar Name] -> RnMS s a)
+ -> RnMS s a
+bindTyVars2Rn doc_str tyvar_names enclosed_scope
= getSrcLocRn `thenRn` \ loc ->
let
located_tyvars = [(getTyVarName tv, loc) | tv <- tyvar_names]
in
bindLocatedLocalsRn doc_str located_tyvars $ \ names ->
- enclosed_scope (zipWith replaceTyVarName tyvar_names names)
-
- -- Works in any variant of the renamer monad
+ enclosed_scope names (zipWith replaceTyVarName tyvar_names names)
+
+bindTyVarsFVRn :: SDoc -> [HsTyVar RdrName]
+ -> ([HsTyVar Name] -> RnMS s (a, FreeVars))
+ -> RnMS s (a, FreeVars)
+bindTyVarsFVRn doc_str rdr_names enclosed_scope
+ = bindTyVars2Rn doc_str rdr_names $ \ names tyvars ->
+ enclosed_scope tyvars `thenRn` \ (thing, fvs) ->
+ returnRn (thing, delListFromNameSet fvs names)
+
+bindTyVarsFV2Rn :: SDoc -> [HsTyVar RdrName]
+ -> ([Name] -> [HsTyVar Name] -> RnMS s (a, FreeVars))
+ -> RnMS s (a, FreeVars)
+bindTyVarsFV2Rn doc_str rdr_names enclosed_scope
+ = bindTyVars2Rn doc_str rdr_names $ \ names tyvars ->
+ enclosed_scope names tyvars `thenRn` \ (thing, fvs) ->
+ returnRn (thing, delListFromNameSet fvs names)
+
+
+-------------------------------------
checkDupOrQualNames, checkDupNames :: SDoc
-> [(RdrName, SrcLoc)]
-> RnM s d ()
+ -- Works in any variant of the renamer monad
checkDupOrQualNames doc_str rdr_names_w_loc
= -- Check for use of qualified names
returnRn ()
where
(_, dups) = removeDups (\(n1,l1) (n2,l2) -> n1 `compare` n2) rdr_names_w_loc
-
-
--- Yuk!
-ifaceFlavour name = case getNameProvenance name of
- NonLocalDef _ hif _ -> hif
- other -> HiFile -- Shouldn't happen
\end{code}
Looking up a name in the RnEnv.
\begin{code}
-checkUnboundRn :: RdrName -> Maybe Name -> RnMS s Name
-checkUnboundRn rdr_name (Just name)
- = -- Found it!
- returnRn name
+lookupBndrRn rdr_name
+ = getNameEnvs `thenRn` \ (global_env, local_env) ->
+
+ -- Try local env
+ case lookupRdrEnv local_env rdr_name of {
+ Just name -> returnRn name ;
+ Nothing ->
-checkUnboundRn rdr_name Nothing
- = -- Not found by lookup
getModeRn `thenRn` \ mode ->
case mode of
- -- Not found when processing source code; so fail
- SourceMode -> failWithRn (mkUnboundName rdr_name)
- (unknownNameErr rdr_name)
-
- -- Not found when processing an imported declaration,
- -- so we create a new name for the purpose
- InterfaceMode _ _ ->
- case rdr_name of
- Qual mod_name occ hif -> newImportedGlobalName mod_name occ hif
-
- -- An Unqual is allowed; interface files contain
- -- unqualified names for locally-defined things, such as
- -- constructors of a data type.
- Unqual occ -> getModuleRn `thenRn ` \ mod_name ->
- newImportedGlobalName mod_name occ HiFile
-
-
-lookupBndrRn rdr_name
- = lookupNameRn rdr_name `thenRn` \ maybe_name ->
- checkUnboundRn rdr_name maybe_name `thenRn` \ name ->
-
- if isLocalName name then
- returnRn name
- else
-
- ----------------------------------------------------
- -- OK, so we're at the binding site of a top-level defn
- -- Check to see whether its an imported decl
- getModeRn `thenRn` \ mode ->
- case mode of {
- SourceMode -> returnRn name ;
-
- InterfaceMode _ print_unqual_fn ->
-
- ----------------------------------------------------
- -- OK, the binding site of an *imported* defn
- -- so we can make the provenance more informative
- getSrcLocRn `thenRn` \ src_loc ->
- let
- name' = case getNameProvenance name of
- NonLocalDef _ hif _ -> setNameProvenance name
- (NonLocalDef src_loc hif (print_unqual_fn name'))
- other -> name
- in
- returnRn name'
+ InterfaceMode _ -> -- Look in the global name cache
+ newImportedGlobalFromRdrName rdr_name
+
+ SourceMode -> -- Source mode, so look up a *qualified* version
+ -- of the name, so that we get the right one even
+ -- if there are many with the same occ name
+ -- There must *be* a binding
+ getModuleRn `thenRn` \ mod ->
+ case lookupRdrEnv global_env (qualifyRdrName mod rdr_name) of
+ Just (name:rest) -> ASSERT( null rest )
+ returnRn name
+ Nothing -> pprPanic "lookupBndrRn" (ppr mod <+> ppr rdr_name)
}
-- Just like lookupRn except that we record the occurrence too
-- deciding which instance declarations to import.
lookupOccRn :: RdrName -> RnMS s Name
lookupOccRn rdr_name
- = lookupNameRn rdr_name `thenRn` \ maybe_name ->
- checkUnboundRn rdr_name maybe_name `thenRn` \ name ->
- let
- name' = mungePrintUnqual rdr_name name
- in
- addOccurrenceName name'
+ = getNameEnvs `thenRn` \ (global_env, local_env) ->
+ lookup_occ global_env local_env rdr_name `thenRn` \ name ->
+ addOccurrenceName name
-- lookupGlobalOccRn is like lookupOccRn, except that it looks in the global
-- environment. It's used only for
-- class op names in class and instance decls
lookupGlobalOccRn :: RdrName -> RnMS s Name
lookupGlobalOccRn rdr_name
- = lookupGlobalNameRn rdr_name `thenRn` \ maybe_name ->
- checkUnboundRn rdr_name maybe_name `thenRn` \ name ->
- let
- name' = mungePrintUnqual rdr_name name
- in
- addOccurrenceName name'
-
-
--- mungePrintUnqual is used to make *imported* *occurrences* print unqualified
--- if they were mentioned unqualified in the source code.
--- This improves error messages from the type checker.
--- NB: the binding site is treated differently; see lookupBndrRn
--- After the type checker all occurrences are replaced by the one
--- at the binding site.
-mungePrintUnqual (Qual _ _ _) name = name
-mungePrintUnqual (Unqual _) name = case new_prov of
- Nothing -> name
- Just prov' -> setNameProvenance name prov'
- where
- new_prov = case getNameProvenance name of
- NonLocalDef loc hif False -> Just (NonLocalDef loc hif True)
- other -> Nothing
+ = getNameEnvs `thenRn` \ (global_env, local_env) ->
+ lookup_global_occ global_env rdr_name `thenRn` \ name ->
+ addOccurrenceName name
+
+-- Look in both local and global env
+lookup_occ global_env local_env rdr_name
+ = case lookupRdrEnv local_env rdr_name of
+ Just name -> returnRn name
+ Nothing -> lookup_global_occ global_env rdr_name
+
+-- Look in global env only
+lookup_global_occ global_env rdr_name
+ = case lookupRdrEnv global_env rdr_name of
+ Just [name] -> returnRn name
+ Just stuff@(name:_) -> addNameClashErrRn rdr_name stuff `thenRn_`
+ returnRn name
+ Nothing -> getModeRn `thenRn` \ mode ->
+ case mode of
+ -- Not found when processing source code; so fail
+ SourceMode -> failWithRn (mkUnboundName rdr_name)
+ (unknownNameErr rdr_name)
+
+ -- Not found when processing an imported declaration,
+ -- so we create a new name for the purpose
+ InterfaceMode _ -> newImportedGlobalFromRdrName rdr_name
+
-- lookupImplicitOccRn takes an RdrName representing an *original* name, and
-- adds it to the occurrence pool so that it'll be loaded later. This is
-- used when language constructs (such as monad comprehensions, overloaded literals,
-- The name cache should have the correct provenance, though.
lookupImplicitOccRn :: RdrName -> RnMS s Name
-lookupImplicitOccRn (Qual mod occ hif)
- = newImportedGlobalName mod occ hif `thenRn` \ name ->
+lookupImplicitOccRn rdr_name
+ = newImportedGlobalFromRdrName rdr_name `thenRn` \ name ->
addOccurrenceName name
addImplicitOccRn :: Name -> RnMS s Name
addImplicitOccsRn :: [Name] -> RnMS s ()
addImplicitOccsRn names = addOccurrenceNames names
-
-charTyCon_name = getName charTyCon
-listTyCon_name = getName listTyCon
-
-tupleTyCon_name True n = getName (tupleTyCon n)
-tupleTyCon_name False n = getName (unboxedTupleTyCon n)
\end{code}
\begin{code}
-lookupFixity :: RdrName -> RnMS s Fixity
-lookupFixity rdr_name
+lookupFixity :: Name -> RnMS s Fixity
+lookupFixity name
= getFixityEnv `thenRn` \ fixity_env ->
- returnRn (lookupFixityEnv fixity_env rdr_name)
+ case lookupNameEnv fixity_env name of
+ Just (FixitySig _ fixity _) -> returnRn fixity
+ Nothing -> returnRn (Fixity 9 InfixL) -- Default case
\end{code}
-mkImportFn returns a function that takes a Name and tells whether
+unQualInScope returns a function that takes a Name and tells whether
its unqualified name is in scope. This is put as a boolean flag in
the Name's provenance to guide whether or not to print the name qualified
in error messages.
\begin{code}
-mkImportFn :: RnEnv -> Name -> Bool
-mkImportFn (RnEnv env _)
+unQualInScope :: GlobalRdrEnv -> Name -> Bool
+unQualInScope env
= lookup
where
- lookup name = case lookupFM env (Unqual (nameOccName name)) of
- Just (name', _) -> name == name'
- Nothing -> False
+ lookup name = case lookupRdrEnv env (mkRdrUnqual (nameOccName name)) of
+ Just [name'] -> name == name'
+ other -> False
\end{code}
%************************************************************************
=============== RnEnv ================
\begin{code}
plusRnEnv (RnEnv n1 f1) (RnEnv n2 f2)
- = plusGlobalNameEnvRn n1 n2 `thenRn` \ n ->
- plusFixityEnvRn f1 f2 `thenRn` \ f ->
- returnRn (RnEnv n f)
+ = RnEnv (n1 `plusGlobalRdrEnv` n2)
+ (f1 `plusNameEnv` f2)
\end{code}
=============== NameEnv ================
\begin{code}
-plusGlobalNameEnvRn :: GlobalNameEnv -> GlobalNameEnv -> RnM s d GlobalNameEnv
-plusGlobalNameEnvRn env1 env2
- = mapRn addNameClashErrRn (conflictsFM conflicting_name env1 env2) `thenRn_`
- returnRn (env1 `plusFM` env2)
-
-addOneToGlobalNameEnv :: GlobalNameEnv -> RdrName -> (Name, HowInScope) -> RnM s d GlobalNameEnv
-addOneToGlobalNameEnv env rdr_name name
- = case lookupFM env rdr_name of
- Just name2 | conflicting_name name name2
- -> addNameClashErrRn (rdr_name, (name, name2)) `thenRn_`
- returnRn env
-
- other -> returnRn (addToFM env rdr_name name)
-
-delOneFromGlobalNameEnv :: GlobalNameEnv -> RdrName -> GlobalNameEnv
-delOneFromGlobalNameEnv env rdr_name = delFromFM env rdr_name
-
-conflicting_name :: (Name, HowInScope) -> (Name, HowInScope) -> Bool
-conflicting_name (n1, FromLocalDefn _) (n2, FromLocalDefn _) = True
-conflicting_name (n1,h1) (n2,h2) = n1 /= n2
- -- We complain of a conflict if one RdrName maps to two different Names,
- -- OR if one RdrName maps to the same *locally-defined* Name. The latter
- -- case is to catch two separate, local definitions of the same thing.
- --
- -- If a module imports itself then there might be a local defn and an imported
- -- defn of the same name; in this case the names will compare as equal, but
- -- will still have different HowInScope fields
-
-lookupNameEnv :: NameEnv -> RdrName -> Maybe Name
-lookupNameEnv = lookupFM
-\end{code}
-
-=============== FixityEnv ================
-\begin{code}
-plusFixityEnvRn f1 f2
- = mapRn (addErrRn.fixityClashErr) (conflictsFM bad_fix f1 f2) `thenRn_`
- returnRn (f1 `plusFM` f2)
+plusGlobalRdrEnv :: GlobalRdrEnv -> GlobalRdrEnv -> GlobalRdrEnv
+plusGlobalRdrEnv env1 env2 = plusFM_C combine_globals env1 env2
-addOneToFixityEnv env rdr_name fixity = addToFM env rdr_name fixity
+addOneToGlobalRdrEnv :: GlobalRdrEnv -> RdrName -> Name -> GlobalRdrEnv
+addOneToGlobalRdrEnv env rdr_name name = addToFM_C combine_globals env rdr_name [name]
-lookupFixityEnv env rdr_name
- = case lookupFM env rdr_name of
- Just (fixity,_) -> fixity
- Nothing -> Fixity 9 InfixL -- Default case
+delOneFromGlobalRdrEnv :: GlobalRdrEnv -> RdrName -> GlobalRdrEnv
+delOneFromGlobalRdrEnv env rdr_name = delFromFM env rdr_name
-bad_fix :: (Fixity, HowInScope) -> (Fixity, HowInScope) -> Bool
-bad_fix (f1,_) (f2,_) = f1 /= f2
-
-pprFixityProvenance :: (Fixity, HowInScope) -> SDoc
-pprFixityProvenance (fixity, how_in_scope) = ppr how_in_scope
+combine_globals :: [Name] -- Old
+ -> [Name] -- New
+ -> [Name]
+combine_globals ns_old ns_new -- ns_new is often short
+ = foldr add ns_old ns_new
+ where
+ add n ns | any (is_duplicate n) ns_old = map choose ns -- Eliminate duplicates
+ | otherwise = n:ns
+ where
+ choose n' | n==n' && better_provenance n n' = n
+ | otherwise = n'
+
+-- Choose
+-- a local thing over an imported thing
+-- a user-imported thing over a non-user-imported thing
+-- an explicitly-imported thing over an implicitly imported thing
+better_provenance n1 n2
+ = case (getNameProvenance n1, getNameProvenance n2) of
+ (LocalDef _ _, _ ) -> True
+ (NonLocalDef (UserImport _ _ True) _, _ ) -> True
+ (NonLocalDef (UserImport _ _ _ ) _, NonLocalDef ImplicitImport _) -> True
+ other -> False
+
+is_duplicate :: Name -> Name -> Bool
+is_duplicate n1 n2 | isLocallyDefined n1 && isLocallyDefined n2 = False
+ | otherwise = n1 == n2
+ -- We treat two bindings of a locally-defined name as a duplicate,
+ -- because they might be two separate, local defns and we want to report
+ -- and error for that, *not* eliminate a duplicate.
+
+ -- On the other hand, if you import the same name from two different
+ -- import statements, we *do* want to eliminate the duplicate, not report
+ -- an error.
+ --
+ -- If a module imports itself then there might be a local defn and an imported
+ -- defn of the same name; in this case the names will compare as equal, but
+ -- will still have different provenances
\end{code}
=============== ExportAvails ================
\begin{code}
-mkExportAvails :: Module -> Bool -> GlobalNameEnv -> [AvailInfo] -> ExportAvails
+mkEmptyExportAvails :: Module -> ExportAvails
+mkEmptyExportAvails mod_name = (unitFM mod_name [], emptyUFM)
+
+mkExportAvails :: Module -> Bool -> GlobalRdrEnv -> [AvailInfo] -> ExportAvails
mkExportAvails mod_name unqual_imp name_env avails
= (mod_avail_env, entity_avail_env)
where
-- we delete f from avails
unqual_avails | not unqual_imp = [] -- Short cut when no unqualified imports
- | otherwise = [prune avail | avail <- avails]
+ | otherwise = mapMaybe prune avails
- prune (Avail n) | unqual_in_scope n = Avail n
- prune (Avail n) | otherwise = NotAvailable
- prune (AvailTC n ns) = AvailTC n (filter unqual_in_scope ns)
+ prune (Avail n) | unqual_in_scope n = Just (Avail n)
+ prune (Avail n) | otherwise = Nothing
+ prune (AvailTC n ns) | null uqs = Nothing
+ | otherwise = Just (AvailTC n uqs)
+ where
+ uqs = filter unqual_in_scope ns
- unqual_in_scope n = Unqual (nameOccName n) `elemFM` name_env
+ unqual_in_scope n = unQualInScope name_env n
entity_avail_env = listToUFM [ (name,avail) | avail <- avails,
- name <- availEntityNames avail]
+ name <- availNames avail]
plusExportAvails :: ExportAvails -> ExportAvails -> ExportAvails
plusExportAvails (m1, e1) (m2, e2)
= (plusFM_C (++) m1 m2, plusUFM_C plusAvail e1 e2)
+ -- ToDo: wasteful: we do this once for each constructor!
\end{code}
\begin{code}
plusAvail (Avail n1) (Avail n2) = Avail n1
plusAvail (AvailTC n1 ns1) (AvailTC n2 ns2) = AvailTC n1 (nub (ns1 ++ ns2))
-plusAvail a NotAvailable = a
-plusAvail NotAvailable a = a
-- Added SOF 4/97
#ifdef DEBUG
plusAvail a1 a2 = pprPanic "RnEnv.plusAvail" (hsep [pprAvail a1,pprAvail a2])
availName (AvailTC n _) = n
availNames :: AvailInfo -> [Name]
-availNames NotAvailable = []
availNames (Avail n) = [n]
availNames (AvailTC n ns) = ns
--- availEntityNames is used to extract the names that can appear on their own in
--- an export or import list. For class decls, class methods can appear on their
--- own, thus import A( op )
--- but constructors cannot; thus
--- import B( T )
--- means import type T from B, not constructor T.
-
-availEntityNames :: AvailInfo -> [Name]
-availEntityNames NotAvailable = []
-availEntityNames (Avail n) = [n]
-availEntityNames (AvailTC n ns) = n : filter (isVarOcc . nameOccName) ns
-
filterAvail :: RdrNameIE -- Wanted
-> AvailInfo -- Available
- -> AvailInfo -- Resulting available;
- -- NotAvailable if wanted stuff isn't there
+ -> Maybe AvailInfo -- Resulting available;
+ -- Nothing if (any of the) wanted stuff isn't there
filterAvail ie@(IEThingWith want wants) avail@(AvailTC n ns)
- | sub_names_ok = AvailTC n (filter is_wanted ns)
- | otherwise =
-#ifdef DEBUG
- pprTrace "filterAvail" (hsep [ppr ie, pprAvail avail]) $
-#endif
- NotAvailable
+ | sub_names_ok = Just (AvailTC n (filter is_wanted ns))
+ | otherwise = Nothing
where
is_wanted name = nameOccName name `elem` wanted_occs
sub_names_ok = all (`elem` avail_occs) wanted_occs
wanted_occs = map rdrNameOcc (want:wants)
filterAvail (IEThingAbs _) (AvailTC n ns) = ASSERT( n `elem` ns )
- AvailTC n [n]
+ Just (AvailTC n [n])
-filterAvail (IEThingAbs _) avail@(Avail n) = avail -- Type synonyms
+filterAvail (IEThingAbs _) avail@(Avail n) = Just avail -- Type synonyms
-filterAvail (IEVar _) avail@(Avail n) = avail
-filterAvail (IEVar v) avail@(AvailTC n ns) = AvailTC n (filter wanted ns)
+filterAvail (IEVar _) avail@(Avail n) = Just avail
+filterAvail (IEVar v) avail@(AvailTC n ns) = Just (AvailTC n (filter wanted ns))
where
wanted n = nameOccName n == occ
occ = rdrNameOcc v
-- import A( op )
-- where op is a class operation
-filterAvail (IEThingAll _) avail@(AvailTC _ _) = avail
+filterAvail (IEThingAll _) avail@(AvailTC _ _) = Just avail
-filterAvail ie avail = NotAvailable
+filterAvail ie avail = Nothing
-- In interfaces, pprAvail gets given the OccName of the "host" thing
else
ppr_avail ppr avail
-ppr_avail pp_name NotAvailable = ptext SLIT("NotAvailable")
ppr_avail pp_name (AvailTC n ns) = hsep [
pp_name n,
parens $ hsep $ punctuate comma $
%************************************************************************
%* *
-\subsection{Finite map utilities}
+\subsection{Free variable manipulation}
%* *
%************************************************************************
+\begin{code}
+type FreeVars = NameSet
-Generally useful function on finite maps to check for overlap.
+plusFV :: FreeVars -> FreeVars -> FreeVars
+addOneFV :: FreeVars -> Name -> FreeVars
+unitFV :: Name -> FreeVars
+emptyFVs :: FreeVars
+plusFVs :: [FreeVars] -> FreeVars
-\begin{code}
-conflictsFM :: Ord a
- => (b->b->Bool) -- False <=> no conflict; you can pick either
- -> FiniteMap a b -> FiniteMap a b
- -> [(a,(b,b))]
-conflictsFM bad fm1 fm2
- = filter (\(a,(b1,b2)) -> bad b1 b2)
- (fmToList (intersectFM_C (\b1 b2 -> (b1,b2)) fm1 fm2))
-
-conflictFM :: Ord a
- => (b->b->Bool)
- -> FiniteMap a b -> a -> b
- -> Maybe (a,(b,b))
-conflictFM bad fm key elt
- = case lookupFM fm key of
- Just elt' | bad elt elt' -> Just (key,(elt,elt'))
- other -> Nothing
+emptyFVs = emptyNameSet
+plusFVs = unionManyNameSets
+plusFV = unionNameSets
+
+-- No point in adding implicitly imported names to the free-var set
+addOneFV s n = addOneToNameSet s n
+unitFV n = unitNameSet n
\end{code}
\begin{code}
-warnUnusedBinds, warnUnusedMatches, warnUnusedImports :: NameSet -> RnM s d ()
+warnUnusedLocalBinds, warnUnusedTopNames, warnUnusedMatches :: [Name] -> RnM s d ()
+
+warnUnusedTopNames names
+ | not opt_WarnUnusedBinds && not opt_WarnUnusedImports = returnRn () -- Don't force ns unless necessary
+ | otherwise = warnUnusedBinds (\ is_local -> not is_local) names
-warnUnusedBinds names
- | opt_WarnUnusedBinds = warnUnusedNames names
- | otherwise = returnRn ()
+warnUnusedLocalBinds ns
+ | not opt_WarnUnusedBinds = returnRn ()
+ | otherwise = warnUnusedBinds (\ is_local -> is_local) ns
warnUnusedMatches names
- | opt_WarnUnusedMatches = warnUnusedNames names
- | otherwise = returnRn ()
+ | opt_WarnUnusedMatches = warnUnusedGroup (const True) names
+ | otherwise = returnRn ()
-warnUnusedImports names
- | opt_WarnUnusedImports = warnUnusedNames names
- | otherwise = returnRn ()
+-------------------------
-warnUnusedNames :: NameSet -> RnM s d ()
-warnUnusedNames names
- = mapRn warn (nameSetToList names) `thenRn_`
+warnUnusedBinds :: (Bool -> Bool) -> [Name] -> RnM s d ()
+warnUnusedBinds warn_when_local names
+ = mapRn (warnUnusedGroup warn_when_local) groups `thenRn_`
returnRn ()
where
- warn name = pushSrcLocRn (getSrcLoc name) $
- addWarnRn (unusedNameWarn name)
-
-unusedNameWarn name = quotes (ppr name) <+> ptext SLIT("is bound but not used")
-
-addNameClashErrRn (rdr_name, ((_,how_in_scope1), (_, how_in_scope2)))
- | isClassDataConRdrName rdr_name
- -- Nasty hack to prevent error messages complain about conflicts for ":C",
- -- where "C" is a class. There'll be a message about C, and :C isn't
- -- the programmer's business. There may be a better way to filter this
- -- out, but I couldn't get up the energy to find it.
+ -- Group by provenance
+ groups = equivClasses cmp names
+ name1 `cmp` name2 = getNameProvenance name1 `cmp_prov` getNameProvenance name2
+
+ cmp_prov (LocalDef _ _) (NonLocalDef _ _) = LT
+ cmp_prov (LocalDef loc1 _) (LocalDef loc2 _) = loc1 `compare` loc2
+ cmp_prov (NonLocalDef (UserImport m1 loc1 _) _)
+ (NonLocalDef (UserImport m2 loc2 _) _) = (m1 `compare` m2) `thenCmp` (loc1 `compare` loc2)
+ cmp_prov (NonLocalDef _ _) (LocalDef _ _) = GT
+ -- In-scope NonLocalDefs must have UserImport info on them
+
+-------------------------
+
+warnUnusedGroup :: (Bool -> Bool) -> [Name] -> RnM s d ()
+warnUnusedGroup _ []
= returnRn ()
+warnUnusedGroup emit_warning names
+ | not (emit_warning is_local) = returnRn ()
| otherwise
- = addErrRn (hang (hsep [ptext SLIT("Conflicting definitions for"), quotes (ppr rdr_name)])
- 4 (vcat [ppr how_in_scope1,
- ppr how_in_scope2]))
+ = pushSrcLocRn def_loc $
+ addWarnRn $
+ sep [msg <> colon, nest 4 (fsep (punctuate comma (map ppr names)))]
+ where
+ name1 = head names
+ (is_local, def_loc, msg)
+ = case getNameProvenance name1 of
+ LocalDef loc _ -> (True, loc, text "Defined but not used")
+ NonLocalDef (UserImport mod loc _) _ -> (True, loc, text "Imported from" <+> quotes (ppr mod) <+>
+ text "but but not used")
+ other -> (False, getSrcLoc name1, text "Strangely defined but not used")
+\end{code}
+
+\begin{code}
+addNameClashErrRn rdr_name (name1:names)
+ = addErrRn (vcat [ptext SLIT("Ambiguous occurrence") <+> quotes (ppr rdr_name),
+ ptext SLIT("It could refer to") <+> vcat (msg1 : msgs)])
+ where
+ msg1 = ptext SLIT("either") <+> mk_ref name1
+ msgs = [ptext SLIT(" or") <+> mk_ref name | name <- names]
+ mk_ref name = quotes (ppr name) <> comma <+> pprNameProvenance name
fixityClashErr (rdr_name, ((_,how_in_scope1), (_, how_in_scope2)))
= hang (hsep [ptext SLIT("Conflicting fixities for"), quotes (ppr rdr_name)])
dupNamesErr descriptor ((name,loc) : dup_things)
= pushSrcLocRn loc $
- addErrRn (hsep [ptext SLIT("Conflicting definitions for"),
- quotes (ppr name),
- ptext SLIT("in"), descriptor])
+ addErrRn ((ptext SLIT("Conflicting definitions for") <+> quotes (ppr name))
+ $$
+ (ptext SLIT("in") <+> descriptor))
\end{code}