%
-% (c) The GRASP/AQUA Project, Glasgow University, 1993-1995
+% (c) The GRASP/AQUA Project, Glasgow University, 1993-1998
%
\section[StgLint]{A ``lint'' pass to check for Stg correctness}
\begin{code}
-#include "HsVersions.h"
+module StgLint ( lintStgBindings ) where
-module StgLint (
- lintStgBindings,
-
- PprStyle, StgBinding, PlainStgBinding(..), Id
- ) where
+#include "HsVersions.h"
-IMPORT_Trace
+import StgSyn
-import AbsPrel ( typeOfPrimOp, mkFunTy, PrimOp(..), PrimKind
- IF_ATTACK_PRAGMAS(COMMA tagOf_PrimOp)
- IF_ATTACK_PRAGMAS(COMMA pprPrimOp)
- )
-import AbsUniType
-import Bag
-import BasicLit ( typeOfBasicLit, BasicLit )
-import Id ( getIdUniType, isNullaryDataCon, isDataCon,
- isBottomingId,
- getInstantiatedDataConSig, Id
- IF_ATTACK_PRAGMAS(COMMA bottomIsGuaranteed)
+import Bag ( Bag, emptyBag, isEmptyBag, snocBag, bagToList )
+import Id ( Id, idType, isLocalId )
+import VarSet
+import DataCon ( DataCon, dataConArgTys, dataConRepType )
+import PrimOp ( primOpType )
+import Literal ( literalType, Literal )
+import Maybes ( catMaybes )
+import Name ( getSrcLoc )
+import ErrUtils ( Message, addErrLocHdrLine )
+import Type ( mkFunTys, splitFunTys, splitTyConApp_maybe,
+ isUnLiftedType, isTyVarTy, dropForAlls, Type
)
-import Maybes
+import TyCon ( TyCon, isAlgTyCon, isNewTyCon, tyConDataCons )
+import Util ( zipEqual, equalLength )
import Outputable
-import Pretty
-import SrcLoc ( SrcLoc )
-import StgSyn
-import UniqSet
-import Util
infixr 9 `thenL`, `thenL_`, `thenMaybeL`, `thenMaybeL_`
\end{code}
-Checks for
+Checks for
(a) *some* type errors
(b) locally-defined variables used but not defined
+
+Note: unless -dverbose-stg is on, display of lint errors will result
+in "panic: bOGUS_LVs".
+
+WARNING:
+~~~~~~~~
+
+This module has suffered bit-rot; it is likely to yield lint errors
+for Stg code that is currently perfectly acceptable for code
+generation. Solution: don't use it! (KSW 2000-05).
+
+
%************************************************************************
%* *
\subsection{``lint'' for various constructs}
@lintStgBindings@ is the top-level interface function.
\begin{code}
-lintStgBindings :: PprStyle -> String -> [PlainStgBinding] -> [PlainStgBinding]
+lintStgBindings :: String -> [StgBinding] -> [StgBinding]
-lintStgBindings sty whodunnit binds
- = BSCC("StgLint")
+lintStgBindings whodunnit binds
+ = _scc_ "StgLint"
case (initL (lint_binds binds)) of
Nothing -> binds
- Just msg -> pprPanic "" (ppAboves [
- ppStr ("*** Stg Lint Errors: in "++whodunnit++" ***"),
- msg sty,
- ppStr "*** Offending Program ***",
- ppAboves (map (pprPlainStgBinding sty) binds),
- ppStr "*** End of Offense ***"])
- ESCC
+ Just msg -> pprPanic "" (vcat [
+ ptext SLIT("*** Stg Lint ErrMsgs: in") <+> text whodunnit <+> ptext SLIT("***"),
+ msg,
+ ptext SLIT("*** Offending Program ***"),
+ pprStgBindings binds,
+ ptext SLIT("*** End of Offense ***")])
where
- lint_binds :: [PlainStgBinding] -> LintM ()
+ lint_binds :: [StgBinding] -> LintM ()
lint_binds [] = returnL ()
- lint_binds (bind:binds)
+ lint_binds (bind:binds)
= lintStgBinds bind `thenL` \ binders ->
addInScopeVars binders (
lint_binds binds
\begin{code}
-lintStgAtom :: PlainStgAtom -> LintM (Maybe UniType)
+lintStgArg :: StgArg -> LintM (Maybe Type)
+lintStgArg (StgLitArg lit) = returnL (Just (literalType lit))
+lintStgArg (StgVarArg v) = lintStgVar v
-lintStgAtom (StgLitAtom lit) = returnL (Just (typeOfBasicLit lit))
-lintStgAtom a@(StgVarAtom v)
- = checkInScope v `thenL_`
- returnL (Just (getIdUniType v))
+lintStgVar v = checkInScope v `thenL_`
+ returnL (Just (idType v))
\end{code}
\begin{code}
-lintStgBinds :: PlainStgBinding -> LintM [Id] -- Returns the binders
+lintStgBinds :: StgBinding -> LintM [Id] -- Returns the binders
lintStgBinds (StgNonRec binder rhs)
= lint_binds_help (binder,rhs) `thenL_`
returnL [binder]
-lintStgBinds (StgRec pairs)
+lintStgBinds (StgRec pairs)
= addInScopeVars binders (
mapL lint_binds_help pairs `thenL_`
returnL binders
-- Check the rhs
lintStgRhs rhs `thenL` \ maybe_rhs_ty ->
+ -- Check binder doesn't have unlifted type
+ checkL (not (isUnLiftedType binder_ty))
+ (mkUnLiftedTyMsg binder rhs) `thenL_`
+
-- Check match to RHS type
(case maybe_rhs_ty of
Nothing -> returnL ()
- Just rhs_ty -> checkTys (getIdUniType binder)
- rhs_ty
+ Just rhs_ty -> checkTys binder_ty
+ rhs_ty
(mkRhsMsg binder rhs_ty)
- ) `thenL_`
+ ) `thenL_`
returnL ()
)
+ where
+ binder_ty = idType binder
\end{code}
\begin{code}
-lintStgRhs :: PlainStgRhs -> LintM (Maybe UniType)
+lintStgRhs :: StgRhs -> LintM (Maybe Type)
-lintStgRhs (StgRhsClosure _ _ _ _ binders expr)
+lintStgRhs (StgRhsClosure _ _ _ _ _ [] expr)
+ = lintStgExpr expr
+
+lintStgRhs (StgRhsClosure _ _ _ _ _ binders expr)
= addLoc (LambdaBodyOf binders) (
addInScopeVars binders (
lintStgExpr expr `thenMaybeL` \ body_ty ->
- returnL (Just (foldr (mkFunTy . getIdUniType) body_ty binders))
+ returnL (Just (mkFunTys (map idType binders) body_ty))
))
lintStgRhs (StgRhsCon _ con args)
- = mapMaybeL lintStgAtom args `thenL` \ maybe_arg_tys ->
+ = mapMaybeL lintStgArg args `thenL` \ maybe_arg_tys ->
case maybe_arg_tys of
Nothing -> returnL Nothing
Just arg_tys -> checkFunApp con_ty arg_tys (mkRhsConMsg con_ty arg_tys)
where
- con_ty = getIdUniType con
+ con_ty = dataConRepType con
\end{code}
\begin{code}
-lintStgExpr :: PlainStgExpr -> LintM (Maybe UniType) -- Nothing if error found
+lintStgExpr :: StgExpr -> LintM (Maybe Type) -- Nothing if error found
+
+lintStgExpr (StgLit l) = returnL (Just (literalType l))
-lintStgExpr e@(StgApp fun args _)
- = lintStgAtom fun `thenMaybeL` \ fun_ty ->
- mapMaybeL lintStgAtom args `thenL` \ maybe_arg_tys ->
+lintStgExpr e@(StgApp fun args)
+ = lintStgVar fun `thenMaybeL` \ fun_ty ->
+ mapMaybeL lintStgArg args `thenL` \ maybe_arg_tys ->
case maybe_arg_tys of
Nothing -> returnL Nothing
Just arg_tys -> checkFunApp fun_ty arg_tys (mkFunAppMsg fun_ty arg_tys e)
-lintStgExpr e@(StgConApp con args _)
- = mapMaybeL lintStgAtom args `thenL` \ maybe_arg_tys ->
+lintStgExpr e@(StgConApp con args)
+ = mapMaybeL lintStgArg args `thenL` \ maybe_arg_tys ->
case maybe_arg_tys of
Nothing -> returnL Nothing
Just arg_tys -> checkFunApp con_ty arg_tys (mkFunAppMsg con_ty arg_tys e)
where
- con_ty = getIdUniType con
+ con_ty = dataConRepType con
-lintStgExpr e@(StgPrimApp op args _)
- = mapMaybeL lintStgAtom args `thenL` \ maybe_arg_tys ->
+lintStgExpr e@(StgOpApp (StgFCallOp _ _) args res_ty)
+ = -- We don't have enough type information to check
+ -- the application; ToDo
+ mapMaybeL lintStgArg args `thenL` \ maybe_arg_tys ->
+ returnL (Just res_ty)
+
+lintStgExpr e@(StgOpApp (StgPrimOp op) args _)
+ = mapMaybeL lintStgArg args `thenL` \ maybe_arg_tys ->
case maybe_arg_tys of
- Nothing -> returnL Nothing
- Just arg_tys -> checkFunApp op_ty arg_tys (mkFunAppMsg op_ty arg_tys e)
+ Nothing -> returnL Nothing
+ Just arg_tys -> checkFunApp op_ty arg_tys (mkFunAppMsg op_ty arg_tys e)
where
- op_ty = typeOfPrimOp op
+ op_ty = primOpType op
-lintStgExpr (StgLet binds body)
+lintStgExpr (StgLam _ bndrs _)
+ = addErrL (ptext SLIT("Unexpected StgLam") <+> ppr bndrs) `thenL_`
+ returnL Nothing
+
+lintStgExpr (StgLet binds body)
= lintStgBinds binds `thenL` \ binders ->
addLoc (BodyOfLetRec binders) (
addInScopeVars binders (
lintStgExpr body
))
-lintStgExpr (StgLetNoEscape _ _ binds body)
+lintStgExpr (StgLetNoEscape _ _ binds body)
= lintStgBinds binds `thenL` \ binders ->
addLoc (BodyOfLetRec binders) (
addInScopeVars binders (
lintStgExpr body
))
-lintStgExpr (StgSCC _ _ expr) = lintStgExpr expr
+lintStgExpr (StgSCC _ expr) = lintStgExpr expr
-lintStgExpr e@(StgCase scrut _ _ _ alts)
+lintStgExpr e@(StgCase scrut _ _ bndr _ alts)
= lintStgExpr scrut `thenMaybeL` \ _ ->
- -- Check that it is a data type
- case getUniDataTyCon_maybe scrut_ty of
- Nothing -> addErrL (mkCaseDataConMsg e) `thenL_`
- returnL Nothing
- Just (tycon, _, _)
- -> lintStgAlts alts scrut_ty tycon
+ (case alts of
+ StgPrimAlts tc _ _ -> check_bndr tc
+ StgAlgAlts (Just tc) _ _ -> check_bndr tc
+ StgAlgAlts Nothing _ _ -> returnL ()
+ ) `thenL_`
+
+ (trace (showSDoc (ppr e)) $
+ -- we only allow case of tail-call or primop.
+ (case scrut of
+ StgApp _ _ -> returnL ()
+ StgConApp _ _ -> returnL ()
+ other -> addErrL (mkCaseOfCaseMsg e)) `thenL_`
+
+ addInScopeVars [bndr] (lintStgAlts alts scrut_ty)
+ )
where
- scrut_ty = get_ty alts
-
- get_ty (StgAlgAlts ty _ _) = ty
- get_ty (StgPrimAlts ty _ _) = ty
+ scrut_ty = idType bndr
+ bad_bndr = mkDefltMsg bndr
+ check_bndr tc = case splitTyConApp_maybe scrut_ty of
+ Just (bndr_tc, _) -> checkL (tc == bndr_tc) bad_bndr
+ Nothing -> addErrL bad_bndr
\end{code}
\begin{code}
-lintStgAlts :: PlainStgCaseAlternatives
- -> UniType -- Type of scrutinee
- -> TyCon -- TyCon pinned on the case
- -> LintM (Maybe UniType) -- Type of alternatives
+lintStgAlts :: StgCaseAlts
+ -> Type -- Type of scrutinee
+ -> LintM (Maybe Type) -- Type of alternatives
-lintStgAlts alts scrut_ty case_tycon
+lintStgAlts alts scrut_ty
= (case alts of
- StgAlgAlts _ alg_alts deflt ->
- chk_non_abstract_type case_tycon `thenL_`
+ StgAlgAlts _ alg_alts deflt ->
mapL (lintAlgAlt scrut_ty) alg_alts `thenL` \ maybe_alt_tys ->
lintDeflt deflt scrut_ty `thenL` \ maybe_deflt_ty ->
returnL (maybe_deflt_ty : maybe_alt_tys)
- StgPrimAlts _ prim_alts deflt ->
+ StgPrimAlts _ prim_alts deflt ->
mapL (lintPrimAlt scrut_ty) prim_alts `thenL` \ maybe_alt_tys ->
lintDeflt deflt scrut_ty `thenL` \ maybe_deflt_ty ->
returnL (maybe_deflt_ty : maybe_alt_tys)
returnL (Just first_ty)
where
check ty = checkTys first_ty ty (mkCaseAltMsg alts)
- where
- chk_non_abstract_type tycon
- = case (getTyConFamilySize tycon) of
- Nothing -> addErrL (mkCaseAbstractMsg tycon)
- Just _ -> returnL () -- that's cool
lintAlgAlt scrut_ty (con, args, _, rhs)
- = (case getUniDataTyCon_maybe scrut_ty of
- Nothing ->
- addErrL (mkAlgAltMsg1 scrut_ty)
- Just (tycon, tys_applied, cons) ->
+ = (case splitTyConApp_maybe scrut_ty of
+ Just (tycon, tys_applied) | isAlgTyCon tycon &&
+ not (isNewTyCon tycon) ->
let
- (_, arg_tys, _) = getInstantiatedDataConSig con tys_applied
+ cons = tyConDataCons tycon
+ arg_tys = dataConArgTys con tys_applied
+ -- This almost certainly does not work for existential constructors
in
checkL (con `elem` cons) (mkAlgAltMsg2 scrut_ty con) `thenL_`
- checkL (length arg_tys == length args) (mkAlgAltMsg3 con args)
+ checkL (equalLength arg_tys args) (mkAlgAltMsg3 con args)
`thenL_`
- mapL check (arg_tys `zipEqual` args) `thenL_`
+ mapL check (zipEqual "lintAlgAlt:stg" arg_tys args) `thenL_`
returnL ()
+ other ->
+ addErrL (mkAlgAltMsg1 scrut_ty)
) `thenL_`
addInScopeVars args (
lintStgExpr rhs
)
where
- check (ty, arg) = checkTys ty (getIdUniType arg) (mkAlgAltMsg4 ty arg)
+ check (ty, arg) = checkTys ty (idType arg) (mkAlgAltMsg4 ty arg)
-- elem: yes, the elem-list here can sometimes be long-ish,
-- but as it's use-once, probably not worth doing anything different
elem x (y:ys) = x==y || elem x ys
lintPrimAlt scrut_ty alt@(lit,rhs)
- = checkTys (typeOfBasicLit lit) scrut_ty (mkPrimAltMsg alt) `thenL_`
+ = checkTys (literalType lit) scrut_ty (mkPrimAltMsg alt) `thenL_`
lintStgExpr rhs
-
+
lintDeflt StgNoDefault scrut_ty = returnL Nothing
-lintDeflt deflt@(StgBindDefault binder _ rhs) scrut_ty
- = checkTys (getIdUniType binder) scrut_ty (mkDefltMsg deflt) `thenL_`
- addInScopeVars [binder] (
- lintStgExpr rhs
- )
+lintDeflt deflt@(StgBindDefault rhs) scrut_ty = lintStgExpr rhs
\end{code}
\begin{code}
type LintM a = [LintLocInfo] -- Locations
- -> UniqSet Id -- Local vars in scope
- -> Bag ErrMsg -- Error messages so far
- -> (a, Bag ErrMsg) -- Result and error messages (if any)
-
-type ErrMsg = PprStyle -> Pretty
+ -> IdSet -- Local vars in scope
+ -> Bag Message -- Error messages so far
+ -> (a, Bag Message) -- Result and error messages (if any)
data LintLocInfo
= RhsOf Id -- The variable bound
| LambdaBodyOf [Id] -- The lambda-binder
| BodyOfLetRec [Id] -- One of the binders
-instance Outputable LintLocInfo where
- ppr sty (RhsOf v)
- = ppBesides [ppr sty (getSrcLoc v), ppStr ": [RHS of ", pp_binders sty [v], ppStr "]"]
+dumpLoc (RhsOf v) =
+ (getSrcLoc v, ptext SLIT(" [RHS of ") <> pp_binders [v] <> char ']' )
+dumpLoc (LambdaBodyOf bs) =
+ (getSrcLoc (head bs), ptext SLIT(" [in body of lambda with binders ") <> pp_binders bs <> char ']' )
- ppr sty (LambdaBodyOf bs)
- = ppBesides [ppr sty (getSrcLoc (head bs)),
- ppStr ": [in body of lambda with binders ", pp_binders sty bs, ppStr "]"]
+dumpLoc (BodyOfLetRec bs) =
+ (getSrcLoc (head bs), ptext SLIT(" [in body of letrec with binders ") <> pp_binders bs <> char ']' )
- ppr sty (BodyOfLetRec bs)
- = ppBesides [ppr sty (getSrcLoc (head bs)),
- ppStr ": [in body of letrec with binders ", pp_binders sty bs, ppStr "]"]
-pp_binders :: PprStyle -> [Id] -> Pretty
-pp_binders sty bs
- = ppInterleave ppComma (map pp_binder bs)
+pp_binders :: [Id] -> SDoc
+pp_binders bs
+ = sep (punctuate comma (map pp_binder bs))
where
pp_binder b
- = ppCat [ppr sty b, ppStr "::", ppr sty (getIdUniType b)]
+ = hsep [ppr b, dcolon, ppr (idType b)]
\end{code}
\begin{code}
-initL :: LintM a -> Maybe ErrMsg
+initL :: LintM a -> Maybe Message
initL m
- = case (m [] emptyUniqSet emptyBag) of { (_, errs) ->
+ = case (m [] emptyVarSet emptyBag) of { (_, errs) ->
if isEmptyBag errs then
Nothing
else
- Just ( \ sty ->
- ppAboves [ msg sty | msg <- bagToList errs ]
- )
+ Just (vcat (punctuate (text "") (bagToList errs)))
}
returnL :: a -> LintM a
thenL :: LintM a -> (a -> LintM b) -> LintM b
thenL m k loc scope errs
- = case m loc scope errs of
+ = case m loc scope errs of
(r, errs') -> k r loc scope errs'
thenL_ :: LintM a -> LintM b -> LintM b
thenL_ m k loc scope errs
- = case m loc scope errs of
+ = case m loc scope errs of
(_, errs') -> k loc scope errs'
thenMaybeL :: LintM (Maybe a) -> (a -> LintM (Maybe b)) -> LintM (Maybe b)
\end{code}
\begin{code}
-checkL :: Bool -> ErrMsg -> LintM ()
+checkL :: Bool -> Message -> LintM ()
checkL True msg loc scope errs = ((), errs)
checkL False msg loc scope errs = ((), addErr errs msg loc)
-addErrL :: ErrMsg -> LintM ()
+addErrL :: Message -> LintM ()
addErrL msg loc scope errs = ((), addErr errs msg loc)
-addErr :: Bag ErrMsg -> ErrMsg -> [LintLocInfo] -> Bag ErrMsg
+addErr :: Bag Message -> Message -> [LintLocInfo] -> Bag Message
addErr errs_so_far msg locs
- = errs_so_far `snocBag` ( \ sty ->
- ppHang (ppr sty (head locs)) 4 (msg sty)
- )
+ = errs_so_far `snocBag` mk_msg locs
+ where
+ mk_msg (loc:_) = let (l,hdr) = dumpLoc loc
+ in addErrLocHdrLine l hdr msg
+ mk_msg [] = msg
addLoc :: LintLocInfo -> LintM a -> LintM a
addLoc extra_loc m loc scope errs
-- For now, it's just a "trace"; we may make
-- a real error out of it...
let
- new_set = mkUniqSet ids
-
- shadowed = scope `intersectUniqSets` new_set
+ new_set = mkVarSet ids
in
-- After adding -fliberate-case, Simon decided he likes shadowed
-- names after all. WDP 94/07
--- (if isEmptyUniqSet shadowed
+-- (if isEmptyVarSet shadowed
-- then id
--- else pprTrace "Shadowed vars:" (ppr PprDebug (uniqSetToList shadowed))) (
- m loc (scope `unionUniqSets` new_set) errs
--- )
+-- else pprTrace "Shadowed vars:" (ppr (varSetElems shadowed))) $
+ m loc (scope `unionVarSet` new_set) errs
\end{code}
+Checking function applications: we only check that the type has the
+right *number* of arrows, we don't actually compare the types. This
+is because we can't expect the types to be equal - the type
+applications and type lambdas that we use to calculate accurate types
+have long since disappeared.
+
\begin{code}
-checkFunApp :: UniType -- The function type
- -> [UniType] -- The arg type(s)
- -> ErrMsg -- Error messgae
- -> LintM (Maybe UniType) -- The result type
+checkFunApp :: Type -- The function type
+ -> [Type] -- The arg type(s)
+ -> Message -- Error messgae
+ -> LintM (Maybe Type) -- The result type
checkFunApp fun_ty arg_tys msg loc scope errs
= cfa res_ty expected_arg_tys arg_tys
where
- (_, expected_arg_tys, res_ty) = splitTypeWithDictsAsArgs fun_ty
+ (expected_arg_tys, res_ty) = splitFunTys (dropForAlls fun_ty)
cfa res_ty expected [] -- Args have run out; that's fine
- = (Just (glueTyArgs expected res_ty), errs)
+ = (Just (mkFunTys expected res_ty), errs)
cfa res_ty [] arg_tys -- Expected arg tys ran out first;
-- first see if res_ty is a tyvar template;
- -- otherwise, maybe res_ty is a
+ -- otherwise, maybe res_ty is a
-- dictionary type which is actually a function?
- | isTyVarTemplateTy res_ty
+ | isTyVarTy res_ty
= (Just res_ty, errs)
| otherwise
- = case splitTyArgs (unDictifyTy res_ty) of
+ = case splitFunTys res_ty of
([], _) -> (Nothing, addErr errs msg loc) -- Too many args
(new_expected, new_res) -> cfa new_res new_expected arg_tys
cfa res_ty (expected_arg_ty:expected_arg_tys) (arg_ty:arg_tys)
- = case (sleazy_cmp_ty expected_arg_ty arg_ty) of
- EQ_ -> cfa res_ty expected_arg_tys arg_tys
- _ -> (Nothing, addErr errs msg loc) -- Arg mis-match
+ = cfa res_ty expected_arg_tys arg_tys
\end{code}
\begin{code}
checkInScope :: Id -> LintM ()
checkInScope id loc scope errs
- = if isLocallyDefined id && not (isDataCon id) && not (id `elementOfUniqSet` scope) then
- ((), addErr errs (\ sty -> ppCat [ppr sty id, ppStr "is out of scope"]) loc)
+ = if isLocalId id && not (id `elemVarSet` scope) then
+ ((), addErr errs (hsep [ppr id, ptext SLIT("is out of scope")]) loc)
else
((), errs)
-checkTys :: UniType -> UniType -> ErrMsg -> LintM ()
+checkTys :: Type -> Type -> Message -> LintM ()
checkTys ty1 ty2 msg loc scope errs
- = case (sleazy_cmp_ty ty1 ty2) of
- EQ_ -> ((), errs)
- other -> ((), addErr errs msg loc)
+ = -- if (ty1 == ty2) then
+ ((), errs)
+ -- else ((), addErr errs msg loc)
\end{code}
\begin{code}
-mkCaseAltMsg :: PlainStgCaseAlternatives -> ErrMsg
-mkCaseAltMsg alts sty
- = ppAbove (ppStr "In some case alternatives, type of alternatives not all same:")
- -- LATER: (ppr sty alts)
- (panic "mkCaseAltMsg")
-
-mkCaseDataConMsg :: PlainStgExpr -> ErrMsg
-mkCaseDataConMsg expr sty
- = ppAbove (ppStr "A case scrutinee not a type-constructor type:")
- (pp_expr sty expr)
-
-mkCaseAbstractMsg :: TyCon -> ErrMsg
-mkCaseAbstractMsg tycon sty
- = ppAbove (ppStr "An algebraic case on an abstract type:")
- (ppr sty tycon)
-
-mkDefltMsg :: PlainStgCaseDefault -> ErrMsg
-mkDefltMsg deflt sty
- = ppAbove (ppStr "Binder in default case of a case expression doesn't match type of scrutinee:")
- --LATER: (ppr sty deflt)
+mkCaseAltMsg :: StgCaseAlts -> Message
+mkCaseAltMsg alts
+ = ($$) (text "In some case alternatives, type of alternatives not all same:")
+ (empty) -- LATER: ppr alts
+
+mkCaseAbstractMsg :: TyCon -> Message
+mkCaseAbstractMsg tycon
+ = ($$) (ptext SLIT("An algebraic case on an abstract type:"))
+ (ppr tycon)
+
+mkDefltMsg :: Id -> Message
+mkDefltMsg bndr
+ = ($$) (ptext SLIT("Binder of a case expression doesn't match type of scrutinee:"))
(panic "mkDefltMsg")
-mkFunAppMsg :: UniType -> [UniType] -> PlainStgExpr -> ErrMsg
-mkFunAppMsg fun_ty arg_tys expr sty
- = ppAboves [ppStr "In a function application, function type doesn't match arg types:",
- ppHang (ppStr "Function type:") 4 (ppr sty fun_ty),
- ppHang (ppStr "Arg types:") 4 (ppAboves (map (ppr sty) arg_tys)),
- ppHang (ppStr "Expression:") 4 (pp_expr sty expr)]
-
-mkRhsConMsg :: UniType -> [UniType] -> ErrMsg
-mkRhsConMsg fun_ty arg_tys sty
- = ppAboves [ppStr "In a RHS constructor application, con type doesn't match arg types:",
- ppHang (ppStr "Constructor type:") 4 (ppr sty fun_ty),
- ppHang (ppStr "Arg types:") 4 (ppAboves (map (ppr sty) arg_tys))]
-
-mkUnappTyMsg :: Id -> UniType -> ErrMsg
-mkUnappTyMsg var ty sty
- = ppAboves [ppStr "Variable has a for-all type, but isn't applied to any types.",
- ppBeside (ppStr "Var: ") (ppr sty var),
- ppBeside (ppStr "Its type: ") (ppr sty ty)]
-
-mkAlgAltMsg1 :: UniType -> ErrMsg
-mkAlgAltMsg1 ty sty
- = ppAbove (ppStr "In some case statement, type of scrutinee is not a data type:")
- (ppr sty ty)
-
-mkAlgAltMsg2 :: UniType -> Id -> ErrMsg
-mkAlgAltMsg2 ty con sty
- = ppAboves [
- ppStr "In some algebraic case alternative, constructor is not a constructor of scrutinee type:",
- ppr sty ty,
- ppr sty con
+mkFunAppMsg :: Type -> [Type] -> StgExpr -> Message
+mkFunAppMsg fun_ty arg_tys expr
+ = vcat [text "In a function application, function type doesn't match arg types:",
+ hang (ptext SLIT("Function type:")) 4 (ppr fun_ty),
+ hang (ptext SLIT("Arg types:")) 4 (vcat (map (ppr) arg_tys)),
+ hang (ptext SLIT("Expression:")) 4 (ppr expr)]
+
+mkRhsConMsg :: Type -> [Type] -> Message
+mkRhsConMsg fun_ty arg_tys
+ = vcat [text "In a RHS constructor application, con type doesn't match arg types:",
+ hang (ptext SLIT("Constructor type:")) 4 (ppr fun_ty),
+ hang (ptext SLIT("Arg types:")) 4 (vcat (map (ppr) arg_tys))]
+
+mkUnappTyMsg :: Id -> Type -> Message
+mkUnappTyMsg var ty
+ = vcat [text "Variable has a for-all type, but isn't applied to any types.",
+ (<>) (ptext SLIT("Var: ")) (ppr var),
+ (<>) (ptext SLIT("Its type: ")) (ppr ty)]
+
+mkAlgAltMsg1 :: Type -> Message
+mkAlgAltMsg1 ty
+ = ($$) (text "In some case statement, type of scrutinee is not a data type:")
+ (ppr ty)
+
+mkAlgAltMsg2 :: Type -> DataCon -> Message
+mkAlgAltMsg2 ty con
+ = vcat [
+ text "In some algebraic case alternative, constructor is not a constructor of scrutinee type:",
+ ppr ty,
+ ppr con
]
-mkAlgAltMsg3 :: Id -> [Id] -> ErrMsg
-mkAlgAltMsg3 con alts sty
- = ppAboves [
- ppStr "In some algebraic case alternative, number of arguments doesn't match constructor:",
- ppr sty con,
- ppr sty alts
+mkAlgAltMsg3 :: DataCon -> [Id] -> Message
+mkAlgAltMsg3 con alts
+ = vcat [
+ text "In some algebraic case alternative, number of arguments doesn't match constructor:",
+ ppr con,
+ ppr alts
]
-mkAlgAltMsg4 :: UniType -> Id -> ErrMsg
-mkAlgAltMsg4 ty arg sty
- = ppAboves [
- ppStr "In some algebraic case alternative, type of argument doesn't match data constructor:",
- ppr sty ty,
- ppr sty arg
+mkAlgAltMsg4 :: Type -> Id -> Message
+mkAlgAltMsg4 ty arg
+ = vcat [
+ text "In some algebraic case alternative, type of argument doesn't match data constructor:",
+ ppr ty,
+ ppr arg
]
-mkPrimAltMsg :: (BasicLit, PlainStgExpr) -> ErrMsg
-mkPrimAltMsg alt sty
- = ppAbove (ppStr "In a primitive case alternative, type of literal doesn't match type of scrutinee:")
- (ppr sty alt)
-
-mkRhsMsg :: Id -> UniType -> ErrMsg
-mkRhsMsg binder ty sty
- = ppAboves [ppCat [ppStr "The type of this binder doesn't match the type of its RHS:",
- ppr sty binder],
- ppCat [ppStr "Binder's type:", ppr sty (getIdUniType binder)],
- ppCat [ppStr "Rhs type:", ppr sty ty]
+mkPrimAltMsg :: (Literal, StgExpr) -> Message
+mkPrimAltMsg alt
+ = text "In a primitive case alternative, type of literal doesn't match type of scrutinee:"
+ $$ ppr alt
+
+mkCaseOfCaseMsg :: StgExpr -> Message
+mkCaseOfCaseMsg e
+ = text "Case of non-tail-call:" $$ ppr e
+
+mkRhsMsg :: Id -> Type -> Message
+mkRhsMsg binder ty
+ = vcat [hsep [ptext SLIT("The type of this binder doesn't match the type of its RHS:"),
+ ppr binder],
+ hsep [ptext SLIT("Binder's type:"), ppr (idType binder)],
+ hsep [ptext SLIT("Rhs type:"), ppr ty]
]
-pp_expr :: PprStyle -> PlainStgExpr -> Pretty
-pp_expr sty expr = ppr sty expr
-
-sleazy_cmp_ty ty1 ty2
- -- NB: probably severe overkill (WDP 95/04)
- = case (splitTypeWithDictsAsArgs ty1) of { (_,tyargs1,tyres1) ->
- case (splitTypeWithDictsAsArgs ty2) of { (_,tyargs2,tyres2) ->
- let
- ty11 = glueTyArgs tyargs1 tyres1
- ty22 = glueTyArgs tyargs2 tyres2
- in
- cmpUniType False{-!!!NOT PROPERLY!!!-} ty11 ty22
- }}
+mkUnLiftedTyMsg binder rhs
+ = (ptext SLIT("Let(rec) binder") <+> quotes (ppr binder) <+>
+ ptext SLIT("has unlifted type") <+> quotes (ppr (idType binder)))
+ $$
+ (ptext SLIT("RHS:") <+> ppr rhs)
\end{code}
projects / ghc-hetmet.git / blobdiff