/*
* (c) The GRASP/AQUA Project, Glasgow University, 1994-1998
*
- * $Id: openFile.c,v 1.14 1999/12/08 15:47:08 simonmar Exp $
+ * $Id: openFile.c,v 1.17 2000/05/11 13:15:38 simonmar Exp $
*
* openFile Runtime Support
*/
fo->buf = NULL;
fo->bufWPtr = 0;
fo->bufRPtr = 0;
- fo->bufStart = 0;
fo->flags = FILEOBJ_STD | ( rd ? FILEOBJ_READ : FILEOBJ_WRITE);
fo->connectedTo = NULL;
- /* MS Win32 CRT doesn't support fcntl() -- the workaround is to
- start using 'completion ports', but I'm punting on implementing
- support for using those.
- */
#if !defined(_WIN32) || defined(__CYGWIN__) || defined(__CYGWIN32__)
- /* set the non-blocking flag on this file descriptor */
- fd_flags = fcntl(fd, F_GETFL);
- fcntl(fd, F_SETFL, fd_flags | O_NONBLOCK);
+ /* Set the non-blocking flag on this file descriptor.
+ *
+ * Don't do it for stdout and stderr: some shells (actually most)
+ * don't reset the nonblocking flag after running a program, and
+ * this causes all sorts of problems. --SDM (12/99)
+ *
+ * MS Win32 CRT doesn't support fcntl() -- the workaround is to
+ * start using 'completion ports', but I'm punting on implementing
+ * support for using those.
+ */
+ if (fd != 1 && fd != 2) {
+ fd_flags = fcntl(fd, F_GETFL);
+ fcntl(fd, F_SETFL, fd_flags | O_NONBLOCK);
+ }
#endif
return fo;
switch (how) {
case OPENFILE_APPEND:
- oflags = O_NONBLOCK | O_WRONLY | O_NOCTTY | O_APPEND;
+ oflags = O_WRONLY | O_NOCTTY | O_APPEND;
for_writing = 1;
flags |= FILEOBJ_WRITE;
break;
case OPENFILE_WRITE:
- oflags = O_NONBLOCK | O_WRONLY | O_NOCTTY;
+ oflags = O_WRONLY | O_NOCTTY;
flags |= FILEOBJ_WRITE;
for_writing = 1;
break;
case OPENFILE_READ_ONLY:
- oflags = O_NONBLOCK | O_RDONLY | O_NOCTTY;
+ oflags = O_RDONLY | O_NOCTTY;
flags |= FILEOBJ_READ;
for_writing = 0;
break;
case OPENFILE_READ_WRITE:
- oflags = O_NONBLOCK | O_RDWR | O_NOCTTY;
+ oflags = O_RDWR | O_NOCTTY;
flags |= FILEOBJ_READ | FILEOBJ_WRITE;
for_writing = 1;
break;
}
}
- /* Make sure that we aren't looking at a directory */
+ /* Set non-blocking mode *after* the open. The reason is that
+ * when reading from a FIFO, if we open in non-blocking mode
+ * then any reads from the FIFO will return EOF straight away
+ * without waiting for a writing process. If we set O_NONBLOCK
+ * after doing the open, then we apparently get to wait for a
+ * writer. This broken behaviour has been observed on both Linux
+ * & Solaris. --SDM
+ */
+ fcntl(fd, F_SETFL, oflags | O_NONBLOCK);
+ /* Make sure that we aren't looking at a directory */
while (fstat(fd, &sb) < 0) {
/* highly unlikely */
if (errno != EINTR) {
fo->fd = fd;
fo->buf = NULL;
- fo->bufStart = 0;
fo->bufWPtr = 0;
fo->bufRPtr = 0;
fo->flags = flags;
return NULL;
fo->fd = fd;
fo->buf = NULL;
- fo->bufStart = 0;
fo->bufWPtr = 0;
fo->bufRPtr = 0;
fo->flags = flags | ( oflags & O_RDONLY ? FILEOBJ_READ