X-Git-Url: http://git.megacz.com/?a=blobdiff_plain;f=compiler%2Fcmm%2FCmmLint.hs;h=2fc4a74daf5391b5e00707c17a97c982b95643c8;hb=8a9eb3cd35117c62ac9758d118c6f4109b7330cb;hp=7c8f2b3ce45ed1c2decb6cd6f216c4ef7010c6f2;hpb=176fa33f17dd78355cc572e006d2ab26898e2c69;p=ghc-hetmet.git diff --git a/compiler/cmm/CmmLint.hs b/compiler/cmm/CmmLint.hs index 7c8f2b3..2fc4a74 100644 --- a/compiler/cmm/CmmLint.hs +++ b/compiler/cmm/CmmLint.hs @@ -19,14 +19,13 @@ module CmmLint ( import BlockId import Cmm import CLabel -import Maybe import Outputable import PprCmm -import Unique import Constants import FastString import Control.Monad +import Data.Maybe -- ----------------------------------------------------------------------------- -- Exported entry points: @@ -59,7 +58,7 @@ lintCmmTop (CmmData {}) lintCmmBlock :: BlockSet -> GenBasicBlock CmmStmt -> CmmLint () lintCmmBlock labels (BasicBlock id stmts) - = addLintInfo (text "in basic block " <> ppr (getUnique id)) $ + = addLintInfo (text "in basic block " <> ppr id) $ mapM_ (lintCmmStmt labels) stmts -- ----------------------------------------------------------------------------- @@ -70,7 +69,7 @@ lintCmmBlock labels (BasicBlock id stmts) lintCmmExpr :: CmmExpr -> CmmLint CmmType lintCmmExpr (CmmLoad expr rep) = do - lintCmmExpr expr + _ <- lintCmmExpr expr when (widthInBytes (typeWidth rep) >= wORD_SIZE) $ cmmCheckWordAddress expr return rep @@ -88,20 +87,11 @@ lintCmmExpr expr = -- Check for some common byte/word mismatches (eg. Sp + 1) cmmCheckMachOp :: MachOp -> [CmmExpr] -> [CmmType] -> CmmLint CmmType -cmmCheckMachOp op args@[CmmReg reg, CmmLit (CmmInt i _)] _ - | isWordOffsetReg reg && isOffsetOp op && i `rem` fromIntegral wORD_SIZE /= 0 - = cmmLintDubiousWordOffset (CmmMachOp op args) cmmCheckMachOp op [lit@(CmmLit (CmmInt { })), reg@(CmmReg _)] tys = cmmCheckMachOp op [reg, lit] tys cmmCheckMachOp op _ tys = return (machOpResultType op tys) -isWordOffsetReg :: CmmReg -> Bool -isWordOffsetReg (CmmGlobal Sp) = True --- No warnings for unaligned arithmetic, which is used to tag dynamic constructor closures. ---isWordOffsetReg (CmmGlobal Hp) = True -isWordOffsetReg _ = False - isOffsetOp :: MachOp -> Bool isOffsetOp (MO_Add _) = True isOffsetOp (MO_Sub _) = True @@ -136,8 +126,8 @@ lintCmmStmt labels = lint then return () else cmmLintAssignErr stmt erep reg_ty lint (CmmStore l r) = do - lintCmmExpr l - lintCmmExpr r + _ <- lintCmmExpr l + _ <- lintCmmExpr r return () lint (CmmCall target _res args _ _) = lintTarget target >> mapM_ (lintCmmExpr . hintlessCmm) args