X-Git-Url: http://git.megacz.com/?a=blobdiff_plain;f=compiler%2FcodeGen%2FStgCmmExpr.hs;h=94afb80f5b16554188cd92f5ac306dfe60ea88f4;hb=8350c21760d8610b0b2f329095ffb80bb1bc20d9;hp=28c74427b00379cd20647b1fcb62d8a290ea25c3;hpb=bfb346895846c5b79ecfb1e7503815146b8a4071;p=ghc-hetmet.git diff --git a/compiler/codeGen/StgCmmExpr.hs b/compiler/codeGen/StgCmmExpr.hs index 28c7442..94afb80 100644 --- a/compiler/codeGen/StgCmmExpr.hs +++ b/compiler/codeGen/StgCmmExpr.hs @@ -29,7 +29,6 @@ import StgSyn import MkZipCfgCmm import BlockId -import Cmm() import CmmExpr import CoreSyn import DataCon @@ -40,6 +39,7 @@ import SMRep import TyCon import Type import CostCentre ( CostCentreStack, currentCCS ) +import Control.Monad (when) import Maybes import Util import FastString @@ -301,28 +301,26 @@ cgCase (OpApp ) bndr srt AlgAlt [(DataAlt flase, a2] -- code that enters the HValue, then we'll get a runtime panic, because -- the HValue really is a MutVar#. The types are compatible though, -- so we can just generate an assignment. -cgCase scrut@(StgApp v []) bndr _ alt_type@(PrimAlt _) alts +cgCase (StgApp v []) bndr _ alt_type@(PrimAlt _) alts | isUnLiftedType (idType v) || reps_compatible - = -- assignment instruction suffices for unlifted types - do { v_info <- getCgIdInfo v - ; emit $ mkComment $ mkFastString "New case:" + = -- assignment suffices for unlifted types + do { when (not reps_compatible) $ + panic "cgCase: reps do not match, perhaps a dodgy unsafeCoerce?" + ; v_info <- getCgIdInfo v ; emit (mkAssign (CmmLocal (idToReg (NonVoid bndr))) (idInfoToAmode v_info)) ; _ <- bindArgsToRegs [NonVoid bndr] ; cgAlts NoGcInAlts (NonVoid bndr) alt_type alts } where reps_compatible = idCgRep v == idCgRep bndr -cgCase scrut@(StgApp v []) bndr _ (PrimAlt _) _ - | lifted +cgCase scrut@(StgApp v []) _ _ (PrimAlt _) _ = -- fail at run-time, not compile-time do { mb_cc <- maybeSaveCostCentre True ; withSequel (AssignTo [idToReg (NonVoid v)] False) (cgExpr scrut) ; restoreCurrentCostCentre mb_cc ; emit $ mkComment $ mkFastString "should be unreachable code" ; emit $ withFreshLabel "l" (\l -> mkLabel l <*> mkBranch l)} - where - lifted = not (isUnLiftedType (idType v)) cgCase scrut bndr srt alt_type alts = -- the general case @@ -551,8 +549,8 @@ if the assignment to the binder will be dead code (use isDeadBndr). The following example illustrates how badly the code turns out: STG: case <=## [ww_s7Hx y_s7HD] of wild2_sbH8 { - GHC.Bool.False -> // sbH8 dead - GHC.Bool.True -> // sbH8 dead + GHC.Types.False -> // sbH8 dead + GHC.Types.True -> // sbH8 dead }; Cmm: _s7HD::F64 = F64[_sbH7::I64 + 7]; // MidAssign