X-Git-Url: http://git.megacz.com/?a=blobdiff_plain;f=compiler%2Fmain%2FGHC.hs;h=5626d249e0bb33af952f44984b38eac97f200ff9;hb=2377596a0f1992347edbaa7dcd8b431f93e196a7;hp=dbf3680b362ee003ae57a9e8d00cedc836a250c4;hpb=3897d02a5c0deb5c3bfda3299a28bbef525eba84;p=ghc-hetmet.git

diff --git a/compiler/main/GHC.hs b/compiler/main/GHC.hs
index dbf3680..5626d24 100644
--- a/compiler/main/GHC.hs
+++ b/compiler/main/GHC.hs
@@ -542,7 +542,7 @@ data LoadHowMuch
 -- attempt to load up to this target.  If no Module is supplied,
 -- then try to load all targets.
 load :: Session -> LoadHowMuch -> IO SuccessFlag
-load s@(Session ref) how_much
+load s how_much
    = do 
 	-- Dependency analysis first.  Note that this fixes the module graph:
 	-- even if we don't get a fully successful upsweep, the full module
@@ -550,15 +550,8 @@ load s@(Session ref) how_much
 	-- were successfully loaded by inspecting the Session's HPT.
 	mb_graph <- depanal s [] False
 	case mb_graph of
-	   Just mod_graph -> catchingFailure $ load2 s how_much mod_graph
+	   Just mod_graph -> load2 s how_much mod_graph
 	   Nothing        -> return Failed
-    where catchingFailure f = f `Exception.catch` \e -> do
-              hsc_env <- readIORef ref
-              -- trac #1565 / test ghci021:
-              -- let bindings may explode if we try to use them after
-              -- failing to reload
-              writeIORef ref $! hsc_env{ hsc_IC = emptyInteractiveContext }
-              throw e
 
 load2 :: Session -> LoadHowMuch -> [ModSummary] -> IO SuccessFlag
 load2 s@(Session ref) how_much mod_graph = do
@@ -578,6 +571,21 @@ load2 s@(Session ref) how_much mod_graph = do
 					not (ms_mod_name s `elem` all_home_mods)]
 	ASSERT( null bad_boot_mods ) return ()
 
+        -- check that the module given in HowMuch actually exists, otherwise
+        -- topSortModuleGraph will bomb later.
+        let checkHowMuch (LoadUpTo m)           = checkMod m
+            checkHowMuch (LoadDependenciesOf m) = checkMod m
+            checkHowMuch _ = id
+
+            checkMod m and_then
+                | m `elem` all_home_mods = and_then
+                | otherwise = do 
+                        errorMsg dflags (text "no such module:" <+> 
+                                         quotes (ppr m))
+                        return Failed
+
+        checkHowMuch how_much $ do
+
         -- mg2_with_srcimps drops the hi-boot nodes, returning a 
 	-- graph with cycles.  Among other things, it is used for
         -- backing out partially complete cycles following a failed
@@ -603,6 +611,12 @@ load2 s@(Session ref) how_much mod_graph = do
 
 	evaluate pruned_hpt
 
+        -- before we unload anything, make sure we don't leave an old
+        -- interactive context around pointing to dead bindings.  Also,
+        -- write the pruned HPT to allow the old HPT to be GC'd.
+        writeIORef ref $! hsc_env{ hsc_IC = emptyInteractiveContext,
+                                   hsc_HPT = pruned_hpt }
+
 	debugTraceMsg dflags 2 (text "Stable obj:" <+> ppr stable_obj $$
 				text "Stable BCO:" <+> ppr stable_bco)
 
@@ -2221,7 +2235,7 @@ findModule s mod_name maybe_pkg = withSession s $ \hsc_env ->
 	  case res of
 	    Found _ m | modulePackageId m /= this_pkg -> return m
 		      | otherwise -> throwDyn (CmdLineError (showSDoc $
-					text "module" <+> pprModule m <+>
+					text "module" <+> quotes (ppr (moduleName m)) <+>
 					text "is not loaded"))
 	    err -> let msg = cannotFindModule dflags mod_name err in
 		   throwDyn (CmdLineError (showSDoc msg))