X-Git-Url: http://git.megacz.com/?a=blobdiff_plain;f=compiler%2Ftypecheck%2FFamInst.lhs;h=b09f9a516da17b92c729e76708f9a9230f0286f1;hb=1a9245caefb80a3c4c5965aaacdf9a607e792e1c;hp=67c526d657bf1567c291709eff28000d67041e06;hpb=a769050d7c133dac1fbe9c50c2e212243bdbf980;p=ghc-hetmet.git diff --git a/compiler/typecheck/FamInst.lhs b/compiler/typecheck/FamInst.lhs index 67c526d..b09f9a5 100644 --- a/compiler/typecheck/FamInst.lhs +++ b/compiler/typecheck/FamInst.lhs @@ -11,17 +11,16 @@ import TcMType import TcType import TcRnMonad import TyCon -import Type import Name import Module import SrcLoc import Outputable -import LazyUniqFM +import UniqFM import FiniteMap import FastString -import Maybe -import Monad +import Maybes +import Control.Monad \end{code} @@ -117,8 +116,8 @@ checkFamInstConsistency famInstMods directlyImpMods -- already loaded in the EPS or they are in the HPT. -- check modInstsEnv (ModulePair m1 m2) - = let { instEnv1 = fromJust . lookupModuleEnv modInstsEnv $ m1 - ; instEnv2 = fromJust . lookupModuleEnv modInstsEnv $ m2 + = let { instEnv1 = (expectJust "checkFamInstConsistency") . lookupModuleEnv modInstsEnv $ m1 + ; instEnv2 = (expectJust "checkFamInstConsistency") . lookupModuleEnv modInstsEnv $ m2 ; insts1 = famInstEnvElts instEnv1 } in @@ -178,38 +177,14 @@ checkForConflicts inst_envs famInst -- (since we do unification). -- We use tcInstSkolType because we don't want to allocate -- fresh *meta* type variables. - ; let { tycon = famInstTyCon famInst - ; ty = case tyConFamInst_maybe tycon of - Nothing -> panic "FamInst.checkForConflicts" - Just (tc, tys) -> tc `mkTyConApp` tys - } - ; (_, _, tau') <- tcInstSkolType FamInstSkol ty - - ; let (fam, tys') = tcSplitTyConApp tau' - - ; let { matches = lookupFamInstEnvUnify inst_envs fam tys' - ; conflicts = [ conflictingFamInst - | match@((conflictingFamInst, _), _) <- matches - , conflicting tycon match - ] - } + + ; skol_tvs <- tcInstSkolTyVars FamInstSkol + (tyConTyVars (famInstTyCon famInst)) + ; let conflicts = lookupFamInstEnvConflicts inst_envs famInst skol_tvs ; unless (null conflicts) $ - conflictInstErr famInst (head conflicts) + conflictInstErr famInst (fst (head conflicts)) } where - -- - In the case of data family instances, any overlap is fundamentally a - -- conflict (as these instances imply injective type mappings). - -- - In the case of type family instances, overlap is admitted as long as - -- the right-hand sides of the overlapping rules coincide under the - -- overlap substitution. We require that they are syntactically equal; - -- anything else would be difficult to test for at this stage. - conflicting tycon1 ((famInst2, _), subst) - | isAlgTyCon tycon1 = True - | otherwise = not (rhs1 `tcEqType` rhs2) - where - tycon2 = famInstTyCon famInst2 - rhs1 = substTy subst $ synTyConType tycon1 - rhs2 = substTy subst $ synTyConType tycon2 conflictInstErr :: FamInst -> FamInst -> TcRn () conflictInstErr famInst conflictingFamInst