X-Git-Url: http://git.megacz.com/?a=blobdiff_plain;f=compiler%2Ftypecheck%2FTcSimplify.lhs;h=cbcabe91b1fb3ba2d4116404c71d7f24fa423d4c;hb=4e5faff9152918cd00dcdad9068b0f1eba1fcd68;hp=2a3691a50a9b1da4c5b79010f07f040bb544ed78;hpb=ecd655aaaa4ae495933415ad1ff6f6132ff3967f;p=ghc-hetmet.git

diff --git a/compiler/typecheck/TcSimplify.lhs b/compiler/typecheck/TcSimplify.lhs
index 2a3691a..cbcabe9 100644
--- a/compiler/typecheck/TcSimplify.lhs
+++ b/compiler/typecheck/TcSimplify.lhs
@@ -398,8 +398,8 @@ When m is later unified with [], we can solve both constraints.
 		Notes on implicit parameters
 	--------------------------------------
 
-Question 1: can we "inherit" implicit parameters
-~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+Note [Inheriting implicit parameters]
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 Consider this:
 
 	f x = (x::Int) + ?y
@@ -424,6 +424,21 @@ BOTTOM LINE: when *inferring types* you *must* quantify
 over implicit parameters. See the predicate isFreeWhenInferring.
 
 
+Note [Implicit parameters and ambiguity] 
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+What type should we infer for this?
+	f x = (show ?y, x::Int)
+Since we must quantify over the ?y, the most plausible type is
+	f :: (Show a, ?y::a) => Int -> (String, Int)
+But notice that the type of the RHS is (String,Int), with no type 
+varibables mentioned at all!  The type of f looks ambiguous.  But
+it isn't, because at a call site we might have
+	let ?y = 5::Int in f 7
+and all is well.  In effect, implicit parameters are, well, parameters,
+so we can take their type variables into account as part of the
+"tau-tvs" stuff.  This is done in the function 'FunDeps.grow'.
+
+
 Question 2: type signatures
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~
 BUT WATCH OUT: When you supply a type signature, we can't force you
@@ -719,9 +734,9 @@ The net effect of [NO TYVARS]
 \begin{code}
 isFreeWhenInferring :: TyVarSet -> Inst	-> Bool
 isFreeWhenInferring qtvs inst
-  =  isFreeWrtTyVars qtvs inst		-- Constrains no quantified vars
-  && isInheritableInst inst		-- And no implicit parameter involved
-					-- (see "Notes on implicit parameters")
+  =  isFreeWrtTyVars qtvs inst	-- Constrains no quantified vars
+  && isInheritableInst inst	-- and no implicit parameter involved
+				--   see Note [Inheriting implicit parameters]
 
 {-	No longer used (with implication constraints)
 isFreeWhenChecking :: TyVarSet	-- Quantified tyvars
@@ -1221,7 +1236,7 @@ tcSimplifyRestricted doc top_lvl bndrs tau_tvs wanteds
         returnM (varSetElems qtvs, binds)
     else
 	let
-    	    (non_ips, bad_ips) = partition isClassDict irreds
+    	    (bad_ips, non_ips) = partition isIPDict irreds
 	in    
 	addTopIPErrs bndrs bad_ips	`thenM_`
 	extendLIEs non_ips		`thenM_`
@@ -1977,9 +1992,6 @@ extractResults (Avails _ avails) wanteds
 	  Just (Rhs rhs ws') -> go (add_given avails w) new_binds irreds (ws' ++ ws)
 			     where
 				new_binds = addBind binds w rhs
-	where
-	  w_span = instSpan w
-	  w_id = instToId w
 
     add_given avails w = extendAvailEnv avails w (Given (instToId w))
 
@@ -2431,7 +2443,8 @@ addTopIPErrs bndrs ips
   where
     (tidy_env, tidy_ips) = tidyInsts ips
     mk_msg ips = vcat [sep [ptext SLIT("Implicit parameters escape from"),
-			    nest 2 (ptext SLIT("the monomorphic top-level binding(s) of")
+			    nest 2 (ptext SLIT("the monomorphic top-level binding") 
+					    <> plural bndrs <+> ptext SLIT("of")
 					    <+> pprBinders bndrs <> colon)],
 		       nest 2 (vcat (map ppr_ip ips)),
 		       monomorphism_fix]