X-Git-Url: http://git.megacz.com/?a=blobdiff_plain;f=ghc%2Fcompiler%2Frename%2FRename.lhs;h=1972ae238a8499647d5adfa8b62f8668227bbcb2;hb=46a825e77f5742d8881cf3f8fb59126257257338;hp=afc43b654750a62a7695be1234ee32e2cec32df7;hpb=459e7bd4622ea5bb8e90511b5fc6c7d8058dbd5f;p=ghc-hetmet.git diff --git a/ghc/compiler/rename/Rename.lhs b/ghc/compiler/rename/Rename.lhs index afc43b6..1972ae2 100644 --- a/ghc/compiler/rename/Rename.lhs +++ b/ghc/compiler/rename/Rename.lhs @@ -4,60 +4,55 @@ \section[Rename]{Renaming and dependency analysis passes} \begin{code} -module Rename ( renameModule, renameExpr, closeIfaceDecls, checkOldIface ) where +module Rename ( renameModule, renameStmt, closeIfaceDecls, checkOldIface ) where #include "HsVersions.h" import HsSyn -import RdrHsSyn ( RdrNameHsModule, RdrNameHsDecl, RdrNameDeprecation, RdrNameHsExpr, - RdrNameTyClDecl, RdrNameRuleDecl, RdrNameInstDecl, RdrNameImportDecl +import RdrHsSyn ( RdrNameHsModule, RdrNameHsDecl, RdrNameDeprecation, + RdrNameTyClDecl, RdrNameRuleDecl, RdrNameInstDecl, RdrNameImportDecl, + RdrNameStmt ) import RnHsSyn ( RenamedHsDecl, RenamedTyClDecl, RenamedRuleDecl, RenamedInstDecl, - extractHsTyNames, RenamedHsExpr, + extractHsTyNames, RenamedStmt, instDeclFVs, tyClDeclFVs, ruleDeclFVs ) import CmdLineOpts ( DynFlags, DynFlag(..) ) import RnMonad -import RnExpr ( rnExpr ) +import RnExpr ( rnStmt ) import RnNames ( getGlobalNames, exportsFromAvail ) import RnSource ( rnSourceDecls, rnTyClDecl, rnIfaceRuleDecl, rnInstDecl ) -import RnIfaces ( slurpImpDecls, mkImportInfo, - getInterfaceExports, closeDecls, +import RnIfaces ( slurpImpDecls, mkImportInfo, recordLocalSlurps, + closeDecls, RecompileRequired, outOfDate, recompileRequired ) import RnHiFiles ( readIface, removeContext, loadInterface, - loadExports, loadFixDecls, loadDeprecs ) -import RnEnv ( availsToNameSet, availName, - emptyAvailEnv, unitAvailEnv, availEnvElts, plusAvailEnv, groupAvails, - warnUnusedImports, warnUnusedLocalBinds, warnUnusedModules, - lookupOrigNames, lookupSrcName, newGlobalName, unQualInScope + loadExports, loadFixDecls, loadDeprecs, + ) +import MkIface ( pprUsage ) +import RnEnv ( availsToNameSet, mkIfaceGlobalRdrEnv, + emptyAvailEnv, unitAvailEnv, availEnvElts, + plusAvailEnv, groupAvails, warnUnusedImports, + warnUnusedLocalBinds, warnUnusedModules, + lookupSrcName, addImplicitFVs, + newGlobalName, unQualInScope,, ubiquitousNames ) import Module ( Module, ModuleName, WhereFrom(..), moduleNameUserString, moduleName, - moduleEnvElts, lookupModuleEnv - ) -import Name ( Name, NamedThing(..), getSrcLoc, - nameIsLocalOrFrom, nameOccName, nameModule, + moduleEnvElts ) +import Name ( Name, nameIsLocalOrFrom, nameModule ) import Name ( mkNameEnv, nameEnvElts, extendNameEnv ) -import RdrName ( elemRdrEnv, foldRdrEnv, isQual ) -import OccName ( occNameFlavour ) +import RdrName ( foldRdrEnv, isQual ) import NameSet -import TysWiredIn ( unitTyCon, intTyCon, boolTyCon ) -import PrelNames ( mAIN_Name, pREL_MAIN_Name, pRELUDE_Name, - ioTyCon_RDR, main_RDR_Unqual, - unpackCString_RDR, unpackCStringFoldr_RDR, unpackCStringUtf8_RDR, - eqString_RDR - ) -import PrelInfo ( derivingOccurrences ) -import Type ( funTyCon ) -import ErrUtils ( dumpIfSet, showPass, printErrorsAndWarnings, errorsFound ) +import PrelNames ( SyntaxMap, pRELUDE_Name ) +import ErrUtils ( dumpIfSet, dumpIfSet_dyn, showPass, + printErrorsAndWarnings, errorsFound ) import Bag ( bagToList ) import FiniteMap ( FiniteMap, fmToList, emptyFM, lookupFM, addToFM_C, elemFM, addToFM ) -import UniqFM ( lookupUFM ) import Maybes ( maybeToBool, catMaybes ) import Outputable import IO ( openFile, IOMode(..) ) @@ -65,11 +60,13 @@ import HscTypes ( PersistentCompilerState, HomeIfaceTable, HomeSymbolTable, ModIface(..), WhatsImported(..), VersionInfo(..), ImportVersion, IsExported, IfaceDecls, mkIfaceDecls, dcl_tycl, dcl_rules, dcl_insts, - GlobalRdrEnv, pprGlobalRdrEnv, + GlobalRdrEnv, GlobalRdrElt(..), pprGlobalRdrEnv, AvailEnv, GenAvailInfo(..), AvailInfo, Avails, Provenance(..), ImportReason(..), initialVersionInfo, - Deprecations(..), lookupDeprec, lookupIface + Deprecations(..), + LocalRdrEnv ) +import CmStaticInfo ( GhciMode(..) ) import List ( partition, nub ) \end{code} @@ -87,7 +84,8 @@ renameModule :: DynFlags -> HomeIfaceTable -> HomeSymbolTable -> PersistentCompilerState -> Module -> RdrNameHsModule - -> IO (PersistentCompilerState, Maybe (PrintUnqualified, (IsExported, ModIface, [RenamedHsDecl]))) + -> IO (PersistentCompilerState, PrintUnqualified, + Maybe (IsExported, ModIface, (SyntaxMap, [RenamedHsDecl]))) -- Nothing => some error occurred in the renamer renameModule dflags hit hst pcs this_module rdr_module @@ -97,31 +95,65 @@ renameModule dflags hit hst pcs this_module rdr_module \begin{code} -renameExpr :: DynFlags +renameStmt :: DynFlags -> HomeIfaceTable -> HomeSymbolTable -> PersistentCompilerState - -> Module -> RdrNameHsExpr - -> IO (PersistentCompilerState, Maybe (PrintUnqualified, RenamedHsExpr)) - -renameExpr dflags hit hst pcs this_module expr - | Just iface <- lookupModuleEnv hit this_module - = do { let rdr_env = mi_globals iface - ; let print_unqual = unQualInScope rdr_env - - ; renameSource dflags hit hst pcs this_module $ - initRnMS rdr_env emptyLocalFixityEnv SourceMode $ - ( rnExpr expr `thenRn` \ (e,_) -> - - doptRn Opt_D_dump_rn `thenRn` \ dump_rn -> - ioToRnM (dumpIfSet dump_rn "Renamer:" (ppr e)) `thenRn_` - - returnRn (Just (print_unqual, e))) - } - - | otherwise - = do { printErrs alwaysQualify (ptext SLIT("renameExpr: Bad module context") <+> ppr this_module) - ; return (pcs, Nothing) - } + -> Module -- current context (scope to compile in) + -> Module -- current module + -> LocalRdrEnv -- current context (temp bindings) + -> RdrNameStmt -- parsed stmt + -> IO ( PersistentCompilerState, + PrintUnqualified, + Maybe ([Name], (SyntaxMap, RenamedStmt, [RenamedHsDecl])) + ) + +renameStmt dflags hit hst pcs scope_module this_module local_env stmt + = renameSource dflags hit hst pcs this_module $ + + -- Load the interface for the context module, so + -- that we can get its top-level lexical environment + -- Bale out if we fail to do this + loadInterface doc (moduleName scope_module) ImportByUser `thenRn` \ iface -> + let rdr_env = mi_globals iface + print_unqual = unQualInScope rdr_env + in + checkErrsRn `thenRn` \ no_errs_so_far -> + if not no_errs_so_far then + returnRn (print_unqual, Nothing) + else + + -- Rename it + initRnMS rdr_env local_env emptyLocalFixityEnv CmdLineMode ( + rnStmt stmt $ \ stmt' -> + returnRn (([], stmt'), emptyFVs) + ) `thenRn` \ ((binders, stmt), fvs) -> + + -- Bale out if we fail + checkErrsRn `thenRn` \ no_errs_so_far -> + if not no_errs_so_far then + doDump [] stmt [] `thenRn_` returnRn (print_unqual, Nothing) + else + + let filtered_fvs = fvs `delListFromNameSet` rdrEnvElts local_env in + + -- Add implicit free vars, and close decls + addImplicitFVs rdr_env Nothing filtered_fvs + `thenRn` \ (slurp_fvs, syntax_map) -> + slurpImpDecls slurp_fvs `thenRn` \ decls -> + + doDump binders stmt decls `thenRn_` + returnRn (print_unqual, Just (binders, (syntax_map, stmt, decls))) + + where + doc = text "context for compiling expression" + + doDump :: [Name] -> RenamedStmt -> [RenamedHsDecl] -> RnMG (Either IOError ()) + doDump bndrs stmt decls + = getDOptsRn `thenRn` \ dflags -> + ioToRnM (dumpIfSet_dyn dflags Opt_D_dump_rn "Renamer:" + (vcat [text "Binders:" <+> ppr bndrs, + ppr stmt, text "", + vcat (map ppr decls)])) \end{code} @@ -136,45 +168,45 @@ renameSource :: DynFlags -> HomeIfaceTable -> HomeSymbolTable -> PersistentCompilerState -> Module - -> RnMG (Maybe (PrintUnqualified, r)) - -> IO (PersistentCompilerState, Maybe (PrintUnqualified, r)) + -> RnMG (PrintUnqualified, Maybe r) + -> IO (PersistentCompilerState, PrintUnqualified, Maybe r) -- Nothing => some error occurred in the renamer renameSource dflags hit hst old_pcs this_module thing_inside = do { showPass dflags "Renamer" -- Initialise the renamer monad - ; (new_pcs, msgs, maybe_rn_stuff) <- initRn dflags hit hst old_pcs this_module thing_inside + ; (new_pcs, msgs, (print_unqual, maybe_rn_stuff)) + <- initRn dflags hit hst old_pcs this_module thing_inside -- Print errors from renaming - ; let print_unqual = case maybe_rn_stuff of - Just (unqual, _) -> unqual - Nothing -> alwaysQualify - ; printErrorsAndWarnings print_unqual msgs ; -- Return results. No harm in updating the PCS ; if errorsFound msgs then - return (new_pcs, Nothing) + return (new_pcs, print_unqual, Nothing) else - return (new_pcs, maybe_rn_stuff) + return (new_pcs, print_unqual, maybe_rn_stuff) } \end{code} \begin{code} -rename :: Module -> RdrNameHsModule -> RnMG (Maybe (PrintUnqualified, (IsExported, ModIface, [RenamedHsDecl]))) +rename :: Module -> RdrNameHsModule + -> RnMG (PrintUnqualified, Maybe (IsExported, ModIface, (SyntaxMap, [RenamedHsDecl]))) rename this_module contents@(HsModule _ _ exports imports local_decls mod_deprec loc) = pushSrcLocRn loc $ -- FIND THE GLOBAL NAME ENVIRONMENT getGlobalNames this_module contents `thenRn` \ (gbl_env, local_gbl_env, all_avails@(_, global_avail_env)) -> - + let + print_unqualified = unQualInScope gbl_env + in -- Exit if we've found any errors checkErrsRn `thenRn` \ no_errs_so_far -> if not no_errs_so_far then -- Found errors already, so exit now rnDump [] [] `thenRn_` - returnRn Nothing + returnRn (print_unqualified, Nothing) else -- PROCESS EXPORT LIST @@ -193,30 +225,29 @@ rename this_module contents@(HsModule _ _ exports imports local_decls mod_deprec -- RENAME THE SOURCE rnSourceDecls gbl_env local_fixity_env local_decls `thenRn` \ (rn_local_decls, source_fvs) -> - -- CHECK THAT main IS DEFINED, IF REQUIRED - checkMain this_module local_gbl_env `thenRn_` + -- EXIT IF ERRORS FOUND + -- We exit here if there are any errors in the source, *before* + -- we attempt to slurp the decls from the interfaces, otherwise + -- the slurped decls may get lost when we return up the stack + -- to hscMain/hscExpr. + checkErrsRn `thenRn` \ no_errs_so_far -> + if not no_errs_so_far then + -- Found errors already, so exit now + rnDump [] rn_local_decls `thenRn_` + returnRn (print_unqualified, Nothing) + else -- SLURP IN ALL THE NEEDED DECLARATIONS - implicitFVs mod_name rn_local_decls `thenRn` \ implicit_fvs -> - let - slurp_fvs = implicit_fvs `plusFV` source_fvs - -- It's important to do the "plus" this way round, so that - -- when compiling the prelude, locally-defined (), Bool, etc - -- override the implicit ones. - in + addImplicitFVs gbl_env (Just (mod_name, rn_local_decls)) + source_fvs `thenRn` \ (slurp_fvs, sugar_map) -> traceRn (text "Source FVs:" <+> fsep (map ppr (nameSetToList slurp_fvs))) `thenRn_` slurpImpDecls slurp_fvs `thenRn` \ rn_imp_decls -> - -- EXIT IF ERRORS FOUND rnDump rn_imp_decls rn_local_decls `thenRn_` - checkErrsRn `thenRn` \ no_errs_so_far -> - if not no_errs_so_far then - -- Found errors already, so exit now - returnRn Nothing - else -- GENERATE THE VERSION/USAGE INFO mkImportInfo mod_name imports `thenRn` \ my_usages -> + traceHiDiffsRn (vcat (map pprUsage my_usages)) `thenRn_` -- BUILD THE MODULE INTERFACE let @@ -244,7 +275,6 @@ rename this_module contents@(HsModule _ _ exports imports local_decls mod_deprec mi_decls = panic "mi_decls" } - print_unqualified = unQualInScope gbl_env is_exported name = name `elemNameSet` exported_names exported_names = availsToNameSet export_avails in @@ -254,64 +284,11 @@ rename this_module contents@(HsModule _ _ exports imports local_decls mod_deprec imports global_avail_env source_fvs export_avails rn_imp_decls `thenRn_` - returnRn (Just (print_unqualified, (is_exported, mod_iface, final_decls))) + returnRn (print_unqualified, Just (is_exported, mod_iface, (sugar_map, final_decls))) where mod_name = moduleName this_module \end{code} -Checking that main is defined - -\begin{code} -checkMain :: Module -> GlobalRdrEnv -> RnMG () -checkMain this_mod local_env - | moduleName this_mod == mAIN_Name - = checkRn (main_RDR_Unqual `elemRdrEnv` local_env) noMainErr - | otherwise - = returnRn () -\end{code} - -@implicitFVs@ forces the renamer to slurp in some things which aren't -mentioned explicitly, but which might be needed by the type checker. - -\begin{code} -implicitFVs mod_name decls - = lookupOrigNames implicit_occs `thenRn` \ implicit_names -> - returnRn (mkNameSet (map getName default_tycons) `plusFV` - implicit_names) - where - -- Add occurrences for Int, and (), because they - -- are the types to which ambigious type variables may be defaulted by - -- the type checker; so they won't always appear explicitly. - -- [The () one is a GHC extension for defaulting CCall results.] - -- ALSO: funTyCon, since it occurs implicitly everywhere! - -- (we don't want to be bothered with making funTyCon a - -- free var at every function application!) - -- Double is dealt with separately in getGates - default_tycons = [unitTyCon, funTyCon, boolTyCon, intTyCon] - - -- Add occurrences for IO or PrimIO - implicit_main | mod_name == mAIN_Name - || mod_name == pREL_MAIN_Name = [ioTyCon_RDR] - | otherwise = [] - - -- Now add extra "occurrences" for things that - -- the deriving mechanism, or defaulting, will later need in order to - -- generate code - implicit_occs = string_occs ++ foldr ((++) . get) implicit_main decls - - -- Virtually every program has error messages in it somewhere - string_occs = [unpackCString_RDR, unpackCStringFoldr_RDR, - unpackCStringUtf8_RDR, eqString_RDR] - - get (TyClD (TyData _ _ _ _ _ _ (Just deriv_classes) _ _ _)) - = concat (map get_deriv deriv_classes) - get other = [] - - get_deriv cls = case lookupUFM derivingOccurrences cls of - Nothing -> [] - Just occs -> occs -\end{code} - \begin{code} isOrphanDecl this_mod (InstD (InstDecl inst_ty _ _ _ _)) = not (foldNameSet ((||) . nameIsLocalOrFrom this_mod) False @@ -332,7 +309,7 @@ isOrphanDecl this_mod (RuleD (HsRule _ _ _ lhs _ _)) check (HsLit _) = False check (HsOverLit _) = False check (OpApp l o _ r) = check l && check o && check r - check (NegApp e _) = check e + check (NegApp e) = check e check (HsPar e) = check e check (SectionL e o) = check e && check o check (SectionR o e) = check e && check o @@ -360,7 +337,7 @@ fixitiesFromLocalDecls gbl_env decls getFixities acc (FixD fix) = fix_decl acc fix - getFixities acc (TyClD (ClassDecl _ _ _ _ sigs _ _ _ )) + getFixities acc (TyClD (ClassDecl { tcdSigs = sigs})) = foldlRn fix_decl acc [sig | FixSig sig <- sigs] -- Get fixities from class decl sigs too. getFixities acc other_decl @@ -418,7 +395,8 @@ rnDeprecs gbl_env Nothing decls %************************************************************************ \begin{code} -checkOldIface :: DynFlags +checkOldIface :: GhciMode + -> DynFlags -> HomeIfaceTable -> HomeSymbolTable -> PersistentCompilerState -> FilePath @@ -427,8 +405,20 @@ checkOldIface :: DynFlags -> IO (PersistentCompilerState, Bool, (RecompileRequired, Maybe ModIface)) -- True <=> errors happened -checkOldIface dflags hit hst pcs iface_path source_unchanged maybe_iface - = runRn dflags hit hst pcs (panic "Bogus module") $ +checkOldIface ghci_mode dflags hit hst pcs iface_path source_unchanged maybe_iface + = runRn dflags hit hst pcs (panic "Bogus module") $ + + -- CHECK WHETHER THE SOURCE HAS CHANGED + ( if not source_unchanged then + traceHiDiffsRn (nest 4 (text "Source file changed or recompilation check turned off")) + else returnRn () ) `thenRn_` + + -- If the source has changed and we're in interactive mode, avoid reading + -- an interface; just return the one we might have been supplied with. + if ghci_mode == Interactive && not source_unchanged then + returnRn (outOfDate, maybe_iface) + else + case maybe_iface of Just old_iface -> -- Use the one we already have setModuleRn (mi_module old_iface) (check_versions old_iface) @@ -437,7 +427,7 @@ checkOldIface dflags hit hst pcs iface_path source_unchanged maybe_iface -> readIface iface_path `thenRn` \ read_result -> case read_result of Left err -> -- Old interface file not found, or garbled; give up - traceRn (text "Bad old interface file" $$ nest 4 err) `thenRn_` + traceRn (text "Bad old interface file" $$ nest 4 err) `thenRn_` returnRn (outOfDate, Nothing) Right parsed_iface @@ -447,9 +437,11 @@ checkOldIface dflags hit hst pcs iface_path source_unchanged maybe_iface where check_versions :: ModIface -> RnMG (RecompileRequired, Maybe ModIface) check_versions iface + | not source_unchanged + = returnRn (outOfDate, Just iface) + | otherwise = -- Check versions - recompileRequired iface_path source_unchanged iface - `thenRn` \ recompile -> + recompileRequired iface_path iface `thenRn` \ recompile -> returnRn (recompile, Just iface) \end{code} @@ -488,7 +480,7 @@ loadOldIface parsed_iface mi_boot = False, mi_orphan = pi_orphan iface, mi_fixities = fix_env, mi_deprecs = deprec_env, mi_decls = decls, - mi_globals = panic "No mi_globals in old interface" + mi_globals = mkIfaceGlobalRdrEnv avails } in returnRn mod_iface @@ -565,8 +557,20 @@ closeIfaceDecls dflags hit hst pcs needed = unionManyNameSets (map ruleDeclFVs rule_decls) `unionNameSets` unionManyNameSets (map instDeclFVs inst_decls) `unionNameSets` unionManyNameSets (map tyClDeclFVs tycl_decls) + local_names = foldl add emptyNameSet tycl_decls + add names decl = addListToNameSet names (map fst (tyClDeclSysNames decl ++ tyClDeclNames decl)) in - closeDecls decls needed + + recordLocalSlurps local_names `thenRn_` + + -- Do the transitive closure + closeDecls decls (needed `plusFV` implicit_fvs) `thenRn` \closed_decls -> + rnDump [] closed_decls `thenRn_` + returnRn closed_decls + where + implicit_fvs = ubiquitousNames -- Data type decls with record selectors, + -- which may appear in the decls, need unpackCString + -- and friends. It's easier to just grab them right now. \end{code} %********************************************************* @@ -588,14 +592,10 @@ reportUnusedNames my_mod_iface unqual imports avail_env = warnUnusedModules unused_imp_mods `thenRn_` warnUnusedLocalBinds bad_locals `thenRn_` warnUnusedImports bad_imp_names `thenRn_` - printMinimalImports this_mod unqual minimal_imports `thenRn_` - warnDeprecations this_mod export_avails my_deprecs - really_used_names - + printMinimalImports this_mod unqual minimal_imports where this_mod = mi_module my_mod_iface gbl_env = mi_globals my_mod_iface - my_deprecs = mi_deprecs my_mod_iface -- The export_fvs make the exported names look just as if they -- occurred in the source program. @@ -623,21 +623,21 @@ reportUnusedNames my_mod_iface unqual imports avail_env -- Collect the defined names from the in-scope environment -- Look for the qualified ones only, else get duplicates - defined_names :: [(Name,Provenance)] + defined_names :: [GlobalRdrElt] defined_names = foldRdrEnv add [] gbl_env add rdr_name ns acc | isQual rdr_name = ns ++ acc | otherwise = acc - defined_and_used, defined_but_not_used :: [(Name,Provenance)] + defined_and_used, defined_but_not_used :: [GlobalRdrElt] (defined_and_used, defined_but_not_used) = partition used defined_names - used (name,_) = name `elemNameSet` really_used_names + used (GRE name _ _) = name `elemNameSet` really_used_names -- Filter out the ones only defined implicitly bad_locals :: [Name] - bad_locals = [n | (n,LocalDef) <- defined_but_not_used] + bad_locals = [n | (GRE n LocalDef _) <- defined_but_not_used] bad_imp_names :: [(Name,Provenance)] - bad_imp_names = [(n,p) | (n,p@(NonLocalDef (UserImport mod _ True))) <- defined_but_not_used, + bad_imp_names = [(n,p) | GRE n p@(NonLocalDef (UserImport mod _ True)) _ <- defined_but_not_used, not (module_unused mod)] -- inst_mods are directly-imported modules that @@ -670,9 +670,12 @@ reportUnusedNames my_mod_iface unqual imports avail_env minimal_imports1 = foldr add_name minimal_imports0 defined_and_used minimal_imports = foldr add_inst_mod minimal_imports1 inst_mods - add_name (n,NonLocalDef (UserImport m _ _)) acc = addToFM_C plusAvailEnv acc (moduleName (nameModule n)) - (unitAvailEnv (mk_avail n)) - add_name (n,other_prov) acc = acc + -- We've carefully preserved the provenance so that we can + -- construct minimal imports that import the name by (one of) + -- the same route(s) as the programmer originally did. + add_name (GRE n (NonLocalDef (UserImport m _ _)) _) acc = addToFM_C plusAvailEnv acc (moduleName m) + (unitAvailEnv (mk_avail n)) + add_name (GRE n other_prov _) acc = acc mk_avail n = case lookupNameEnv avail_env n of Just (AvailTC m _) | n==m -> AvailTC n [n] @@ -698,42 +701,12 @@ reportUnusedNames my_mod_iface unqual imports avail_env module_unused :: Module -> Bool module_unused mod = moduleName mod `elem` unused_imp_mods -warnDeprecations this_mod export_avails my_deprecs used_names - = doptRn Opt_WarnDeprecations `thenRn` \ warn_drs -> - if not warn_drs then returnRn () else - - -- The home modules for things in the export list - -- may not have been loaded yet; do it now, so - -- that we can see their deprecations, if any - mapRn_ load_home export_mods `thenRn_` - - getIfacesRn `thenRn` \ ifaces -> - getHomeIfaceTableRn `thenRn` \ hit -> - let - pit = iPIT ifaces - deprecs = [ (n,txt) - | n <- nameSetToList used_names, - Just txt <- [lookup_deprec hit pit n] ] - in - mapRn_ warnDeprec deprecs - - where - export_mods = nub [ moduleName (nameModule name) - | avail <- export_avails, - let name = availName avail, - not (nameIsLocalOrFrom this_mod name) ] - - load_home m = loadInterface (text "Check deprecations for" <+> ppr m) m ImportBySystem - - lookup_deprec hit pit n - | nameIsLocalOrFrom this_mod n - = lookupDeprec my_deprecs n - | otherwise - = case lookupIface hit pit n of - Just iface -> lookupDeprec (mi_deprecs iface) n - Nothing -> pprPanic "warnDeprecations:" (ppr n) -- ToDo: deal with original imports with 'qualified' and 'as M' clauses +printMinimalImports :: Module -- This module + -> PrintUnqualified + -> FiniteMap ModuleName AvailEnv -- Minimal imports + -> RnMG () printMinimalImports this_mod unqual imps = doptRn Opt_D_dump_minimal_imports `thenRn` \ dump_minimal -> if not dump_minimal then returnRn () else @@ -756,12 +729,15 @@ printMinimalImports this_mod unqual imps returnRn (mod, ies) to_ie :: AvailInfo -> RnMG (IE Name) + -- The main trick here is that if we're importing all the constructors + -- we want to say "T(..)", but if we're importing only a subset we want + -- to say "T(A,B,C)". So we have to find out what the module exports. to_ie (Avail n) = returnRn (IEVar n) to_ie (AvailTC n [m]) = ASSERT( n==m ) returnRn (IEThingAbs n) to_ie (AvailTC n ns) - = getInterfaceExports n_mod ImportBySystem `thenRn` \ (_, avails_by_module) -> - case [xs | (m,as) <- avails_by_module, + = loadInterface (text "Compute minimal imports from" <+> ppr n_mod) n_mod ImportBySystem `thenRn` \ iface -> + case [xs | (m,as) <- mi_exports iface, m == n_mod, AvailTC x xs <- as, x == n] of @@ -841,14 +817,6 @@ getRnStats imported_decls ifaces %************************************************************************ \begin{code} -warnDeprec :: (Name, DeprecTxt) -> RnM d () -warnDeprec (name, txt) - = pushSrcLocRn (getSrcLoc name) $ - addWarnRn $ - sep [ text (occNameFlavour (nameOccName name)) <+> ppr name <+> - text "is deprecated:", nest 4 (ppr txt) ] - - dupFixityDecl rdr_name loc1 loc2 = vcat [ptext SLIT("Multiple fixity declarations for") <+> quotes (ppr rdr_name), ptext SLIT("at ") <+> ppr loc1, @@ -857,10 +825,6 @@ dupFixityDecl rdr_name loc1 loc2 badDeprec d = sep [ptext SLIT("Illegal deprecation when whole module is deprecated"), nest 4 (ppr d)] - -noMainErr - = hsep [ptext SLIT("Module"), quotes (ppr mAIN_Name), - ptext SLIT("must include a definition for"), quotes (ptext SLIT("main"))] \end{code}