X-Git-Url: http://git.megacz.com/?a=blobdiff_plain;f=ghc%2Fcompiler%2FstgSyn%2FStgLint.lhs;h=28b02a9a4c9efe858e941edd6b9bc62d3058cc2e;hb=f0192b817c0ed2e0558df2b5d129f9dd0a710f81;hp=c0300a5cf73d30b386faf9362078b41ad58de867;hpb=783e505e2d884f94d30ec8074e590507f2561c49;p=ghc-hetmet.git diff --git a/ghc/compiler/stgSyn/StgLint.lhs b/ghc/compiler/stgSyn/StgLint.lhs index c0300a5..28b02a9 100644 --- a/ghc/compiler/stgSyn/StgLint.lhs +++ b/ghc/compiler/stgSyn/StgLint.lhs @@ -10,20 +10,20 @@ module StgLint ( lintStgBindings ) where import StgSyn -import Bag ( Bag, emptyBag, isEmptyBag, snocBag, foldBag ) -import Id ( Id, idType ) +import Bag ( Bag, emptyBag, isEmptyBag, snocBag, bagToList ) +import Id ( Id, idType, isLocalId ) import VarSet import DataCon ( DataCon, dataConArgTys, dataConRepType ) import PrimOp ( primOpType ) import Literal ( literalType, Literal ) import Maybes ( catMaybes ) -import Name ( isLocallyDefined, getSrcLoc ) -import ErrUtils ( ErrMsg, Message, addErrLocHdrLine, pprBagOfErrors, dontAddErrLoc ) -import Type ( mkFunTys, splitFunTys, splitAlgTyConApp_maybe, - isUnLiftedType, isTyVarTy, splitForAllTys, Type +import Name ( getSrcLoc ) +import ErrUtils ( Message, addErrLocHdrLine ) +import Type ( mkFunTys, splitFunTys, splitTyConApp_maybe, + isUnLiftedType, isTyVarTy, dropForAlls, Type ) -import TyCon ( TyCon, isDataTyCon ) -import Util ( zipEqual ) +import TyCon ( TyCon, isAlgTyCon, isNewTyCon, tyConDataCons ) +import Util ( zipEqual, equalLength ) import Outputable infixr 9 `thenL`, `thenL_`, `thenMaybeL`, `thenMaybeL_` @@ -33,6 +33,18 @@ Checks for (a) *some* type errors (b) locally-defined variables used but not defined + +Note: unless -dverbose-stg is on, display of lint errors will result +in "panic: bOGUS_LVs". + +WARNING: +~~~~~~~~ + +This module has suffered bit-rot; it is likely to yield lint errors +for Stg code that is currently perfectly acceptable for code +generation. Solution: don't use it! (KSW 2000-05). + + %************************************************************************ %* * \subsection{``lint'' for various constructs} @@ -154,7 +166,13 @@ lintStgExpr e@(StgConApp con args) where con_ty = dataConRepType con -lintStgExpr e@(StgPrimApp op args _) +lintStgExpr e@(StgOpApp (StgFCallOp _ _) args res_ty) + = -- We don't have enough type information to check + -- the application; ToDo + mapMaybeL lintStgArg args `thenL` \ maybe_arg_tys -> + returnL (Just res_ty) + +lintStgExpr e@(StgOpApp (StgPrimOp op) args _) = mapMaybeL lintStgArg args `thenL` \ maybe_arg_tys -> case maybe_arg_tys of Nothing -> returnL Nothing @@ -184,8 +202,13 @@ lintStgExpr (StgSCC _ expr) = lintStgExpr expr lintStgExpr e@(StgCase scrut _ _ bndr _ alts) = lintStgExpr scrut `thenMaybeL` \ _ -> - checkTys (idType bndr) scrut_ty (mkDefltMsg bndr) `thenL_` + (case alts of + StgPrimAlts tc _ _ -> check_bndr tc + StgAlgAlts (Just tc) _ _ -> check_bndr tc + StgAlgAlts Nothing _ _ -> returnL () + ) `thenL_` + (trace (showSDoc (ppr e)) $ -- we only allow case of tail-call or primop. (case scrut of @@ -194,12 +217,13 @@ lintStgExpr e@(StgCase scrut _ _ bndr _ alts) other -> addErrL (mkCaseOfCaseMsg e)) `thenL_` addInScopeVars [bndr] (lintStgAlts alts scrut_ty) - ) + ) where - scrut_ty = get_ty alts - - get_ty (StgAlgAlts ty _ _) = ty - get_ty (StgPrimAlts ty _ _) = ty + scrut_ty = idType bndr + bad_bndr = mkDefltMsg bndr + check_bndr tc = case splitTyConApp_maybe scrut_ty of + Just (bndr_tc, _) -> checkL (tc == bndr_tc) bad_bndr + Nothing -> addErrL bad_bndr \end{code} \begin{code} @@ -229,19 +253,21 @@ lintStgAlts alts scrut_ty check ty = checkTys first_ty ty (mkCaseAltMsg alts) lintAlgAlt scrut_ty (con, args, _, rhs) - = (case splitAlgTyConApp_maybe scrut_ty of - Nothing -> - addErrL (mkAlgAltMsg1 scrut_ty) - Just (tycon, tys_applied, cons) -> + = (case splitTyConApp_maybe scrut_ty of + Just (tycon, tys_applied) | isAlgTyCon tycon && + not (isNewTyCon tycon) -> let + cons = tyConDataCons tycon arg_tys = dataConArgTys con tys_applied -- This almost certainly does not work for existential constructors in checkL (con `elem` cons) (mkAlgAltMsg2 scrut_ty con) `thenL_` - checkL (length arg_tys == length args) (mkAlgAltMsg3 con args) + checkL (equalLength arg_tys args) (mkAlgAltMsg3 con args) `thenL_` mapL check (zipEqual "lintAlgAlt:stg" arg_tys args) `thenL_` returnL () + other -> + addErrL (mkAlgAltMsg1 scrut_ty) ) `thenL_` addInScopeVars args ( lintStgExpr rhs @@ -273,8 +299,8 @@ lintDeflt deflt@(StgBindDefault rhs) scrut_ty = lintStgExpr rhs \begin{code} type LintM a = [LintLocInfo] -- Locations -> IdSet -- Local vars in scope - -> Bag ErrMsg -- Error messages so far - -> (a, Bag ErrMsg) -- Result and error messages (if any) + -> Bag Message -- Error messages so far + -> (a, Bag Message) -- Result and error messages (if any) data LintLocInfo = RhsOf Id -- The variable bound @@ -305,7 +331,7 @@ initL m if isEmptyBag errs then Nothing else - Just (pprBagOfErrors errs) + Just (vcat (punctuate (text "") (bagToList errs))) } returnL :: a -> LintM a @@ -357,13 +383,14 @@ checkL False msg loc scope errs = ((), addErr errs msg loc) addErrL :: Message -> LintM () addErrL msg loc scope errs = ((), addErr errs msg loc) -addErr :: Bag ErrMsg -> Message -> [LintLocInfo] -> Bag ErrMsg +addErr :: Bag Message -> Message -> [LintLocInfo] -> Bag Message addErr errs_so_far msg locs = errs_so_far `snocBag` mk_msg locs where - mk_msg (loc:_) = let (l,hdr) = dumpLoc loc in addErrLocHdrLine l hdr msg - mk_msg [] = dontAddErrLoc "" msg + mk_msg (loc:_) = let (l,hdr) = dumpLoc loc + in addErrLocHdrLine l hdr msg + mk_msg [] = msg addLoc :: LintLocInfo -> LintM a -> LintM a addLoc extra_loc m loc scope errs @@ -377,8 +404,6 @@ addInScopeVars ids m loc scope errs -- a real error out of it... let new_set = mkVarSet ids - - shadowed = scope `intersectVarSet` new_set in -- After adding -fliberate-case, Simon decided he likes shadowed -- names after all. WDP 94/07 @@ -403,8 +428,7 @@ checkFunApp :: Type -- The function type checkFunApp fun_ty arg_tys msg loc scope errs = cfa res_ty expected_arg_tys arg_tys where - (_, de_forall_ty) = splitForAllTys fun_ty - (expected_arg_tys, res_ty) = splitFunTys de_forall_ty + (expected_arg_tys, res_ty) = splitFunTys (dropForAlls fun_ty) cfa res_ty expected [] -- Args have run out; that's fine = (Just (mkFunTys expected res_ty), errs) @@ -427,7 +451,7 @@ checkFunApp fun_ty arg_tys msg loc scope errs \begin{code} checkInScope :: Id -> LintM () checkInScope id loc scope errs - = if isLocallyDefined id && not (id `elemVarSet` scope) then + = if isLocalId id && not (id `elemVarSet` scope) then ((), addErr errs (hsep [ppr id, ptext SLIT("is out of scope")]) loc) else ((), errs)