X-Git-Url: http://git.megacz.com/?a=blobdiff_plain;f=ghc%2Fcompiler%2FstgSyn%2FStgLint.lhs;h=326cd44578e7c25004b3a4cf35b1996677b196c6;hb=36436bc62a98f53e126ec02fe946337c4c766c3f;hp=8c7c7dbe7c9370109b43ccc5cc35195b165b1bfb;hpb=ca5a4a480d10d61e5b7a52eb4d556e8b8c33e69d;p=ghc-hetmet.git diff --git a/ghc/compiler/stgSyn/StgLint.lhs b/ghc/compiler/stgSyn/StgLint.lhs index 8c7c7db..326cd44 100644 --- a/ghc/compiler/stgSyn/StgLint.lhs +++ b/ghc/compiler/stgSyn/StgLint.lhs @@ -1,47 +1,52 @@ % -% (c) The GRASP/AQUA Project, Glasgow University, 1993-1996 +% (c) The GRASP/AQUA Project, Glasgow University, 1993-1998 % \section[StgLint]{A ``lint'' pass to check for Stg correctness} \begin{code} -#include "HsVersions.h" - module StgLint ( lintStgBindings ) where -import Ubiq{-uitous-} +#include "HsVersions.h" import StgSyn -import Bag ( emptyBag, isEmptyBag, snocBag, foldBag ) -import Id ( idType, isDataCon, dataConArgTys, - emptyIdSet, isEmptyIdSet, elementOfIdSet, - mkIdSet, intersectIdSets, - unionIdSets, idSetToList, IdSet(..), - GenId{-instanced NamedThing-} - ) -import Literal ( literalType, Literal{-instance Outputable-} ) -import Maybes ( catMaybes ) -import Name ( isLocallyDefined, getSrcLoc ) -import Outputable ( Outputable(..){-instance * []-} ) -import PprType ( GenType{-instance Outputable-}, TyCon ) -import Pretty -- quite a bit of it +import Bag ( Bag, emptyBag, isEmptyBag, snocBag, bagToList ) +import Id ( Id, idType, isLocalId ) +import VarSet +import DataCon ( DataCon, dataConInstArgTys, dataConRepType ) +import CoreSyn ( AltCon(..) ) import PrimOp ( primOpType ) -import SrcLoc ( SrcLoc{-instance Outputable-} ) -import Type ( mkFunTys, splitFunTy, maybeAppDataTyCon, - isTyVarTy, eqTy +import Literal ( literalType ) +import Maybes ( catMaybes ) +import Name ( getSrcLoc ) +import ErrUtils ( Message, mkLocMessage ) +import Type ( mkFunTys, splitFunTys, splitTyConApp_maybe, + isUnLiftedType, isTyVarTy, dropForAlls, Type ) -import Util ( zipEqual, pprPanic, panic, panic# ) +import TyCon ( isAlgTyCon, isNewTyCon, tyConDataCons ) +import Util ( zipEqual, equalLength ) +import SrcLoc ( srcLocSpan ) +import Outputable -infixr 9 `thenL`, `thenL_`, `thenMaybeL`, `thenMaybeL_` - -splitTypeWithDictsAsArgs = panic "StgLint.splitTypeWithDictsAsArgs (ToDo)" -unDictifyTy = panic "StgLint.unDictifyTy (ToDo)" +infixr 9 `thenL`, `thenL_`, `thenMaybeL` \end{code} Checks for (a) *some* type errors (b) locally-defined variables used but not defined + +Note: unless -dverbose-stg is on, display of lint errors will result +in "panic: bOGUS_LVs". + +WARNING: +~~~~~~~~ + +This module has suffered bit-rot; it is likely to yield lint errors +for Stg code that is currently perfectly acceptable for code +generation. Solution: don't use it! (KSW 2000-05). + + %************************************************************************ %* * \subsection{``lint'' for various constructs} @@ -51,18 +56,18 @@ Checks for @lintStgBindings@ is the top-level interface function. \begin{code} -lintStgBindings :: PprStyle -> String -> [StgBinding] -> [StgBinding] +lintStgBindings :: String -> [StgBinding] -> [StgBinding] -lintStgBindings sty whodunnit binds - = _scc_ "StgLint" +lintStgBindings whodunnit binds + = {-# SCC "StgLint" #-} case (initL (lint_binds binds)) of Nothing -> binds - Just msg -> pprPanic "" (ppAboves [ - ppStr ("*** Stg Lint Errors: in "++whodunnit++" ***"), - msg sty, - ppStr "*** Offending Program ***", - ppAboves (map (pprPlainStgBinding sty) binds), - ppStr "*** End of Offense ***"]) + Just msg -> pprPanic "" (vcat [ + ptext SLIT("*** Stg Lint ErrMsgs: in") <+> text whodunnit <+> ptext SLIT("***"), + msg, + ptext SLIT("*** Offending Program ***"), + pprStgBindings binds, + ptext SLIT("*** End of Offense ***")]) where lint_binds :: [StgBinding] -> LintM () @@ -77,11 +82,11 @@ lintStgBindings sty whodunnit binds \begin{code} lintStgArg :: StgArg -> LintM (Maybe Type) +lintStgArg (StgLitArg lit) = returnL (Just (literalType lit)) +lintStgArg (StgVarArg v) = lintStgVar v -lintStgArg (StgLitArg lit) = returnL (Just (literalType lit)) -lintStgArg a@(StgVarArg v) - = checkInScope v `thenL_` - returnL (Just (idType v)) +lintStgVar v = checkInScope v `thenL_` + returnL (Just (idType v)) \end{code} \begin{code} @@ -103,22 +108,31 @@ lint_binds_help (binder, rhs) -- Check the rhs lintStgRhs rhs `thenL` \ maybe_rhs_ty -> + -- Check binder doesn't have unlifted type + checkL (not (isUnLiftedType binder_ty)) + (mkUnLiftedTyMsg binder rhs) `thenL_` + -- Check match to RHS type (case maybe_rhs_ty of Nothing -> returnL () - Just rhs_ty -> checkTys (idType binder) + Just rhs_ty -> checkTys binder_ty rhs_ty (mkRhsMsg binder rhs_ty) ) `thenL_` returnL () ) + where + binder_ty = idType binder \end{code} \begin{code} lintStgRhs :: StgRhs -> LintM (Maybe Type) -lintStgRhs (StgRhsClosure _ _ _ _ binders expr) +lintStgRhs (StgRhsClosure _ _ _ _ _ [] expr) + = lintStgExpr expr + +lintStgRhs (StgRhsClosure _ _ _ _ _ binders expr) = addLoc (LambdaBodyOf binders) ( addInScopeVars binders ( lintStgExpr expr `thenMaybeL` \ body_ty -> @@ -131,35 +145,47 @@ lintStgRhs (StgRhsCon _ con args) Nothing -> returnL Nothing Just arg_tys -> checkFunApp con_ty arg_tys (mkRhsConMsg con_ty arg_tys) where - con_ty = idType con + con_ty = dataConRepType con \end{code} \begin{code} lintStgExpr :: StgExpr -> LintM (Maybe Type) -- Nothing if error found -lintStgExpr e@(StgApp fun args _) - = lintStgArg fun `thenMaybeL` \ fun_ty -> +lintStgExpr (StgLit l) = returnL (Just (literalType l)) + +lintStgExpr e@(StgApp fun args) + = lintStgVar fun `thenMaybeL` \ fun_ty -> mapMaybeL lintStgArg args `thenL` \ maybe_arg_tys -> case maybe_arg_tys of Nothing -> returnL Nothing Just arg_tys -> checkFunApp fun_ty arg_tys (mkFunAppMsg fun_ty arg_tys e) -lintStgExpr e@(StgCon con args _) +lintStgExpr e@(StgConApp con args) = mapMaybeL lintStgArg args `thenL` \ maybe_arg_tys -> case maybe_arg_tys of Nothing -> returnL Nothing Just arg_tys -> checkFunApp con_ty arg_tys (mkFunAppMsg con_ty arg_tys e) where - con_ty = idType con + con_ty = dataConRepType con + +lintStgExpr e@(StgOpApp (StgFCallOp _ _) args res_ty) + = -- We don't have enough type information to check + -- the application; ToDo + mapMaybeL lintStgArg args `thenL` \ maybe_arg_tys -> + returnL (Just res_ty) -lintStgExpr e@(StgPrim op args _) +lintStgExpr e@(StgOpApp (StgPrimOp op) args _) = mapMaybeL lintStgArg args `thenL` \ maybe_arg_tys -> case maybe_arg_tys of - Nothing -> returnL Nothing - Just arg_tys -> checkFunApp op_ty arg_tys (mkFunAppMsg op_ty arg_tys e) + Nothing -> returnL Nothing + Just arg_tys -> checkFunApp op_ty arg_tys (mkFunAppMsg op_ty arg_tys e) where op_ty = primOpType op +lintStgExpr (StgLam _ bndrs _) + = addErrL (ptext SLIT("Unexpected StgLam") <+> ppr bndrs) `thenL_` + returnL Nothing + lintStgExpr (StgLet binds body) = lintStgBinds binds `thenL` \ binders -> addLoc (BodyOfLetRec binders) ( @@ -174,42 +200,43 @@ lintStgExpr (StgLetNoEscape _ _ binds body) lintStgExpr body )) -lintStgExpr (StgSCC _ _ expr) = lintStgExpr expr +lintStgExpr (StgSCC _ expr) = lintStgExpr expr -lintStgExpr e@(StgCase scrut _ _ _ alts) +lintStgExpr e@(StgCase scrut _ _ bndr _ alts_type alts) = lintStgExpr scrut `thenMaybeL` \ _ -> - -- Check that it is a data type - case maybeAppDataTyCon scrut_ty of - Nothing -> addErrL (mkCaseDataConMsg e) `thenL_` - returnL Nothing - Just (tycon, _, _) - -> lintStgAlts alts scrut_ty tycon + (case alts_type of + AlgAlt tc -> check_bndr tc + PrimAlt tc -> check_bndr tc + UbxTupAlt tc -> check_bndr tc + PolyAlt -> returnL () + ) `thenL_` + + (trace (showSDoc (ppr e)) $ + -- we only allow case of tail-call or primop. + (case scrut of + StgApp _ _ -> returnL () + StgConApp _ _ -> returnL () + StgOpApp _ _ _ -> returnL () + other -> addErrL (mkCaseOfCaseMsg e)) `thenL_` + + addInScopeVars [bndr] (lintStgAlts alts scrut_ty) + ) where - scrut_ty = get_ty alts + scrut_ty = idType bndr + bad_bndr = mkDefltMsg bndr + check_bndr tc = case splitTyConApp_maybe scrut_ty of + Just (bndr_tc, _) -> checkL (tc == bndr_tc) bad_bndr + Nothing -> addErrL bad_bndr - get_ty (StgAlgAlts ty _ _) = ty - get_ty (StgPrimAlts ty _ _) = ty -\end{code} -\begin{code} -lintStgAlts :: StgCaseAlts - -> Type -- Type of scrutinee - -> TyCon -- TyCon pinned on the case - -> LintM (Maybe Type) -- Type of alternatives - -lintStgAlts alts scrut_ty case_tycon - = (case alts of - StgAlgAlts _ alg_alts deflt -> - mapL (lintAlgAlt scrut_ty) alg_alts `thenL` \ maybe_alt_tys -> - lintDeflt deflt scrut_ty `thenL` \ maybe_deflt_ty -> - returnL (maybe_deflt_ty : maybe_alt_tys) - - StgPrimAlts _ prim_alts deflt -> - mapL (lintPrimAlt scrut_ty) prim_alts `thenL` \ maybe_alt_tys -> - lintDeflt deflt scrut_ty `thenL` \ maybe_deflt_ty -> - returnL (maybe_deflt_ty : maybe_alt_tys) - ) `thenL` \ maybe_result_tys -> +lintStgAlts :: [StgAlt] + -> Type -- Type of scrutinee + -> LintM (Maybe Type) -- Type of alternatives + +lintStgAlts alts scrut_ty + = mapL (lintAlt scrut_ty) alts `thenL` \ maybe_result_tys -> + -- Check the result types case catMaybes (maybe_result_tys) of [] -> returnL Nothing @@ -219,19 +246,29 @@ lintStgAlts alts scrut_ty case_tycon where check ty = checkTys first_ty ty (mkCaseAltMsg alts) -lintAlgAlt scrut_ty (con, args, _, rhs) - = (case maybeAppDataTyCon scrut_ty of - Nothing -> - addErrL (mkAlgAltMsg1 scrut_ty) - Just (tycon, tys_applied, cons) -> +lintAlt scrut_ty (DEFAULT, _, _, rhs) + = lintStgExpr rhs + +lintAlt scrut_ty (LitAlt lit, _, _, rhs) + = checkTys (literalType lit) scrut_ty (mkAltMsg1 scrut_ty) `thenL_` + lintStgExpr rhs + +lintAlt scrut_ty (DataAlt con, args, _, rhs) + = (case splitTyConApp_maybe scrut_ty of + Just (tycon, tys_applied) | isAlgTyCon tycon && + not (isNewTyCon tycon) -> let - arg_tys = dataConArgTys con tys_applied + cons = tyConDataCons tycon + arg_tys = dataConInstArgTys con tys_applied + -- This almost certainly does not work for existential constructors in checkL (con `elem` cons) (mkAlgAltMsg2 scrut_ty con) `thenL_` - checkL (length arg_tys == length args) (mkAlgAltMsg3 con args) + checkL (equalLength arg_tys args) (mkAlgAltMsg3 con args) `thenL_` - mapL check (arg_tys `zipEqual` args) `thenL_` + mapL check (zipEqual "lintAlgAlt:stg" arg_tys args) `thenL_` returnL () + other -> + addErrL (mkAltMsg1 scrut_ty) ) `thenL_` addInScopeVars args ( lintStgExpr rhs @@ -244,17 +281,6 @@ lintAlgAlt scrut_ty (con, args, _, rhs) -- We give it its own copy, so it isn't overloaded. elem _ [] = False elem x (y:ys) = x==y || elem x ys - -lintPrimAlt scrut_ty alt@(lit,rhs) - = checkTys (literalType lit) scrut_ty (mkPrimAltMsg alt) `thenL_` - lintStgExpr rhs - -lintDeflt StgNoDefault scrut_ty = returnL Nothing -lintDeflt deflt@(StgBindDefault binder _ rhs) scrut_ty - = checkTys (idType binder) scrut_ty (mkDefltMsg deflt) `thenL_` - addInScopeVars [binder] ( - lintStgExpr rhs - ) \end{code} @@ -267,46 +293,39 @@ lintDeflt deflt@(StgBindDefault binder _ rhs) scrut_ty \begin{code} type LintM a = [LintLocInfo] -- Locations -> IdSet -- Local vars in scope - -> Bag ErrMsg -- Error messages so far - -> (a, Bag ErrMsg) -- Result and error messages (if any) - -type ErrMsg = PprStyle -> Pretty + -> Bag Message -- Error messages so far + -> (a, Bag Message) -- Result and error messages (if any) data LintLocInfo = RhsOf Id -- The variable bound | LambdaBodyOf [Id] -- The lambda-binder | BodyOfLetRec [Id] -- One of the binders -instance Outputable LintLocInfo where - ppr sty (RhsOf v) - = ppBesides [ppr sty (getSrcLoc v), ppStr ": [RHS of ", pp_binders sty [v], ppStr "]"] +dumpLoc (RhsOf v) = + (srcLocSpan (getSrcLoc v), ptext SLIT(" [RHS of ") <> pp_binders [v] <> char ']' ) +dumpLoc (LambdaBodyOf bs) = + (srcLocSpan (getSrcLoc (head bs)), ptext SLIT(" [in body of lambda with binders ") <> pp_binders bs <> char ']' ) - ppr sty (LambdaBodyOf bs) - = ppBesides [ppr sty (getSrcLoc (head bs)), - ppStr ": [in body of lambda with binders ", pp_binders sty bs, ppStr "]"] +dumpLoc (BodyOfLetRec bs) = + (srcLocSpan (getSrcLoc (head bs)), ptext SLIT(" [in body of letrec with binders ") <> pp_binders bs <> char ']' ) - ppr sty (BodyOfLetRec bs) - = ppBesides [ppr sty (getSrcLoc (head bs)), - ppStr ": [in body of letrec with binders ", pp_binders sty bs, ppStr "]"] -pp_binders :: PprStyle -> [Id] -> Pretty -pp_binders sty bs - = ppInterleave ppComma (map pp_binder bs) +pp_binders :: [Id] -> SDoc +pp_binders bs + = sep (punctuate comma (map pp_binder bs)) where pp_binder b - = ppCat [ppr sty b, ppStr "::", ppr sty (idType b)] + = hsep [ppr b, dcolon, ppr (idType b)] \end{code} \begin{code} -initL :: LintM a -> Maybe ErrMsg +initL :: LintM a -> Maybe Message initL m - = case (m [] emptyIdSet emptyBag) of { (_, errs) -> + = case (m [] emptyVarSet emptyBag) of { (_, errs) -> if isEmptyBag errs then Nothing else - Just ( \ sty -> - foldBag ppAbove ( \ msg -> msg sty ) ppNil errs - ) + Just (vcat (punctuate (text "") (bagToList errs))) } returnL :: a -> LintM a @@ -328,12 +347,6 @@ thenMaybeL m k loc scope errs (Nothing, errs2) -> (Nothing, errs2) (Just r, errs2) -> k r loc scope errs2 -thenMaybeL_ :: LintM (Maybe a) -> LintM (Maybe b) -> LintM (Maybe b) -thenMaybeL_ m k loc scope errs - = case m loc scope errs of - (Nothing, errs2) -> (Nothing, errs2) - (Just _, errs2) -> k loc scope errs2 - mapL :: (a -> LintM b) -> [a] -> LintM [b] mapL f [] = returnL [] mapL f (x:xs) @@ -351,19 +364,21 @@ mapMaybeL f (x:xs) \end{code} \begin{code} -checkL :: Bool -> ErrMsg -> LintM () +checkL :: Bool -> Message -> LintM () checkL True msg loc scope errs = ((), errs) checkL False msg loc scope errs = ((), addErr errs msg loc) -addErrL :: ErrMsg -> LintM () +addErrL :: Message -> LintM () addErrL msg loc scope errs = ((), addErr errs msg loc) -addErr :: Bag ErrMsg -> ErrMsg -> [LintLocInfo] -> Bag ErrMsg +addErr :: Bag Message -> Message -> [LintLocInfo] -> Bag Message addErr errs_so_far msg locs - = errs_so_far `snocBag` ( \ sty -> - ppHang (ppr sty (head locs)) 4 (msg sty) - ) + = errs_so_far `snocBag` mk_msg locs + where + mk_msg (loc:_) = let (l,hdr) = dumpLoc loc + in mkLocMessage l (hdr $$ msg) + mk_msg [] = msg addLoc :: LintLocInfo -> LintM a -> LintM a addLoc extra_loc m loc scope errs @@ -376,28 +391,32 @@ addInScopeVars ids m loc scope errs -- For now, it's just a "trace"; we may make -- a real error out of it... let - new_set = mkIdSet ids - - shadowed = scope `intersectIdSets` new_set + new_set = mkVarSet ids in -- After adding -fliberate-case, Simon decided he likes shadowed -- names after all. WDP 94/07 --- (if isEmptyIdSet shadowed +-- (if isEmptyVarSet shadowed -- then id --- else pprTrace "Shadowed vars:" (ppr PprDebug (idSetToList shadowed))) $ - m loc (scope `unionIdSets` new_set) errs +-- else pprTrace "Shadowed vars:" (ppr (varSetElems shadowed))) $ + m loc (scope `unionVarSet` new_set) errs \end{code} +Checking function applications: we only check that the type has the +right *number* of arrows, we don't actually compare the types. This +is because we can't expect the types to be equal - the type +applications and type lambdas that we use to calculate accurate types +have long since disappeared. + \begin{code} -checkFunApp :: Type -- The function type - -> [Type] -- The arg type(s) - -> ErrMsg -- Error messgae - -> LintM (Maybe Type) -- The result type +checkFunApp :: Type -- The function type + -> [Type] -- The arg type(s) + -> Message -- Error messgae + -> LintM (Maybe Type) -- The result type checkFunApp fun_ty arg_tys msg loc scope errs = cfa res_ty expected_arg_tys arg_tys where - (_, expected_arg_tys, res_ty) = splitTypeWithDictsAsArgs fun_ty + (expected_arg_tys, res_ty) = splitFunTys (dropForAlls fun_ty) cfa res_ty expected [] -- Args have run out; that's fine = (Just (mkFunTys expected res_ty), errs) @@ -409,127 +428,97 @@ checkFunApp fun_ty arg_tys msg loc scope errs | isTyVarTy res_ty = (Just res_ty, errs) | otherwise - = case splitFunTy (unDictifyTy res_ty) of + = case splitFunTys res_ty of ([], _) -> (Nothing, addErr errs msg loc) -- Too many args (new_expected, new_res) -> cfa new_res new_expected arg_tys cfa res_ty (expected_arg_ty:expected_arg_tys) (arg_ty:arg_tys) - = if (sleazy_eq_ty expected_arg_ty arg_ty) - then cfa res_ty expected_arg_tys arg_tys - else (Nothing, addErr errs msg loc) -- Arg mis-match + = cfa res_ty expected_arg_tys arg_tys \end{code} \begin{code} checkInScope :: Id -> LintM () checkInScope id loc scope errs - = if isLocallyDefined id && not (isDataCon id) && not (id `elementOfIdSet` scope) then - ((), addErr errs (\ sty -> ppCat [ppr sty id, ppStr "is out of scope"]) loc) + = if isLocalId id && not (id `elemVarSet` scope) then + ((), addErr errs (hsep [ppr id, ptext SLIT("is out of scope")]) loc) else ((), errs) -checkTys :: Type -> Type -> ErrMsg -> LintM () +checkTys :: Type -> Type -> Message -> LintM () checkTys ty1 ty2 msg loc scope errs - = if (sleazy_eq_ty ty1 ty2) - then ((), errs) - else ((), addErr errs msg loc) + = -- if (ty1 == ty2) then + ((), errs) + -- else ((), addErr errs msg loc) \end{code} \begin{code} -mkCaseAltMsg :: StgCaseAlts -> ErrMsg -mkCaseAltMsg alts sty - = ppAbove (ppStr "In some case alternatives, type of alternatives not all same:") - -- LATER: (ppr sty alts) - (panic "mkCaseAltMsg") - -mkCaseDataConMsg :: StgExpr -> ErrMsg -mkCaseDataConMsg expr sty - = ppAbove (ppStr "A case scrutinee not a type-constructor type:") - (pp_expr sty expr) - -mkCaseAbstractMsg :: TyCon -> ErrMsg -mkCaseAbstractMsg tycon sty - = ppAbove (ppStr "An algebraic case on an abstract type:") - (ppr sty tycon) - -mkDefltMsg :: StgCaseDefault -> ErrMsg -mkDefltMsg deflt sty - = ppAbove (ppStr "Binder in default case of a case expression doesn't match type of scrutinee:") - --LATER: (ppr sty deflt) +mkCaseAltMsg :: [StgAlt] -> Message +mkCaseAltMsg alts + = ($$) (text "In some case alternatives, type of alternatives not all same:") + (empty) -- LATER: ppr alts + +mkDefltMsg :: Id -> Message +mkDefltMsg bndr + = ($$) (ptext SLIT("Binder of a case expression doesn't match type of scrutinee:")) (panic "mkDefltMsg") -mkFunAppMsg :: Type -> [Type] -> StgExpr -> ErrMsg -mkFunAppMsg fun_ty arg_tys expr sty - = ppAboves [ppStr "In a function application, function type doesn't match arg types:", - ppHang (ppStr "Function type:") 4 (ppr sty fun_ty), - ppHang (ppStr "Arg types:") 4 (ppAboves (map (ppr sty) arg_tys)), - ppHang (ppStr "Expression:") 4 (pp_expr sty expr)] - -mkRhsConMsg :: Type -> [Type] -> ErrMsg -mkRhsConMsg fun_ty arg_tys sty - = ppAboves [ppStr "In a RHS constructor application, con type doesn't match arg types:", - ppHang (ppStr "Constructor type:") 4 (ppr sty fun_ty), - ppHang (ppStr "Arg types:") 4 (ppAboves (map (ppr sty) arg_tys))] - -mkUnappTyMsg :: Id -> Type -> ErrMsg -mkUnappTyMsg var ty sty - = ppAboves [ppStr "Variable has a for-all type, but isn't applied to any types.", - ppBeside (ppStr "Var: ") (ppr sty var), - ppBeside (ppStr "Its type: ") (ppr sty ty)] - -mkAlgAltMsg1 :: Type -> ErrMsg -mkAlgAltMsg1 ty sty - = ppAbove (ppStr "In some case statement, type of scrutinee is not a data type:") - (ppr sty ty) - -mkAlgAltMsg2 :: Type -> Id -> ErrMsg -mkAlgAltMsg2 ty con sty - = ppAboves [ - ppStr "In some algebraic case alternative, constructor is not a constructor of scrutinee type:", - ppr sty ty, - ppr sty con +mkFunAppMsg :: Type -> [Type] -> StgExpr -> Message +mkFunAppMsg fun_ty arg_tys expr + = vcat [text "In a function application, function type doesn't match arg types:", + hang (ptext SLIT("Function type:")) 4 (ppr fun_ty), + hang (ptext SLIT("Arg types:")) 4 (vcat (map (ppr) arg_tys)), + hang (ptext SLIT("Expression:")) 4 (ppr expr)] + +mkRhsConMsg :: Type -> [Type] -> Message +mkRhsConMsg fun_ty arg_tys + = vcat [text "In a RHS constructor application, con type doesn't match arg types:", + hang (ptext SLIT("Constructor type:")) 4 (ppr fun_ty), + hang (ptext SLIT("Arg types:")) 4 (vcat (map (ppr) arg_tys))] + +mkAltMsg1 :: Type -> Message +mkAltMsg1 ty + = ($$) (text "In a case expression, type of scrutinee does not match patterns") + (ppr ty) + +mkAlgAltMsg2 :: Type -> DataCon -> Message +mkAlgAltMsg2 ty con + = vcat [ + text "In some algebraic case alternative, constructor is not a constructor of scrutinee type:", + ppr ty, + ppr con ] -mkAlgAltMsg3 :: Id -> [Id] -> ErrMsg -mkAlgAltMsg3 con alts sty - = ppAboves [ - ppStr "In some algebraic case alternative, number of arguments doesn't match constructor:", - ppr sty con, - ppr sty alts +mkAlgAltMsg3 :: DataCon -> [Id] -> Message +mkAlgAltMsg3 con alts + = vcat [ + text "In some algebraic case alternative, number of arguments doesn't match constructor:", + ppr con, + ppr alts ] -mkAlgAltMsg4 :: Type -> Id -> ErrMsg -mkAlgAltMsg4 ty arg sty - = ppAboves [ - ppStr "In some algebraic case alternative, type of argument doesn't match data constructor:", - ppr sty ty, - ppr sty arg +mkAlgAltMsg4 :: Type -> Id -> Message +mkAlgAltMsg4 ty arg + = vcat [ + text "In some algebraic case alternative, type of argument doesn't match data constructor:", + ppr ty, + ppr arg ] -mkPrimAltMsg :: (Literal, StgExpr) -> ErrMsg -mkPrimAltMsg alt sty - = ppAbove (ppStr "In a primitive case alternative, type of literal doesn't match type of scrutinee:") - (ppr sty alt) - -mkRhsMsg :: Id -> Type -> ErrMsg -mkRhsMsg binder ty sty - = ppAboves [ppCat [ppStr "The type of this binder doesn't match the type of its RHS:", - ppr sty binder], - ppCat [ppStr "Binder's type:", ppr sty (idType binder)], - ppCat [ppStr "Rhs type:", ppr sty ty] - ] +mkCaseOfCaseMsg :: StgExpr -> Message +mkCaseOfCaseMsg e + = text "Case of non-tail-call:" $$ ppr e -pp_expr :: PprStyle -> StgExpr -> Pretty -pp_expr sty expr = ppr sty expr +mkRhsMsg :: Id -> Type -> Message +mkRhsMsg binder ty + = vcat [hsep [ptext SLIT("The type of this binder doesn't match the type of its RHS:"), + ppr binder], + hsep [ptext SLIT("Binder's type:"), ppr (idType binder)], + hsep [ptext SLIT("Rhs type:"), ppr ty] + ] -sleazy_eq_ty ty1 ty2 - -- NB: probably severe overkill (WDP 95/04) - = case (splitTypeWithDictsAsArgs ty1) of { (_,tyargs1,tyres1) -> - case (splitTypeWithDictsAsArgs ty2) of { (_,tyargs2,tyres2) -> - let - ty11 = mkFunTys tyargs1 tyres1 - ty22 = mkFunTys tyargs2 tyres2 - in - trace "StgLint.sleazy_cmp_ty" $ - ty11 `eqTy` ty22 - }} +mkUnLiftedTyMsg binder rhs + = (ptext SLIT("Let(rec) binder") <+> quotes (ppr binder) <+> + ptext SLIT("has unlifted type") <+> quotes (ppr (idType binder))) + $$ + (ptext SLIT("RHS:") <+> ppr rhs) \end{code}