X-Git-Url: http://git.megacz.com/?a=blobdiff_plain;f=rts%2FTask.c;h=72147256d80230687b7469c9cafbea4d8150a475;hb=afdbaf48894b74eee5b6cc5c17c477d9e517f389;hp=ef20c09a6e97eb07e3cfaa7b051762030ae12223;hpb=9f2ceb4da7dfbc1cfd09ce54610ebe64288b9007;p=ghc-hetmet.git

diff --git a/rts/Task.c b/rts/Task.c
index ef20c09..7214725 100644
--- a/rts/Task.c
+++ b/rts/Task.c
@@ -28,8 +28,6 @@
 Task *all_tasks = NULL;
 static Task *task_free_list = NULL; // singly-linked
 static nat taskCount;
-#define DEFAULT_MAX_WORKERS 64
-static nat maxWorkers; // we won't create more workers than this
 static nat tasksRunning;
 static nat workerCount;
 
@@ -58,11 +56,6 @@ initTaskManager (void)
 	taskCount = 0;
 	workerCount = 0;
 	tasksRunning = 0;
-#if defined(THREADED_RTS)
-	maxWorkers = DEFAULT_MAX_WORKERS * RtsFlags.ParFlags.nNodes;
-#else
-	maxWorkers = DEFAULT_MAX_WORKERS;
-#endif
 	initialized = 1;
 #if defined(THREADED_RTS)
 	newThreadLocalKey(&currentTaskKey);
@@ -81,9 +74,13 @@ stopTaskManager (void)
 	       tasksRunning);
 
     ACQUIRE_LOCK(&sched_mutex);
-    for (task = task_free_list; task != NULL; next) {
+    for (task = task_free_list; task != NULL; task = next) {
         next = task->next;
         stgFree(task);
+#if defined(THREADED_RTS)
+        closeCondition(&task->cond);
+        closeMutex(&task->lock);
+#endif
     }
     task_free_list = NULL;
     RELEASE_LOCK(&sched_mutex);
@@ -199,7 +196,7 @@ discardTask (Task *task)
 {
     ASSERT_LOCK_HELD(&sched_mutex);
     if (!task->stopped) {
-	debugTrace(DEBUG_sched, "discarding task %ld", TASK_ID(task));
+	debugTrace(DEBUG_sched, "discarding task %ld", (long)TASK_ID(task));
 	task->cap = NULL;
 	task->tso = NULL;
 	task->stopped = rtsTrue;
@@ -264,9 +261,6 @@ startWorkerTask (Capability *cap,
   OSThreadId tid;
   Task *task;
 
-  if (workerCount >= maxWorkers) {
-      barf("too many workers; runaway worker creation?");
-  }
   workerCount++;
 
   // A worker always gets a fresh Task structure.
@@ -289,7 +283,8 @@ startWorkerTask (Capability *cap,
 
   r = createOSThread(&tid, (OSThreadProc *)taskStart, task);
   if (r != 0) {
-    barf("startTask: Can't create new task");
+    sysErrorBelch("failed to create OS thread");
+    stg_exit(EXIT_FAILURE);
   }
 
   debugTrace(DEBUG_sched, "new worker task (taskCount: %d)", taskCount);
@@ -326,7 +321,7 @@ printAllTasks(void)
 		debugBelch("on capability %d, ", task->cap->no);
 	    }
 	    if (task->tso) {
-		debugBelch("bound to thread %d", task->tso->id);
+	      debugBelch("bound to thread %lu", (unsigned long)task->tso->id);
 	    } else {
 		debugBelch("worker");
 	    }