X-Git-Url: http://git.megacz.com/?a=blobdiff_plain;f=src%2Forg%2Fxwt%2FSpecialBoxProperty.java;h=16bba2e0c9a8729e9af28148d29a2b939c5c2091;hb=73a175a99d7a0ede9b4268c8670a9958895cc713;hp=52fc331adf09c2aa4c2b4b68303503a762a5c8d2;hpb=5d41517a1e4ee5201568531809835f663d00be3b;p=org.ibex.core.git diff --git a/src/org/xwt/SpecialBoxProperty.java b/src/org/xwt/SpecialBoxProperty.java index 52fc331..16bba2e 100644 --- a/src/org/xwt/SpecialBoxProperty.java +++ b/src/org/xwt/SpecialBoxProperty.java @@ -1,11 +1,11 @@ // Copyright 2002 Adam Megacz, see the COPYING file for licensing [GPL] package org.xwt; -import org.mozilla.javascript.*; -import org.xwt.util.*; import java.util.*; import java.net.*; import java.text.*; +import org.xwt.js.*; +import org.xwt.util.*; /** * A helper class for properties of Box which require special @@ -64,7 +64,10 @@ class SpecialBoxProperty { static final int white = 0xFFFFFFFF; static { + init(); + } + private static void init() { specialBoxProperties.put("color", new SpecialBoxProperty() { public Object get(Box b) { if ((b.color & 0xFF000000) == 0) return null; @@ -81,10 +84,15 @@ class SpecialBoxProperty { String s = value == null ? null : value.toString(); if (value == null) newcolor = 0x00000000; else if (s.length() > 0 && s.charAt(0) == '#') - newcolor = 0xFF000000 | - (Integer.parseInt(s.substring(1, 3), 16) << 16) | - (Integer.parseInt(s.substring(3, 5), 16) << 8) | - Integer.parseInt(s.substring(5, 7), 16); + try { + newcolor = 0xFF000000 | + (Integer.parseInt(s.substring(1, 3), 16) << 16) | + (Integer.parseInt(s.substring(3, 5), 16) << 8) | + Integer.parseInt(s.substring(5, 7), 16); + } catch (NumberFormatException e) { + Log.log(this, "invalid color " + s); + return; + } else if (s.equals("black")) newcolor = black; else if (s.equals("blue")) newcolor = blue; else if (s.equals("green")) newcolor = green; @@ -101,8 +109,7 @@ class SpecialBoxProperty { else if (s.equals("pink")) newcolor = pink; else if (s.equals("yellow")) newcolor = yellow; else if (s.equals("white")) newcolor = white; - else if (Log.on) Log.log(this, "invalid color " + s); - + else if (Log.on) Log.logJS(this, "invalid color \"" + s + "\""); if (newcolor == b.color) return; b.color = newcolor; b.dirty(); @@ -145,8 +152,7 @@ class SpecialBoxProperty { else if (s.equals("pink")) newtextcolor = pink; else if (s.equals("yellow")) newtextcolor = yellow; else if (s.equals("white")) newtextcolor = white; - else if (Log.on) Log.log(this, "invalid textcolor " + s); - + else if (Log.on) Log.logJS(this, "invalid color \"" + s + "\""); if (newtextcolor == b.textcolor) return; b.textcolor = newtextcolor; b.dirty(); @@ -163,14 +169,11 @@ class SpecialBoxProperty { if (Log.on) Log.log(this, "ISO Control characters are not permitted in box text strings; offending character is ASCII " + ((int)t.charAt(i))); - /* FIXME: reinstate return; - */ } - // FIXME: don't know why this is needed + // FEATURE: try removing the following line; it appears to be redundant b.dirty(); - b.text = t; b.textupdate(); b.dirty(); @@ -180,9 +183,12 @@ class SpecialBoxProperty { public Object get(Box b) { return b; } public void put(Box b, Object value) { if (value == null) b.remove(); - else if (value.equals("window")) Platform.createSurface(b, false, true); - else if (value.equals("frame")) Platform.createSurface(b, true, true); - else if (Log.on) Log.log(this, "put invalid value to 'thisbox' property: " + value); + else if (value.equals("window") || value.equals("frame")) { + if (b.redirect != b && Log.on) + Log.log(this, "WARNING: you have created a surface whose root box's redirect is not itself " + + "-- this isn't usually a good idea"); + Platform.createSurface(b, value.equals("frame"), true); + } else if (Log.on) Log.log(this, "put invalid value to 'thisbox' property: " + value); } }); @@ -216,7 +222,7 @@ class SpecialBoxProperty { specialBoxProperties.put("static", new SpecialBoxProperty() { public Object get(Box b) { - String cfsn = JSObject.getCurrentFunctionSourceName(); + String cfsn = JS.Thread.fromJavaThread(Thread.currentThread()).getCurrentCompiledFunction().getSourceName(); for(int i=0; i