X-Git-Url: http://git.megacz.com/?a=blobdiff_plain;f=src%2Forg%2Fxwt%2FSpecialBoxProperty.java;h=2da34107f23947f923b403020398ba945a3e24b9;hb=b549fc8820c5f1852f7563c933a88502b02cbb7d;hp=205b8e605d27967e81ab82487390b15024aec4d6;hpb=6242c991f365dbd67eba62ecfa5df769a83fcbc6;p=org.ibex.core.git diff --git a/src/org/xwt/SpecialBoxProperty.java b/src/org/xwt/SpecialBoxProperty.java index 205b8e6..2da3410 100644 --- a/src/org/xwt/SpecialBoxProperty.java +++ b/src/org/xwt/SpecialBoxProperty.java @@ -1,11 +1,11 @@ // Copyright 2002 Adam Megacz, see the COPYING file for licensing [GPL] package org.xwt; -import org.mozilla.javascript.*; -import org.xwt.util.*; import java.util.*; import java.net.*; import java.text.*; +import org.xwt.js.*; +import org.xwt.util.*; /** * A helper class for properties of Box which require special @@ -64,7 +64,6 @@ class SpecialBoxProperty { static final int white = 0xFFFFFFFF; static { - specialBoxProperties.put("color", new SpecialBoxProperty() { public Object get(Box b) { if ((b.color & 0xFF000000) == 0) return null; @@ -81,10 +80,15 @@ class SpecialBoxProperty { String s = value == null ? null : value.toString(); if (value == null) newcolor = 0x00000000; else if (s.length() > 0 && s.charAt(0) == '#') - newcolor = 0xFF000000 | - (Integer.parseInt(s.substring(1, 3), 16) << 16) | - (Integer.parseInt(s.substring(3, 5), 16) << 8) | - Integer.parseInt(s.substring(5, 7), 16); + try { + newcolor = 0xFF000000 | + (Integer.parseInt(s.substring(1, 3), 16) << 16) | + (Integer.parseInt(s.substring(3, 5), 16) << 8) | + Integer.parseInt(s.substring(5, 7), 16); + } catch (NumberFormatException e) { + Log.log(this, "invalid color " + s); + return; + } else if (s.equals("black")) newcolor = black; else if (s.equals("blue")) newcolor = blue; else if (s.equals("green")) newcolor = green; @@ -101,8 +105,7 @@ class SpecialBoxProperty { else if (s.equals("pink")) newcolor = pink; else if (s.equals("yellow")) newcolor = yellow; else if (s.equals("white")) newcolor = white; - else if (Log.on) Log.log(this, "invalid color " + s); - + else if (Log.on) Log.logJS(this, "invalid color \"" + s + "\""); if (newcolor == b.color) return; b.color = newcolor; b.dirty(); @@ -122,7 +125,8 @@ class SpecialBoxProperty { } public void put(Box b, Object value) { int newtextcolor = b.color; - String s = value == null ? null : value.toString(); + if (value == null) return; + String s = value.toString(); if (s.length() > 0 && s.charAt(0) == '#') newtextcolor = 0xFF000000 | (Integer.parseInt(s.substring(1, 3), 16) << 16) | @@ -144,8 +148,7 @@ class SpecialBoxProperty { else if (s.equals("pink")) newtextcolor = pink; else if (s.equals("yellow")) newtextcolor = yellow; else if (s.equals("white")) newtextcolor = white; - else if (Log.on) Log.log(this, "invalid textcolor " + s); - + else if (Log.on) Log.logJS(this, "invalid color \"" + s + "\""); if (newtextcolor == b.textcolor) return; b.textcolor = newtextcolor; b.dirty(); @@ -162,11 +165,11 @@ class SpecialBoxProperty { if (Log.on) Log.log(this, "ISO Control characters are not permitted in box text strings; offending character is ASCII " + ((int)t.charAt(i))); - /* FIXME: reinstate return; - */ } + // FEATURE: try removing the following line; it appears to be redundant + b.dirty(); b.text = t; b.textupdate(); b.dirty(); @@ -176,9 +179,12 @@ class SpecialBoxProperty { public Object get(Box b) { return b; } public void put(Box b, Object value) { if (value == null) b.remove(); - else if (value.equals("window")) Platform.createSurface(b, false, true); - else if (value.equals("frame")) Platform.createSurface(b, true, true); - else if (Log.on) Log.log(this, "put invalid value to 'thisbox' property: " + value); + else if (value.equals("window") || value.equals("frame")) { + if (b.redirect != b && Log.on) + Log.log(this, "WARNING: you have created a surface whose root box's redirect is not itself " + + "-- this isn't usually a good idea"); + Platform.createSurface(b, value.equals("frame"), true); + } else if (Log.on) Log.log(this, "put invalid value to 'thisbox' property: " + value); } }); @@ -212,7 +218,7 @@ class SpecialBoxProperty { specialBoxProperties.put("static", new SpecialBoxProperty() { public Object get(Box b) { - String cfsn = JSObject.getCurrentFunctionSourceName(); + String cfsn = JS.Thread.fromJavaThread(Thread.currentThread()).getCurrentCompiledFunction().getSourceName(); for(int i=0; i