From: simonpj <unknown>
Date: Fri, 10 Jun 2005 13:33:27 +0000 (+0000)
Subject: [project @ 2005-06-10 13:33:27 by simonpj]
X-Git-Tag: Initial_conversion_from_CVS_complete~444
X-Git-Url: http://git.megacz.com/?a=commitdiff_plain;h=ae1f585b6abc49687ea96ecf1b718d2fbbe19d26;p=ghc-hetmet.git

[project @ 2005-06-10 13:33:27 by simonpj]
Comments only
---

diff --git a/ghc/compiler/typecheck/TcSimplify.lhs b/ghc/compiler/typecheck/TcSimplify.lhs
index fb898a0..c23e798 100644
--- a/ghc/compiler/typecheck/TcSimplify.lhs
+++ b/ghc/compiler/typecheck/TcSimplify.lhs
@@ -1314,9 +1314,8 @@ The main control over context reduction is here
 data WhatToDo
  = ReduceMe WantSCs	-- Try to reduce this
 			-- If there's no instance, behave exactly like
-			-- DontReduce: add the inst to
-			-- the irreductible ones, but don't
-			-- produce an error message of any kind.
+			-- DontReduce: add the inst to the irreductible ones, 
+			-- but don't produce an error message of any kind.
 			-- It might be quite legitimate such as (Eq a)!
 
  | KeepDictWithoutSCs	-- Return as irreducible; don't add its superclasses
@@ -1332,6 +1331,8 @@ reduceMe inst = ReduceMe AddSCs
 
 data WantSCs = NoSCs | AddSCs	-- Tells whether we should add the superclasses
 				-- of a predicate when adding it to the avails
+	-- The reason for this flag is entirely the super-class loop problem
+	-- Note [SUPER-CLASS LOOP 1]
 \end{code}
 
 
@@ -1858,7 +1859,7 @@ addAvailAndSCs want_scs avails inst avail
 
     findAllDeps :: IdSet -> Avail -> IdSet
     -- Find all the Insts that this one depends on
-    -- See Note [SUPERCLASS-LOOP]
+    -- See Note [SUPERCLASS-LOOP 2]
     -- Watch out, though.  Since the avails may contain loops 
     -- (see Note [RECURSIVE DICTIONARIES]), so we need to track the ones we've seen so far
     findAllDeps so_far (Rhs _ kids) = foldl find_all so_far kids