From ff91258cdc66148172e8533ebd115a836aa67b1b Mon Sep 17 00:00:00 2001 From: Simon Marlow Date: Thu, 10 May 2007 15:45:42 +0000 Subject: [PATCH] FIX #1181: parseStaticFlags should not be required - parseStaticFlags is now not required, but if it is called, it should be called only once and before newSession, otherwise you get an error. - parseStaticFlags is exported from GHC --- compiler/main/GHC.hs | 3 +++ compiler/main/StaticFlags.hs | 6 ++++++ 2 files changed, 9 insertions(+) diff --git a/compiler/main/GHC.hs b/compiler/main/GHC.hs index a850650..20c2aee 100644 --- a/compiler/main/GHC.hs +++ b/compiler/main/GHC.hs @@ -19,6 +19,7 @@ module GHC ( parseDynamicFlags, getSessionDynFlags, setSessionDynFlags, + parseStaticFlags, -- * Targets Target(..), TargetId(..), Phase, @@ -231,6 +232,7 @@ import Finder import HscMain ( newHscEnv, hscFileCheck, HscChecked(..) ) import HscTypes import DynFlags +import StaticFlags import SysTools ( initSysTools, cleanTempFiles, cleanTempFilesExcept, cleanTempDirs ) import Module @@ -338,6 +340,7 @@ newSession mb_top_dir = do modifyMVar_ interruptTargetThread (return . (main_thread :)) installSignalHandlers + initStaticOpts dflags0 <- initSysTools mb_top_dir defaultDynFlags dflags <- initDynFlags dflags0 env <- newHscEnv dflags diff --git a/compiler/main/StaticFlags.hs b/compiler/main/StaticFlags.hs index 1fa8388..0d17af2 100644 --- a/compiler/main/StaticFlags.hs +++ b/compiler/main/StaticFlags.hs @@ -12,6 +12,7 @@ module StaticFlags ( parseStaticFlags, staticFlags, + initStaticOpts, -- Ways WayName(..), v_Ways, v_Build_tag, v_RTS_Build_tag, isRTSWay, @@ -92,6 +93,9 @@ import Data.List ( sort, intersperse, nub ) parseStaticFlags :: [String] -> IO [String] parseStaticFlags args = do + ready <- readIORef v_opt_C_ready + when ready $ throwDyn (ProgramError "Too late for parseStaticFlags: call it before newSession") + (leftover, errs) <- processArgs static_flags args when (not (null errs)) $ throwDyn (UsageError (unlines errs)) @@ -118,6 +122,8 @@ parseStaticFlags args = do when (not (null errs)) $ ghcError (UsageError (unlines errs)) return (cg_flags++more_leftover++leftover) +initStaticOpts :: IO () +initStaticOpts = writeIORef v_opt_C_ready True static_flags :: [(String, OptKind IO)] -- All the static flags should appear in this list. It describes how each -- 1.7.10.4