refactoring only: use the parameterised InstalledPackageInfo

[ghc-hetmet.git] / compiler / main / Finder.lhs

diff --git a/compiler/main/Finder.lhs b/compiler/main/Finder.lhs
index 25bf90c..6e2b11d 100644 (file)
--- a/compiler/main/Finder.lhs
+++ b/compiler/main/Finder.lhs
@@ -4,13 +4,6 @@
 \section[Finder]{Module Finder}
 
 \begin{code}
-{-# OPTIONS -w #-}
--- The above warning supression flag is a temporary kludge.
--- While working on this module you are encouraged to remove it and fix
--- any warnings in the module. See
---     http://hackage.haskell.org/trac/ghc/wiki/Commentary/CodingStyle#Warnings
--- for details
-
 module Finder (
     flushFinderCaches,
     FindResult(..),
@@ -87,16 +80,25 @@ flushModLocationCache this_pkg ref = do
   where is_ext mod _ | modulePackageId mod /= this_pkg = True
                     | otherwise = False
 
+addToFinderCache :: IORef FinderCache -> ModuleName -> FindResult -> IO ()
 addToFinderCache       ref key val = modifyIORef ref $ \c -> addToUFM c key val
+
+addToModLocationCache :: IORef ModLocationCache -> Module -> ModLocation -> IO ()
 addToModLocationCache  ref key val = modifyIORef ref $ \c -> addToFM c key val
 
+removeFromFinderCache :: IORef FinderCache -> ModuleName -> IO ()
 removeFromFinderCache      ref key = modifyIORef ref $ \c -> delFromUFM c key
+
+removeFromModLocationCache :: IORef ModLocationCache -> Module -> IO ()
 removeFromModLocationCache ref key = modifyIORef ref $ \c -> delFromFM c key
 
+lookupFinderCache :: IORef FinderCache -> ModuleName -> IO (Maybe FindResult)
 lookupFinderCache ref key = do 
    c <- readIORef ref
    return $! lookupUFM c key
 
+lookupModLocationCache :: IORef ModLocationCache -> Module
+                       -> IO (Maybe ModLocation)
 lookupModLocationCache ref key = do
    c <- readIORef ref
    return $! lookupFM c key
@@ -148,6 +150,7 @@ findExactModule hsc_env mod =
 -- -----------------------------------------------------------------------------
 -- Helpers
 
+orIfNotFound :: IO FindResult -> IO FindResult -> IO FindResult
 this `orIfNotFound` or_this = do
   res <- this
   case res of
@@ -273,6 +276,7 @@ findPackageModule hsc_env mod = do
      Nothing -> return (NoPackage pkg_id)
      Just pkg_conf -> findPackageModule_ hsc_env mod pkg_conf
       
+findPackageModule_ :: HscEnv -> Module -> PackageConfig -> IO FindResult
 findPackageModule_ hsc_env mod pkg_conf = 
   modLocationCache hsc_env mod $
 
@@ -495,7 +499,7 @@ mkStubPaths dflags mod location
                 -- -I<dir> along with -stubdir <dir>.
                 include_basename
                         | Just _ <- stubdir = mod_basename 
-                        | otherwise         = filenameOf mod_basename
+                        | otherwise         = filenameOf src_basename
      in
         (stub_basename `joinFileExt` "c",
         stub_basename `joinFileExt` "h",
@@ -519,7 +523,7 @@ findObjectLinkableMaybe mod locn
 findObjectLinkable :: Module -> FilePath -> ClockTime -> IO Linkable
 findObjectLinkable mod obj_fn obj_time = do
   let stub_fn = case splitFilename3 obj_fn of
-                       (dir, base, ext) -> dir ++ "/" ++ base ++ "_stub.o"
+                       (dir, base, _ext) -> dir ++ "/" ++ base ++ "_stub.o"
   stub_exist <- doesFileExist stub_fn
   if stub_exist
        then return (LM obj_time mod [DotO obj_fn, DotO stub_fn])
@@ -528,9 +532,9 @@ findObjectLinkable mod obj_fn obj_time = do
 -- -----------------------------------------------------------------------------
 -- Utils
 
+dots_to_slashes :: String -> String
 dots_to_slashes = map (\c -> if c == '.' then '/' else c)
 
-
 -- -----------------------------------------------------------------------------
 -- Error messages
 
@@ -540,7 +544,8 @@ cannotFindModule = cantFindErr SLIT("Could not find module")
 cannotFindInterface  :: DynFlags -> ModuleName -> FindResult -> SDoc
 cannotFindInterface = cantFindErr SLIT("Failed to load interface for")
 
-cantFindErr cannot_find dflags mod_name (FoundMultiple pkgs)
+cantFindErr :: LitString -> DynFlags -> ModuleName -> FindResult -> SDoc
+cantFindErr cannot_find _dflags mod_name (FoundMultiple pkgs)
   = hang (ptext cannot_find <+> quotes (ppr mod_name) <> colon) 2 (
        sep [ptext SLIT("it was found in multiple packages:"),
                hsep (map (text.packageIdString) pkgs)]