second attempt to fix C compiler warnings with -fhpc
authorSimon Marlow <simonmar@microsoft.com>
Fri, 19 Oct 2007 13:32:43 +0000 (13:32 +0000)
committerSimon Marlow <simonmar@microsoft.com>
Fri, 19 Oct 2007 13:32:43 +0000 (13:32 +0000)
commita0d2d5bb9a949bc683d1fe576260f8c09930948a
tree056ed0dcda0f48f1d886fcb3176581a7876e9e75
parentcad764aa566442b08b1e68bf2c937772442a87cd
second attempt to fix C compiler warnings with -fhpc
The hs_hpc_module() prototype in RtsExternal.h didn't match its usage:
we were passing StgWord-sized parameters but the prototype used C
ints.  I think it accidentally worked because we only ever passed
constants that got promoted.  The constants unfortunately were
sometimes negative, which caused the C compiler to emit warnings.

I suspect PprC.pprHexVal may be wrong to emit negative constants in
the generated C, but I'm not completely sure.  Anyway, it's easy to
fix this in CgHpc, which is what I've done.
compiler/codeGen/CgHpc.hs
includes/RtsExternal.h