From: Simon Marlow <simonmar@microsoft.com>
Date: Tue, 20 Feb 2007 09:54:56 +0000 (+0000)
Subject: freeTaskManager: don't free Tasks that are still in use
X-Git-Url: http://git.megacz.com/?p=ghc-hetmet.git;a=commitdiff_plain;h=3f82e352ede25e6c3be4b3f5a32dcf313d9a0315

freeTaskManager: don't free Tasks that are still in use
See conc059.
---

diff --git a/rts/Task.c b/rts/Task.c
index 4a63084..4301ab4 100644
--- a/rts/Task.c
+++ b/rts/Task.c
@@ -84,12 +84,18 @@ freeTaskManager (void)
 
     ACQUIRE_LOCK(&sched_mutex);
     for (task = all_tasks; task != NULL; task = next) {
+        next = task->all_link;
+        if (task->stopped) {
+            // We only free resources if the Task is not in use.  A
+            // Task may still be in use if we have a Haskell thread in
+            // a foreign call while we are attempting to shut down the
+            // RTS (see conc059).
 #if defined(THREADED_RTS)
-        closeCondition(&task->cond);
-        closeMutex(&task->lock);
+            closeCondition(&task->cond);
+            closeMutex(&task->lock);
 #endif
-        next = task->all_link;
-        stgFree(task);
+            stgFree(task);
+        }
     }
     all_tasks = NULL;
     task_free_list = NULL;