From 611deea9a835d9c0d6d991af78739732a26aa21a Mon Sep 17 00:00:00 2001 From: Thomas Schilling Date: Thu, 27 Nov 2008 10:25:34 +0000 Subject: [PATCH] Collect instead of print warnings in 'warnUnnecessarySourceImports'. --- compiler/main/GHC.hs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/compiler/main/GHC.hs b/compiler/main/GHC.hs index 00b373a..08ae664 100644 --- a/compiler/main/GHC.hs +++ b/compiler/main/GHC.hs @@ -738,7 +738,7 @@ load2 how_much mod_graph logger = do -- If we can determine that any of the {-# SOURCE #-} imports -- are definitely unnecessary, then emit a warning. - warnUnnecessarySourceImports dflags mg2_with_srcimps + warnUnnecessarySourceImports mg2_with_srcimps let -- check the stability property for each module. @@ -1845,9 +1845,9 @@ nodeMapElts = eltsFM -- components in the topological sort, then those imports can -- definitely be replaced by ordinary non-SOURCE imports: if SOURCE -- were necessary, then the edge would be part of a cycle. -warnUnnecessarySourceImports :: GhcMonad m => DynFlags -> [SCC ModSummary] -> m () -warnUnnecessarySourceImports dflags sccs = - liftIO $ printBagOfWarnings dflags (listToBag (concatMap (check.flattenSCC) sccs)) +warnUnnecessarySourceImports :: GhcMonad m => [SCC ModSummary] -> m () +warnUnnecessarySourceImports sccs = + logWarnings (listToBag (concatMap (check.flattenSCC) sccs)) where check ms = let mods_in_this_cycle = map ms_mod_name ms in [ warn i | m <- ms, i <- ms_srcimps m, -- 1.7.10.4