From b633499b3a9508fce26b622f2d0cd836290e9503 Mon Sep 17 00:00:00 2001 From: Michal Terepeta Date: Sat, 27 Nov 2010 21:21:16 +0000 Subject: [PATCH] Don't warn of duplicate exports in case of module exports. But only when the module exports refer to different modules. See ticket #4478. --- compiler/rename/RnNames.lhs | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/compiler/rename/RnNames.lhs b/compiler/rename/RnNames.lhs index 9d2f542..e8490ac 100644 --- a/compiler/rename/RnNames.lhs +++ b/compiler/rename/RnNames.lhs @@ -1061,8 +1061,13 @@ check_occs ie occs names Nothing -> return (extendOccEnv occs name_occ (name, ie)) Just (name', ie') - | name == name' -- Duplicate export - -> do { warn_dup_exports <- doptM Opt_WarnDuplicateExports ; + | name == name' -- Duplicate export + -- But we don't want to warn if the same thing is exported + -- by two different module exports. See ticket #4478. + -> if diffModules ie ie' + then return occs + else do + { warn_dup_exports <- doptM Opt_WarnDuplicateExports ; warnIf warn_dup_exports (dupExportWarn name_occ ie ie') ; return occs } @@ -1072,6 +1077,9 @@ check_occs ie occs names return occs } where name_occ = nameOccName name + -- True if the two IE RdrName are different module exports. + diffModules (IEModuleContents n1) (IEModuleContents n2) = n1 /= n2 + diffModules _ _ = False \end{code} %********************************************************* -- 1.7.10.4