From d3541e298dbc79f6cc689cd72a3a3db9707e9d25 Mon Sep 17 00:00:00 2001 From: Ian Lynagh Date: Sun, 19 Dec 2010 19:40:32 +0000 Subject: [PATCH] Small refactoring --- compiler/rename/RnNames.lhs | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/compiler/rename/RnNames.lhs b/compiler/rename/RnNames.lhs index e8490ac..b5ed7d0 100644 --- a/compiler/rename/RnNames.lhs +++ b/compiler/rename/RnNames.lhs @@ -1064,12 +1064,10 @@ check_occs ie occs names | name == name' -- Duplicate export -- But we don't want to warn if the same thing is exported -- by two different module exports. See ticket #4478. - -> if diffModules ie ie' - then return occs - else do - { warn_dup_exports <- doptM Opt_WarnDuplicateExports ; - warnIf warn_dup_exports (dupExportWarn name_occ ie ie') ; - return occs } + -> do unless (diffModules ie ie') $ do + warn_dup_exports <- doptM Opt_WarnDuplicateExports + warnIf warn_dup_exports (dupExportWarn name_occ ie ie') + return occs | otherwise -- Same occ name but different names: an error -> do { global_env <- getGlobalRdrEnv ; -- 1.7.10.4