From 39f90dcf231fe24e5e6c03b3368a33a648b148fa Mon Sep 17 00:00:00 2001
From: adam <adam@megacz.com>
Date: Tue, 9 Mar 2004 09:52:04 +0000
Subject: [PATCH] fixed bug 471

darcs-hash:20040309095204-5007d-cfe89d94f776f69d4003bc381545be0c1fbad8db.gz
---
 src/org/ibex/Box.java |   32 ++++++++++++++++++++++----------
 1 file changed, 22 insertions(+), 10 deletions(-)

diff --git a/src/org/ibex/Box.java b/src/org/ibex/Box.java
index 04c591f..0e5d2a7 100644
--- a/src/org/ibex/Box.java
+++ b/src/org/ibex/Box.java
@@ -214,8 +214,10 @@ public final class Box extends JSScope implements Scheduler.Task {
     // static stuff so we don't have to keep reallocating
     private static int[] numRowsInCol = new int[65535];
     private static LENGTH[] colWidth = new LENGTH[65535];
+    private static LENGTH[] colMinWidth = new LENGTH[65535];
     private static LENGTH[] colMaxWidth = new LENGTH[65535];
     private static LENGTH[] rowHeight = new LENGTH[65535];
+    private static LENGTH[] rowMinHeight = new LENGTH[65535];
     private static LENGTH[] rowMaxHeight = new LENGTH[65535];
     static { for(int i=0; i<rowMaxHeight.length; i++) { rowMaxHeight[i] = MAX_LENGTH; colMaxWidth[i] = MAX_LENGTH; } }
 
@@ -245,12 +247,14 @@ public final class Box extends JSScope implements Scheduler.Task {
         }
         //#end
 
-        //#repeat contentwidth/contentheight colWidth/rowHeight colspan/rowspan col/row cols/rows minwidth/minheight \
-        //        textwidth/textheight maxwidth/maxheight
+        //#repeat contentwidth/contentheight colMinWidth/rowMinHeight colspan/rowspan col/row cols/rows minwidth/minheight \
+        //        textwidth/textheight maxwidth/maxheight colWidth/rowHeight
         contentwidth = 0;
-        for(Box child = firstPackedChild(); child != null; child = child.nextPackedSibling())
-            colWidth[child.col] = max(colWidth[child.col], child.contentwidth / child.colspan);
-        for(int i=0; i<cols; i++) { contentwidth += colWidth[i]; colWidth[i] = 0; }
+        for(Box child = firstPackedChild(); child != null; child = child.nextPackedSibling()) {
+            colMinWidth[child.col] = max(colMinWidth[child.col], child.contentwidth / child.colspan);
+            colWidth[child.col] = 0;
+        }
+        for(int i=0; i<cols; i++) { contentwidth += colMinWidth[i]; colMinWidth[i] = 0; }
         contentwidth = bound(minwidth, max(font == null || text == null ? 0 : font.textwidth(text), contentwidth), maxwidth);
         //#end               
     }
@@ -291,26 +295,34 @@ public final class Box extends JSScope implements Scheduler.Task {
 
     void resize_children() {
 
+        int eligible;
         //#repeat col/row colspan/rowspan contentwidth/contentheight x/y width/height colMaxWidth/rowMaxHeight colWidth/rowHeight \
-        //        HSHRINK/VSHRINK maxwidth/maxheight cols/rows minwidth/minheight colWidth/rowHeight x_slack/y_slack
+        //        colMinWidth/rowMinHeight HSHRINK/VSHRINK maxwidth/maxheight cols/rows minwidth/minheight colWidth/rowHeight \
+        //        x_slack/y_slack
         // PHASE 1: compute column min/max sizes
         int x_slack = width;
+        eligible = 0;
         for(int i=0; i<cols; i++) x_slack -= colWidth[i];
         for(Box child = firstPackedChild(); child != null; child = child.nextPackedSibling())
             for(int i=child.col; i < child.col + child.colspan; i++) {
-                x_slack += colWidth[i];
-                colWidth[i] = max(colWidth[i], child.contentwidth / child.colspan);
-                x_slack -= colWidth[i];
+                colMinWidth[i] = max(colWidth[i], child.contentwidth / child.colspan);
                 colMaxWidth[i] = min(colMaxWidth[i], child.test(HSHRINK) ? child.contentwidth : child.maxwidth) / child.colspan;
+                colWidth[i] = 0;
+                eligible++;
             }
         
         // PHASE 2: hand out slack
         for(int startslack = 0; x_slack > 0 && cols > 0 && startslack != x_slack;) {
-            int increment = max(1, x_slack / cols);
+            if (eligible == 0) break;
+            int increment = x_slack / eligible;
+            eligible = 0;
             startslack = x_slack;
             for(short col=0; col < cols; col++) {
                 // FIXME: double check this
                 int diff = min(min(colMaxWidth[col], colWidth[col] + increment) - colWidth[col], x_slack);
+                if (colWidth[col] + diff < colMinWidth[col]) diff = colMinWidth[col] - colWidth[col];
+                if (diff == 0) continue;
+                eligible++;
                 x_slack -= diff;
                 colWidth[col] += diff;
             }
-- 
1.7.10.4