UnwrapLeft, error reporting improvements

[sbp.git] / src / edu / berkeley / sbp / Node.java

diff --git a/src/edu/berkeley/sbp/Node.java b/src/edu/berkeley/sbp/Node.java
index b734a8f..b6f4585 100644 (file)
--- a/src/edu/berkeley/sbp/Node.java
+++ b/src/edu/berkeley/sbp/Node.java
@@ -33,11 +33,11 @@ final class Node
         //      - be on the frontier or
         //      - have a non-doomed node closer to the frontier than themself
         if (phase.isFrontier()) dead = false;
-        for(Result r : children)
-            if (state.doomed) { if (r.usedByAnyNode()) { dead = false; break; } }
-            else              { if (r.usedByNonDoomedNode()) { dead = false; break; } }
+        else for(Result r : children)
+                 if (state.doomed) { if (r.usedByAnyNode()) { dead = false; break; } }
+                 else              { if (r.usedByNonDoomedNode()) { dead = false; break; } }
         dead |= results.size()==0;
-        if (!dead || destroyed) return;
+        if (!dead) return;
         destroyed = true;
         while(children.size()>0)
             for(Result r : children) {
@@ -70,8 +70,11 @@ final class Node
     public final void invoke(Position r, Result only) {
         boolean emptyProductions = only==null;
         if (emptyProductions != (r.pos==0)) return;
-        if (r.pos==0) new Result(r.zero(phase().getLocation().createRegion(phase().getLocation())), this, r, phase());
-        else          reduce(r, r.pos-1, phase(), only);
+        if (r.pos!=0)  reduce(r, r.pos-1, phase(), only);
+        else {
+            Input.Region region = phase().getLocation().createRegion(phase().getLocation());
+            new Result(r.rewrite(region, phase().parser().cache()), this, r, phase());
+        }
     }
 
     private void reduce(Position r, int pos, GSS.Phase target, Result only) {
@@ -83,7 +86,10 @@ final class Node
                 Node child = res.parent();
                 holder[pos] = res.getForest();
                 if (pos>0)  child.reduce(r, pos-1, target, null);
-                else new Reduction(child, r, r.rewrite(child.phase().getLocation().createRegion(target.getLocation())), target);
+                else {
+                    Input.Region region = child.phase().getLocation().createRegion(target.getLocation());
+                    new Reduction(child, r, r.rewrite(region, phase().parser().cache()), target);
+                }
             }
         holder[pos] = old;
     }
@@ -127,7 +133,7 @@ final class Node
         if (results.size()==0) return null;
         if (gv.hasNode(this)) return gv.createNode(this);
         GraphViz.Node n = gv.createNode(this);
-        n.label = ""+state.toStringx();
+        n.label = "state["+state.toInt()+"]";
         n.shape = "rectangle";
         boolean hasparents = false;
         for(Result r : results) n.edge(r, "");