checkpoint harmony

[sbp.git] / src / edu / berkeley / sbp / Parser.java

diff --git a/src/edu/berkeley/sbp/Parser.java b/src/edu/berkeley/sbp/Parser.java
index 24f8410..8869281 100644 (file)
--- a/src/edu/berkeley/sbp/Parser.java
+++ b/src/edu/berkeley/sbp/Parser.java
@@ -139,17 +139,16 @@ public abstract class Parser<T extends Token, R> {
 
             // Interface Methods //////////////////////////////////////////////////////////////////////////////
 
-            public boolean             isAccepting()               { return accept; }
-
-            public boolean             canShift(Token t)           { return oshifts.contains(t); }
-            public boolean             canReduce(Token t)          { return t==null ? eofReductions.size()>0 : oreductions.contains(t); }
-
+            boolean             isAccepting()               { return accept; }
             public Iterator<Position>  iterator()                  { return hs.iterator(); }
 
-            public <B,C> void          invokeShifts(Token t, Invokable<State,B,C> irbc, B b, C c) {
+            boolean             canShift(Token t)           { return oshifts.contains(t); }
+            <B,C> void          invokeShifts(Token t, Invokable<State,B,C> irbc, B b, C c) {
                 oshifts.invoke(t, irbc, b, c);
             }
-            public <B,C> void          invokeReductions(Token t, Invokable<Reduction,B,C> irbc, B b, C c) {
+
+            boolean             canReduce(Token t)          { return t==null ? eofReductions.size()>0 : oreductions.contains(t); }
+            <B,C> void          invokeReductions(Token t, Invokable<Reduction,B,C> irbc, B b, C c) {
                 if (t==null) for(Reduction r : eofReductions) irbc.invoke(r, b, c);
                 else         oreductions.invoke(t, irbc, b, c);
             }
@@ -236,7 +235,6 @@ public abstract class Parser<T extends Token, R> {
             }
 
             public String toString() {
-                //return "state["+idx+"]";
                 StringBuffer ret = new StringBuffer();
                 ret.append("state["+idx+"]: ");
                 for(Position p : this) ret.append("{"+p+"}  ");
@@ -253,9 +251,7 @@ public abstract class Parser<T extends Token, R> {
          */
         public class Reduction {
             // FIXME: cleanup; almost everything in here could go in either Sequence.Position.getRewrite() or else in GSS.Reduct
-            public final int numPop;
             /*private*/ final Position position;
-            private final Forest[] holder;    // to avoid constant reallocation
             public int hashCode() { return position.hashCode(); }
             public boolean equals(Object o) {
                 if (o==null) return false;
@@ -266,56 +262,56 @@ public abstract class Parser<T extends Token, R> {
             }
             public Reduction(Position p) {
                 this.position = p;
-                this.numPop = p.pos;
-                this.holder = new Forest[numPop];
             }
             public String toString() { return "[reduce " + position + "]"; }
 
             private Forest zero = null;
             public Forest zero() {
                 if (zero != null) return zero;
-                if (numPop > 0) throw new Error();
+                if (position.pos > 0) throw new Error();
                 return zero = position.rewrite(null);
             }
 
             public void reduce(GSS.Phase.Node parent) {
-                if (numPop==0) finish(parent, zero(), parent.phase());
-                else           reduce(parent, numPop-1, parent.phase());
+                Forest[] holder = new Forest[position.pos];
+                if (position.pos==0) finish(parent, zero(), parent.phase(), holder);
+                else           reduce(parent, position.pos-1, parent.phase(), holder);
             }
 
             public void reduce(GSS.Phase.Node parent, GSS.Phase.Node onlychild) {
-                if (numPop<=0) throw new Error("called wrong form of reduce()");
-                int pos = numPop-1;
+                Forest[] holder = new Forest[position.pos];
+                if (position.pos<=0) throw new Error("called wrong form of reduce()");
+                int pos = position.pos-1;
                 Forest old = holder[pos];
                 holder[pos] = parent.pending();
                 if (pos==0) {
                     System.arraycopy(holder, 0, position.holder, 0, holder.length);
-                    finish(onlychild, position.rewrite(parent.phase().getLocation()), parent.phase());
+                    finish(onlychild, position.rewrite(parent.phase().getLocation()), parent.phase(), holder);
                 } else {
-                    reduce(onlychild, pos-1, parent.phase());
+                    reduce(onlychild, pos-1, parent.phase(), holder);
                 }
                 holder[pos] = old;
             }
 
             // FIXME: this could be more elegant and/or cleaner and/or somewhere else
-            private void reduce(GSS.Phase.Node parent, int pos, GSS.Phase target) {
+            private void reduce(GSS.Phase.Node parent, int pos, GSS.Phase target, Forest[] holder) {
                 Forest old = holder[pos];
                 holder[pos] = parent.pending();
                 if (pos==0) {
                     System.arraycopy(holder, 0, position.holder, 0, holder.length);
                     for(int i=0; i<position.pos; i++) if (position.holder[i]==null) throw new Error("realbad");
                     Forest rex = position.rewrite(target.getLocation());
-                    for(GSS.Phase.Node child : parent.parents()) finish(child, rex, target);
+                    for(GSS.Phase.Node child : parent.parents()) finish(child, rex, target, holder);
                 } else {
-                    for(GSS.Phase.Node child : parent.parents()) reduce(child, pos-1, target);
+                    for(GSS.Phase.Node child : parent.parents()) reduce(child, pos-1, target, holder);
                 }
                 holder[pos] = old;
             }
-            private void finish(GSS.Phase.Node parent, Forest result, GSS.Phase target) {
+            private void finish(GSS.Phase.Node parent, Forest result, GSS.Phase target, Forest[] holder) {
                 State state = parent.state.gotoSetNonTerminals.get(position.owner());
                 if (result==null) throw new Error();
                 if (state!=null)
-                    target.newNode(parent, result, state, numPop<=0, this);
+                    target.newNode(parent, result, state, position.pos<=0, this);
             }
         }
     }