X-Git-Url: http://git.megacz.com/?p=sbp.git;a=blobdiff_plain;f=src%2Fedu%2Fberkeley%2Fsbp%2FForest.java;h=795f3a04151737daea1c9400dddee08e605aa984;hp=34982bd11d935d2e238e059e29c1eb305af18ae4;hb=584cef55d8811e3215858fde22e708d2a3d1cf70;hpb=eeb3a8b49bdbf753b5a70734fbae7f2c1ac06702

diff --git a/src/edu/berkeley/sbp/Forest.java b/src/edu/berkeley/sbp/Forest.java
index 34982bd..795f3a0 100644
--- a/src/edu/berkeley/sbp/Forest.java
+++ b/src/edu/berkeley/sbp/Forest.java
@@ -28,22 +28,13 @@ public abstract class Forest<NodeType> implements GraphViz.ToGraphViz {
 
     // Package-Private //////////////////////////////////////////////////////////////////////////////
 
-    static <NodeType> Forest<NodeType> create(Input.Region region, NodeType head, Forest<NodeType>[] children,
-                                              boolean lift) {
-        if (region == null) throw new RuntimeException("invoked Forest.create(region=null) -- this should never happen");
-        return new One<NodeType>(region, head, children, lift);
-    }
-
-    static <NodeType> Forest<NodeType> create(Input.Region region, NodeType head, Forest<NodeType>[] children,
-                                              boolean lift, boolean liftLeft) {
+    public static <NodeType> Forest<NodeType> create(Input.Region region, NodeType head, Forest<NodeType>[] children) {
+        return create(region, head, children, new boolean[children==null ? 0 : children.length]); }
+    public static <NodeType> Forest<NodeType> create(Input.Region region, NodeType head, Forest<NodeType>[] children, boolean[] lifts) {
         if (region == null) throw new RuntimeException("invoked Forest.create(region=null) -- this should never happen");
-        return new One<NodeType>(region, head, children, lift, liftLeft);
+        return new One<NodeType>(region, head, children, lifts);
     }
 
-    /** create a new forest */
-    public static <NodeType> Forest<NodeType> create(Input.Region region, NodeType head, Forest<NodeType>[] children) {
-        return Forest.create(region, head, children, false); }
-
     abstract void expand(HashSet<Tree<NodeType>> ht, HashSet<Forest<NodeType>> ignore, Tree<NodeType> bogus);
     abstract void gather(HashSet<Forest<NodeType>> ignore);
     abstract void edges(GraphViz.Node n);
@@ -59,29 +50,24 @@ public abstract class Forest<NodeType> implements GraphViz.ToGraphViz {
         private final Forest<NodeType>[]       children;
 
         /** if true, the last child's children are considered children of this node */
-        private final boolean           lift;
-        private final boolean           liftLeft;
+        private final boolean[]         lifts;
 
         public Input.Region getRegion() { return location; }
 
-        private One(Input.Region loc, NodeType head, Forest<NodeType>[] children, boolean lift) {
-            this(loc, head, children, lift, false);
-        }
-        private One(Input.Region loc, NodeType head, Forest<NodeType>[] children, boolean lift, boolean liftLeft) {
+        private One(Input.Region loc, NodeType head, Forest<NodeType>[] children, boolean[] lifts) {
             this.location = loc;
             this.head = head;
             if (head==null) throw new RuntimeException("invoked Forest.create(,null,,,) -- this should never happen");
             this.children = children==null ? emptyForestArray : new Forest[children.length];
             if (children != null) System.arraycopy(children, 0, this.children, 0, children.length);
             if (children != null) for(int i=0; i<children.length; i++) if (children[i]==null) throw new Error(i+"");
-            this.lift = lift;
-            this.liftLeft = liftLeft;
+            this.lifts = lifts;
         }
 
         public Tree<NodeType> expand1() throws Ambiguous {
             Tree<NodeType>[] ret = new Tree[children.length];
             for(int i=0; i<children.length; i++) ret[i] = children[i].expand1();
-            return new Tree<NodeType>(location, head, ret, lift, liftLeft);
+            return new Tree<NodeType>(location, head, ret, lifts);
         }
 
         void gather(HashSet<Forest<NodeType>> hf) {
@@ -95,7 +81,7 @@ public abstract class Forest<NodeType> implements GraphViz.ToGraphViz {
         private void expand(final int i, Tree<NodeType>[] ta, HashSet<Tree<NodeType>> ht, HashSet<Forest<NodeType>> ignore,
                             Tree<NodeType> bogus) {
             if (i==children.length) {
-                ht.add(new Tree<NodeType>(location, head, ta, lift, liftLeft));
+                ht.add(new Tree<NodeType>(location, head, ta, lifts));
             } else {
                 HashSet<Tree<NodeType>> ht2 = new HashSet<Tree<NodeType>>();
                 children[i].expand(ht2, ignore, bogus);
@@ -124,7 +110,7 @@ public abstract class Forest<NodeType> implements GraphViz.ToGraphViz {
             if (edges) return;
             edges = true;
             for(int i=0; i<children.length; i++) {
-                if (i==children.length-1 && lift && !children[i].ambiguous()) {
+                if (lifts[i] && !children[i].ambiguous()) {
                     children[i].edges(n);
                 } else {
                     n.edge(children[i], null);