X-Git-Url: http://git.megacz.com/?p=sbp.git;a=blobdiff_plain;f=src%2Fedu%2Fberkeley%2Fsbp%2FRepeat.java;h=037e67d58b06571328e674d05eb0cbe2cd8fbacb;hp=9cce70015107e6e576908fde9c197b4763f2f5b6;hb=b8a597c8d1a29afc24f9b89f726d5b1a9b9aeec1;hpb=c48a9498daf7604e41cf4aea7f6f7110388fd659

diff --git a/src/edu/berkeley/sbp/Repeat.java b/src/edu/berkeley/sbp/Repeat.java
index 9cce700..037e67d 100644
--- a/src/edu/berkeley/sbp/Repeat.java
+++ b/src/edu/berkeley/sbp/Repeat.java
@@ -8,17 +8,24 @@ import java.lang.reflect.*;
 import java.lang.ref.*;
 
 /** currently this class exports only static methods to create repetitions; there are no public instance methods or constructors */
-/* FIXME make private again */ public class Repeat extends Union {
+class Repeat extends Union {
 
+    public Repeat(final Element e, boolean zeroOkay, boolean manyOkay, Object tag) {
+        this(e, zeroOkay, manyOkay, null, false, tag); }
     public Repeat(final Element e, boolean zeroOkay, boolean manyOkay, final Element separator, Object tag) {
-        this(e, zeroOkay, manyOkay, separator, false, tag);
-    }
+        this(e, zeroOkay, manyOkay, separator, false, tag); }
     protected Repeat(final Element e, boolean zeroOkay, boolean manyOkay, final Element separator, boolean maximal, Object tag) {
         super(e+(!manyOkay ? "?" : (zeroOkay ? (maximal ? "**" : "*") : (maximal ? "++" : "+")))+(separator==null?"":("/"+separator)), true);
-        if (zeroOkay) {
+        if (zeroOkay && !manyOkay) {
             add(new Sequence.Constant.Empty());
-            if (manyOkay) add(new Sequence.Singleton(Sequence.many1(e, separator)));
-            else          add(new Sequence.Singleton(e));
+            add(new Sequence.Singleton(e));
+            return;
+        }
+        if (zeroOkay) {
+            add(new Sequence.RewritingSequence(tag, new Element[] { }, null));
+            //add(new Sequence.Constant.Empty());
+            // FUGLY
+            add(new Sequence.Singleton(Sequence.many1(e, separator, tag)));
         } else {
             add(new Sequence.RewritingSequence(tag, new Element[] { e }, null));
             if (separator==null)
@@ -34,12 +41,12 @@ import java.lang.ref.*;
             if (zeroOkay && separator != null)
                 throw new RuntimeException("cannot create a maximal repetition of zero or more items with a separator (yet): " + this);
             for(Sequence s : this)
-                s.follow = new edu.berkeley.sbp.misc.MetaGrammar.Invert(separator);
+                s.follow = (Atom)separator.complement();
         }
         public Maximal(final Atom e, boolean zeroOkay, boolean manyOkay, Object tag) {
             super(e, zeroOkay, manyOkay, null, true, tag);
             for(Sequence s : this)
-                s.follow = new edu.berkeley.sbp.misc.MetaGrammar.Invert(e);
+                s.follow = (Atom)e.complement();
         }
     }