X-Git-Url: http://git.megacz.com/?p=sbp.git;a=blobdiff_plain;f=src%2Fedu%2Fberkeley%2Fsbp%2FUnion.java;h=70a3e45753a8e4912a2edf343a8131922d5cd592;hp=9ac5e612065e9e6e2032f7dc59498fcaa2517197;hb=5d18f5606c9296e6b0c5749f05fc68f358ace2f6;hpb=cbae71f601dd5831cc6bf74a7407cbe067cc604a

diff --git a/src/edu/berkeley/sbp/Union.java b/src/edu/berkeley/sbp/Union.java
index 9ac5e61..70a3e45 100644
--- a/src/edu/berkeley/sbp/Union.java
+++ b/src/edu/berkeley/sbp/Union.java
@@ -10,28 +10,6 @@ import java.lang.ref.*;
 /** an element which can produce one of several alternatives */
 public class Union extends Element implements Iterable<Sequence> {
 
-    final String shortForm;
-    final boolean synthetic;
-    private final List<Sequence> alternatives = new ArrayList<Sequence>();
-
-    public Iterator<Sequence> iterator() { return alternatives.iterator(); }
-    public boolean contains(Sequence s) { return alternatives.contains(s); }
-
-    Topology toAtom() {
-        if (alternatives.size()==0) throw new RuntimeException("cannot build an Atom from a Union with no productions");
-        Topology ret = null;
-        for(Sequence s : this) {
-            Topology a = s.toAtom();
-            if (ret==null) ret = a;
-            else           ret = ret.union(a);
-        }
-        if (ret==null) throw new RuntimeException("confusion on " + this);
-        return ret;
-    }
-
-    /** adds an alternative */
-    public void add(Sequence s) { alternatives.add(s); }
-
     /**
      *  Since every cycle in a non-degenerate grammar contains at
      *  least one Union, every instance of this class must be able to
@@ -47,58 +25,62 @@ public class Union extends Element implements Iterable<Sequence> {
         this.synthetic = synthetic;
     }
 
+    /** display form for the Union (ie not including the RHS) */
+    final String shortForm;
+
+    /** this is just a hint to use when printing out the grammar in visual form */
+    final boolean synthetic;
+
+    /** the actual alternatives */
+    private final List<Sequence> alternatives = new ArrayList<Sequence>();
+
+    public Iterator<Sequence> iterator() { return alternatives.iterator(); }
+    public boolean contains(Sequence s) { return alternatives.contains(s); }
+
+    /** adds an alternative */
+    public void add(Sequence s) {
+        alternatives.add(s);
+
+        // FIXME: does this make sense?
+        for(Sequence n : s.needs) add(n);
+        for(Sequence n : s.hates) add(n);
+    }
+
+    // Epsilon Form //////////////////////////////////////////////////////////////////////////////
+
+    // FIXME
     public static Union epsilon = new Union("()");
     static { epsilon.add(Sequence.empty); }
 
+    // FIXME
     private Forest.Ref epsilonForm = null;
     Forest epsilonForm() {
         if (epsilonForm != null) return epsilonForm;
         epsilonForm = new Forest.Ref();
-        for(Sequence s : this)
-            if (s.possiblyEpsilon(null))
+        for(Sequence s : this) {
+            // FIXME FIXME FIXME
+            if (new Walk.Cache().possiblyEpsilon(s))
                 epsilonForm.merge(s.epsilonForm());
+        }
         return epsilonForm;
     }
 
     // Display //////////////////////////////////////////////////////////////////////////////
 
     public String toString() { return shortForm; }
-    private static String pad(int i,String s) { return s.length() >= i ? s : pad(i-1,s)+" "; }
-    public void toString(StringBuffer sb) {
-        if (synthetic) return;
+    public StringBuffer toString(StringBuffer sb) {
+        if (synthetic) return sb;
         boolean first = true;
         if (alternatives.size()==0) {
-            sb.append(pad(15, shortForm) + "::= ");
+            sb.append(StringUtil.pad(15, shortForm) + " = ");
         } else for(Sequence s : this) {
-            sb.append(pad(15, first ? shortForm : "") + (first ? "::= " : "  | "));
+            sb.append(StringUtil.pad(15, first ? shortForm : "") + (first ? " = " : "  | "));
             first = false;
             sb.append(s.toString());
             sb.append('\n');
         }
         sb.append('\n');
-    }
-
-    // SubUnion //////////////////////////////////////////////////////////////////////////////
-
-    /** FIXME this is kind of a hack */
-    public class Subset extends Union {
-        private final Set<Sequence> exclude;
-        public Subset(String shortForm, Set<Sequence> exclude) { super(shortForm, true); this.exclude = exclude; }
-        public Iterator<Sequence> iterator() {
-            final Iterator<Sequence> it = Union.this.iterator();
-            return new Iterator<Sequence>() {
-                private Sequence next = it.hasNext() ? it.next() : null;
-                public boolean hasNext() { return next != null; }
-                public Sequence next() {
-                    Sequence ret = next;
-                    do {
-                        next = it.hasNext() ? it.next() : null;
-                    } while (next != null && (next instanceof Sequence) && exclude.contains((Sequence)next));
-                    return ret;
-                }
-                public void remove() { throw new Error(); }
-            };
-        }
+        return sb;
     }
 
 }