projects
/
ghc-hetmet.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
|
inline
| side by side (parent:
436a5fd
)
Don't warn about unused bindings with parents in .hs-boot files; trac #3449
author
Ian Lynagh
<igloo@earth.li>
Thu, 24 Jun 2010 11:03:51 +0000
(11:03 +0000)
committer
Ian Lynagh
<igloo@earth.li>
Thu, 24 Jun 2010 11:03:51 +0000
(11:03 +0000)
compiler/rename/RnEnv.lhs
patch
|
blob
|
history
diff --git
a/compiler/rename/RnEnv.lhs
b/compiler/rename/RnEnv.lhs
index
c2b7a7b
..
ad7709a
100644
(file)
--- a/
compiler/rename/RnEnv.lhs
+++ b/
compiler/rename/RnEnv.lhs
@@
-1043,7
+1043,18
@@
warnUnusedModules mods
warnUnusedImports, warnUnusedTopBinds :: [GlobalRdrElt] -> RnM ()
warnUnusedImports gres = ifOptM Opt_WarnUnusedImports (warnUnusedGREs gres)
warnUnusedImports, warnUnusedTopBinds :: [GlobalRdrElt] -> RnM ()
warnUnusedImports gres = ifOptM Opt_WarnUnusedImports (warnUnusedGREs gres)
-warnUnusedTopBinds gres = ifOptM Opt_WarnUnusedBinds (warnUnusedGREs gres)
+warnUnusedTopBinds gres
+ = ifOptM Opt_WarnUnusedBinds
+ $ do isBoot <- tcIsHsBoot
+ let noParent gre = case gre_par gre of
+ NoParent -> True
+ ParentIs _ -> False
+ -- Don't warn about unused bindings with parents in
+ -- .hs-boot files, as you are sometimes required to give
+ -- unused bindings (trac #3449).
+ gres' = if isBoot then filter noParent gres
+ else gres
+ warnUnusedGREs gres'
warnUnusedLocalBinds, warnUnusedMatches :: [Name] -> FreeVars -> RnM ()
warnUnusedLocalBinds = check_unused Opt_WarnUnusedBinds
warnUnusedLocalBinds, warnUnusedMatches :: [Name] -> FreeVars -> RnM ()
warnUnusedLocalBinds = check_unused Opt_WarnUnusedBinds